[edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library

Xu, Wei6 posted 4 patches 3 years, 12 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
FmpDevicePkg/FmpDevicePkg.ci.yaml                  |  10 +
FmpDevicePkg/FmpDevicePkg.dec                      |  15 +-
FmpDevicePkg/FmpDevicePkg.dsc                      |  14 +-
FmpDevicePkg/FmpDevicePkg.uni                      |   4 +-
FmpDevicePkg/FmpDxe/Dependency.h                   |  63 ---
FmpDevicePkg/FmpDxe/FmpDxe.c                       | 255 ++--------
FmpDevicePkg/FmpDxe/FmpDxe.h                       |   3 +
FmpDevicePkg/FmpDxe/FmpDxe.inf                     |   4 +-
FmpDevicePkg/FmpDxe/FmpDxeLib.inf                  |   4 +-
.../Include/Library/FmpDependencyCheckLib.h        |  71 +++
FmpDevicePkg/Include/Library/FmpDependencyLib.h    | 104 ++++
.../FmpDependencyCheckLib/FmpDependencyCheckLib.c  | 533 +++++++++++++++++++++
.../FmpDependencyCheckLib.inf                      |  51 ++
.../FmpDependencyCheckLib.uni                      |  13 +
.../FmpDependencyCheckLibNull.c                    |  74 +++
.../FmpDependencyCheckLibNull.inf                  |  30 ++
.../FmpDependencyCheckLibNull.uni                  |  13 +
.../FmpDependencyLib/FmpDependencyLib.c}           | 314 ++++--------
.../Library/FmpDependencyLib/FmpDependencyLib.inf  |  34 ++
.../Library/FmpDependencyLib/FmpDependencyLib.uni  |  12 +
FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc         |  28 ++
.../FmpDependencyLib/EvaluateDependencyUnitTest.c  | 271 +++++++++++
.../FmpDependencyLibUnitTestsHost.inf              |  34 ++
.../FmpDependencyLibUnitTestsUefi.inf              |  35 ++
24 files changed, 1508 insertions(+), 481 deletions(-)
delete mode 100644 FmpDevicePkg/FmpDxe/Dependency.h
create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h
create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyLib.h
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.inf
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.uni
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.c
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.inf
create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.uni
rename FmpDevicePkg/{FmpDxe/Dependency.c => Library/FmpDependencyLib/FmpDependencyLib.c} (55%)
create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.inf
create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.uni
create mode 100644 FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc
create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/EvaluateDependencyUnitTest.c
create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsHost.inf
create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsUefi.inf
[edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library
Posted by Xu, Wei6 3 years, 12 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696

This patch series move the implementation of Fmp Capsule Dependency from
 FmpDxe driver into two library classes. FmpDependencyLib is a base lib
 to provide generic dependency evaluation services. FmpDependencyCheckLib
 is a platform lib to provide dependency check services during firmware
 update. Platform can perform the dependency check in platform specific
 manner by implementing its own FmpDependencyCheckLib.
This patch series also add unit test for EvaluateDependency API in
 FmpDependencyLib.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Wei6 Xu <wei6.xu@intel.com>


Wei6 Xu (4):
  FmpDevicePkg: Add FmpDependency library class and BASE instance
  FmpDevicePkg/Test: Add FmpDependencyLib unit test.
  FmpDevicePkg: Add FmpDependencyCheck library class and instances
  FmpDevicePkg/FmpDxe: Use FmpDependencyLib and FmpDependencyCheckLib

 FmpDevicePkg/FmpDevicePkg.ci.yaml                  |  10 +
 FmpDevicePkg/FmpDevicePkg.dec                      |  15 +-
 FmpDevicePkg/FmpDevicePkg.dsc                      |  14 +-
 FmpDevicePkg/FmpDevicePkg.uni                      |   4 +-
 FmpDevicePkg/FmpDxe/Dependency.h                   |  63 ---
 FmpDevicePkg/FmpDxe/FmpDxe.c                       | 255 ++--------
 FmpDevicePkg/FmpDxe/FmpDxe.h                       |   3 +
 FmpDevicePkg/FmpDxe/FmpDxe.inf                     |   4 +-
 FmpDevicePkg/FmpDxe/FmpDxeLib.inf                  |   4 +-
 .../Include/Library/FmpDependencyCheckLib.h        |  71 +++
 FmpDevicePkg/Include/Library/FmpDependencyLib.h    | 104 ++++
 .../FmpDependencyCheckLib/FmpDependencyCheckLib.c  | 533 +++++++++++++++++++++
 .../FmpDependencyCheckLib.inf                      |  51 ++
 .../FmpDependencyCheckLib.uni                      |  13 +
 .../FmpDependencyCheckLibNull.c                    |  74 +++
 .../FmpDependencyCheckLibNull.inf                  |  30 ++
 .../FmpDependencyCheckLibNull.uni                  |  13 +
 .../FmpDependencyLib/FmpDependencyLib.c}           | 314 ++++--------
 .../Library/FmpDependencyLib/FmpDependencyLib.inf  |  34 ++
 .../Library/FmpDependencyLib/FmpDependencyLib.uni  |  12 +
 FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc         |  28 ++
 .../FmpDependencyLib/EvaluateDependencyUnitTest.c  | 271 +++++++++++
 .../FmpDependencyLibUnitTestsHost.inf              |  34 ++
 .../FmpDependencyLibUnitTestsUefi.inf              |  35 ++
 24 files changed, 1508 insertions(+), 481 deletions(-)
 delete mode 100644 FmpDevicePkg/FmpDxe/Dependency.h
 create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h
 create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyLib.h
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.inf
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.uni
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.c
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.inf
 create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.uni
 rename FmpDevicePkg/{FmpDxe/Dependency.c => Library/FmpDependencyLib/FmpDependencyLib.c} (55%)
 create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.inf
 create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.uni
 create mode 100644 FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc
 create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/EvaluateDependencyUnitTest.c
 create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsHost.inf
 create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsUefi.inf

-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58249): https://edk2.groups.io/g/devel/message/58249
Mute This Topic: https://groups.io/mt/73326866/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library
Posted by Liming Gao 3 years, 11 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Xu, Wei6 <wei6.xu@intel.com>
> Sent: Tuesday, April 28, 2020 9:25 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Subject: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
> 
> This patch series move the implementation of Fmp Capsule Dependency from
>  FmpDxe driver into two library classes. FmpDependencyLib is a base lib
>  to provide generic dependency evaluation services. FmpDependencyCheckLib
>  is a platform lib to provide dependency check services during firmware
>  update. Platform can perform the dependency check in platform specific
>  manner by implementing its own FmpDependencyCheckLib.
> This patch series also add unit test for EvaluateDependency API in
>  FmpDependencyLib.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> 
> 
> Wei6 Xu (4):
>   FmpDevicePkg: Add FmpDependency library class and BASE instance
>   FmpDevicePkg/Test: Add FmpDependencyLib unit test.
>   FmpDevicePkg: Add FmpDependencyCheck library class and instances
>   FmpDevicePkg/FmpDxe: Use FmpDependencyLib and FmpDependencyCheckLib
> 
>  FmpDevicePkg/FmpDevicePkg.ci.yaml                  |  10 +
>  FmpDevicePkg/FmpDevicePkg.dec                      |  15 +-
>  FmpDevicePkg/FmpDevicePkg.dsc                      |  14 +-
>  FmpDevicePkg/FmpDevicePkg.uni                      |   4 +-
>  FmpDevicePkg/FmpDxe/Dependency.h                   |  63 ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c                       | 255 ++--------
>  FmpDevicePkg/FmpDxe/FmpDxe.h                       |   3 +
>  FmpDevicePkg/FmpDxe/FmpDxe.inf                     |   4 +-
>  FmpDevicePkg/FmpDxe/FmpDxeLib.inf                  |   4 +-
>  .../Include/Library/FmpDependencyCheckLib.h        |  71 +++
>  FmpDevicePkg/Include/Library/FmpDependencyLib.h    | 104 ++++
>  .../FmpDependencyCheckLib/FmpDependencyCheckLib.c  | 533 +++++++++++++++++++++
>  .../FmpDependencyCheckLib.inf                      |  51 ++
>  .../FmpDependencyCheckLib.uni                      |  13 +
>  .../FmpDependencyCheckLibNull.c                    |  74 +++
>  .../FmpDependencyCheckLibNull.inf                  |  30 ++
>  .../FmpDependencyCheckLibNull.uni                  |  13 +
>  .../FmpDependencyLib/FmpDependencyLib.c}           | 314 ++++--------
>  .../Library/FmpDependencyLib/FmpDependencyLib.inf  |  34 ++
>  .../Library/FmpDependencyLib/FmpDependencyLib.uni  |  12 +
>  FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc         |  28 ++
>  .../FmpDependencyLib/EvaluateDependencyUnitTest.c  | 271 +++++++++++
>  .../FmpDependencyLibUnitTestsHost.inf              |  34 ++
>  .../FmpDependencyLibUnitTestsUefi.inf              |  35 ++
>  24 files changed, 1508 insertions(+), 481 deletions(-)
>  delete mode 100644 FmpDevicePkg/FmpDxe/Dependency.h
>  create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h
>  create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyLib.h
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.inf
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.uni
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.c
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.inf
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.uni
>  rename FmpDevicePkg/{FmpDxe/Dependency.c => Library/FmpDependencyLib/FmpDependencyLib.c} (55%)
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.inf
>  create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.uni
>  create mode 100644 FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc
>  create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/EvaluateDependencyUnitTest.c
>  create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsHost.inf
>  create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/FmpDependencyLibUnitTestsUefi.inf
> 
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58712): https://edk2.groups.io/g/devel/message/58712
Mute This Topic: https://groups.io/mt/73326866/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-