1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h

GH Cao posted 1 patch 3 years, 11 months ago
Failed in applying to current master (apply log)
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
Posted by GH Cao 3 years, 11 months ago 
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.

Signed-off-by: GH Cao <driver1998@foxmail.com>
---
 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
index e2581b8..2d7da75 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
@@ -11,7 +11,7 @@
 #ifndef __BCM2836_PWM_H__
 #define __BCM2836_PWM_H__
 
-/* Power Management constants */
+/* PWM controller constants */
 
 #define BCM2836_PWM_DMA_OFFSET                              0x00007B00
 #define BCM2836_PWM_DMA_BASE_ADDRESS                        (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58210): https://edk2.groups.io/g/devel/message/58210
Mute This Topic: https://groups.io/mt/73322161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
Posted by Pete Batard 3 years, 11 months ago 
On 2020.04.28 06:08, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
> 
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
>   #ifndef __BCM2836_PWM_H__
>   #define __BCM2836_PWM_H__
>   
> -/* Power Management constants */
> +/* PWM controller constants */
>   
>   #define BCM2836_PWM_DMA_OFFSET                              0x00007B00
>   #define BCM2836_PWM_DMA_BASE_ADDRESS                        (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
> 

Reviewed-by: Pete Batard <pete@akeo.ie>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58220): https://edk2.groups.io/g/devel/message/58220
Mute This Topic: https://groups.io/mt/73322161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago 
On 4/28/20 7:08 AM, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
> 
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
>   #ifndef __BCM2836_PWM_H__
>   #define __BCM2836_PWM_H__
>   
> -/* Power Management constants */
> +/* PWM controller constants */
>   
>   #define BCM2836_PWM_DMA_OFFSET                              0x00007B00
>   #define BCM2836_PWM_DMA_BASE_ADDRESS                        (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58229): https://edk2.groups.io/g/devel/message/58229
Mute This Topic: https://groups.io/mt/73322161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
Posted by Ard Biesheuvel 3 years, 11 months ago 
On 4/28/20 1:25 PM, Philippe Mathieu-Daudé wrote:
> On 4/28/20 7:08 AM, GH Cao wrote:
>> The original comment incorrectly named the PWM controller as Power 
>> Management
>> Contoller, this commit fixes it.
>>
>> Signed-off-by: GH Cao <driver1998@foxmail.com>
>> ---
>>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git 
>> a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h 
>> b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> index e2581b8..2d7da75 100644
>> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> @@ -11,7 +11,7 @@
>>   #ifndef __BCM2836_PWM_H__
>>   #define __BCM2836_PWM_H__
>> -/* Power Management constants */
>> +/* PWM controller constants */
>>   #define BCM2836_PWM_DMA_OFFSET                              0x00007B00
>>   #define BCM2836_PWM_DMA_BASE_ADDRESS                        
>> (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>>
> 
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 

Thanks all

Series pushed as 6e4ebde90186..1b2461ea7f2f


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58397): https://edk2.groups.io/g/devel/message/58397
Mute This Topic: https://groups.io/mt/73322161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.