REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
BrotliCompress submodule change for BaseTools causes untracked
files in BaseTools after building. This is regression for git.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .gitmodules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitmodules b/.gitmodules
index 41099f6fd701..29370a5c2fe8 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -16,3 +16,4 @@
 [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
 	path = BaseTools/Source/C/BrotliCompress/brotli
 	url = https://github.com/google/brotli
+	ignore = untracked
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58156): https://edk2.groups.io/g/devel/message/58156
Mute This Topic: https://groups.io/mt/73295886/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Monday, April 27, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Sean Brogan <sean.brogan@microsoft.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH] .gitmodules: ignore untracked files in brotli
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .gitmodules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
>  [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
>  	path = BaseTools/Source/C/BrotliCompress/brotli
>  	url = https://github.com/google/brotli
> +	ignore = untracked
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58181): https://edk2.groups.io/g/devel/message/58181
Mute This Topic: https://groups.io/mt/73295886/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On 04/27/20 03:20, Shenglei Zhang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .gitmodules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
>  [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
>  	path = BaseTools/Source/C/BrotliCompress/brotli
>  	url = https://github.com/google/brotli
> +	ignore = untracked
> 

Looks plausible -- I haven't been aware of this setting, but it is
indeed documented in the gitmodules(5) manual.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58244): https://edk2.groups.io/g/devel/message/58244
Mute This Topic: https://groups.io/mt/73295886/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-