[edk2-devel] [PATCH 2/2] BhyvePkg: Update BhyvePkgX64.dsc to use DxeResetSystemLibBhyve

Rebecca Cran posted 2 patches 5 years, 9 months ago
[edk2-devel] [PATCH 2/2] BhyvePkg: Update BhyvePkgX64.dsc to use DxeResetSystemLibBhyve
Posted by Rebecca Cran 5 years, 9 months ago
bhyve uses a different method for powering off guests than OVMF, so
use the new DxeResetSystemLibBhyve library to support that.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
---
 BhyvePkg/BhyvePkgX64.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BhyvePkg/BhyvePkgX64.dsc b/BhyvePkg/BhyvePkgX64.dsc
index 51e565994c..554adeb9b9 100644
--- a/BhyvePkg/BhyvePkgX64.dsc
+++ b/BhyvePkg/BhyvePkgX64.dsc
@@ -173,7 +173,7 @@
   DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
 !endif
 
-  ResetSystemLib|OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
+  ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibBhyve.inf
   LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
   IoApicLib|PcAtChipsetPkg/Library/BaseIoApicLib/BaseIoApicLib.inf
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
-- 
2.20.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57896): https://edk2.groups.io/g/devel/message/57896
Mute This Topic: https://groups.io/mt/73211875/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] BhyvePkg: Update BhyvePkgX64.dsc to use DxeResetSystemLibBhyve
Posted by Laszlo Ersek 5 years, 9 months ago
On 04/23/20 05:02, Rebecca Cran wrote:
> bhyve uses a different method for powering off guests than OVMF, so
> use the new DxeResetSystemLibBhyve library to support that.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> ---
>  BhyvePkg/BhyvePkgX64.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BhyvePkg/BhyvePkgX64.dsc b/BhyvePkg/BhyvePkgX64.dsc
> index 51e565994c..554adeb9b9 100644
> --- a/BhyvePkg/BhyvePkgX64.dsc
> +++ b/BhyvePkg/BhyvePkgX64.dsc
> @@ -173,7 +173,7 @@
>    DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
>  !endif
>  
> -  ResetSystemLib|OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +  ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibBhyve.inf
>    LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
>    IoApicLib|PcAtChipsetPkg/Library/BaseIoApicLib/BaseIoApicLib.inf
>    DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> 

This patch should be submitted later, because it depends on both your
BhyvePkg series, and on patch#1 in this series.

Further, under patch#1, I'm going to recommend to call this instance
BaseResetSystemLibBhyve, not "Dxe...". I'll explain why under patch#1.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58074): https://edk2.groups.io/g/devel/message/58074
Mute This Topic: https://groups.io/mt/73211875/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-