Integrate BDS Hook Points into New Platforms

[edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

Posted by Nate DeSimone 4 years, 7 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336

Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events

What was done:

* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModulePkg

* Included BdsHookDxe to register the callbacks implemented
in BdsHookLib

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc   | 4 ++++
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf   | 1 +
 2 files changed, 5 insertions(+)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index 2ab9cb03ea..536ed7fb09 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -224,6 +224,8 @@
   #######################################
   DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
   DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
+  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf
 
   #######################################
   # Board-specific
@@ -446,3 +448,5 @@
   $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
 !endif
   BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
index 199e3876bf..0d99114961 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
@@ -345,6 +345,7 @@ INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
 INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
 INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
 INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
 
 #
 # eMMC/SD Card
-- 
2.26.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57763): https://edk2.groups.io/g/devel/message/57763
Mute This Topic: https://groups.io/mt/73182360/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

Posted by Chaganty, Rangasai V 4 years, 7 months ago

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Tuesday, April 21, 2020 1:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336

Added a DXE driver that registers the minimum platform BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events

What was done:

* Included an instance of BdsHookLib and BoardBootManagerLib from BoardModulePkg

* Included BdsHookDxe to register the callbacks implemented in BdsHookLib

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc   | 4 ++++
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf   | 1 +
 2 files changed, 5 insertions(+)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index 2ab9cb03ea..536ed7fb09 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -224,6 +224,8 @@
   #######################################
   DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
   DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+  
+ BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib
+ .inf  
+ BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBo
+ otManagerLib.inf
 
   #######################################
   # Board-specific
@@ -446,3 +448,5 @@
   $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
 !endif
   BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
index 199e3876bf..0d99114961 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
@@ -345,6 +345,7 @@ INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
 INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
 INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
 INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
 
 #
 # eMMC/SD Card
--
2.26.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57916): https://edk2.groups.io/g/devel/message/57916
Mute This Topic: https://groups.io/mt/73182360/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

Posted by Chiu, Chasel 4 years, 7 months ago

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>

________________________________
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Wednesday, April 22, 2020 4:40 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336

Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events

What was done:

* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModulePkg

* Included BdsHookDxe to register the callbacks implemented
in BdsHookLib

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc   | 4 ++++
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf   | 1 +
 2 files changed, 5 insertions(+)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index 2ab9cb03ea..536ed7fb09 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -224,6 +224,8 @@
   #######################################
   DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
   DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
+  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf

   #######################################
   # Board-specific
@@ -446,3 +448,5 @@
   $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
 !endif
   BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
index 199e3876bf..0d99114961 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
@@ -345,6 +345,7 @@ INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
 INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
 INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
 INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf

 #
 # eMMC/SD Card
--
2.26.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58021): https://edk2.groups.io/g/devel/message/58021
Mute This Topic: https://groups.io/mt/73182360/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

Posted by Michael Kubacki 4 years, 7 months ago

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/21/2020 1:40 PM, Nate DeSimone wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
> 
> Added a DXE driver that registers the minimum platform
> BDS hook points, to WhiskeylakeURvp board.
> These hooks are triggered on the BDS hook events
> 
> What was done:
> 
> * Included an instance of BdsHookLib and BoardBootManagerLib
> from BoardModulePkg
> 
> * Included BdsHookDxe to register the callbacks implemented
> in BdsHookLib
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
> ---
>   .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc   | 4 ++++
>   .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf   | 1 +
>   2 files changed, 5 insertions(+)
> 
> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index 2ab9cb03ea..536ed7fb09 100644
> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -224,6 +224,8 @@
>     #######################################
>     DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
>     DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
> +  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
> +  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf
>   
>     #######################################
>     # Board-specific
> @@ -446,3 +448,5 @@
>     $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
>   !endif
>     BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
> +  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
> +
> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
> index 199e3876bf..0d99114961 100644
> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
> @@ -345,6 +345,7 @@ INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
>   INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
>   INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
>   INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
> +INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
>   
>   #
>   # eMMC/SD Card
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57873): https://edk2.groups.io/g/devel/message/57873
Mute This Topic: https://groups.io/mt/73182360/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver
[edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver