1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Ashley E Desimone posted 1 patch 4 years ago
Failed in applying to current master (apply log)
edkrepo/config/config_factory.py     | 2 +-
edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Posted by Ashley E Desimone 4 years ago 
Remote the 'delimeters='=' from the instantation of
config parser objects in the BaseConfig class and update
the manifest-repos section of the edkrepo.cfg to remove the
'=' from after the manifest repo name.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py     | 2 +-
 edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
         self.read_only = read_only
         self.filename = filename
         self.global_data_dir = global_data_dir
-        self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+        self.cfg = configparser.ConfigParser(allow_no_value=True)
         if os.path.isfile(self.filename):
             self.cfg.read(self.filename)
 
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
 [manifest-repos]
-edk2-staging = 
+edk2-staging
 
 [edk2-staging]
 URL = https://github.com/tianocore/edk2-staging.git
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57665): https://edk2.groups.io/g/devel/message/57665
Mute This Topic: https://groups.io/mt/73161101/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Posted by Bjorge, Erik C 4 years ago 
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E Desimone
Sent: Monday, April 20, 2020 3:21 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py     | 2 +-
 edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
         self.read_only = read_only
         self.filename = filename
         self.global_data_dir = global_data_dir
-        self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+        self.cfg = configparser.ConfigParser(allow_no_value=True)
         if os.path.isfile(self.filename):
             self.cfg.read(self.filename)
 
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
 [manifest-repos]
-edk2-staging = 
+edk2-staging
 
 [edk2-staging]
 URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57667): https://edk2.groups.io/g/devel/message/57667
Mute This Topic: https://groups.io/mt/73161101/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Posted by Nate DeSimone 4 years ago 
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E Desimone
Sent: Monday, April 20, 2020 3:21 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py     | 2 +-
 edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
         self.read_only = read_only
         self.filename = filename
         self.global_data_dir = global_data_dir
-        self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+        self.cfg = configparser.ConfigParser(allow_no_value=True)
         if os.path.isfile(self.filename):
             self.cfg.read(self.filename)
 
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
 [manifest-repos]
-edk2-staging = 
+edk2-staging
 
 [edk2-staging]
 URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57698): https://edk2.groups.io/g/devel/message/57698
Mute This Topic: https://groups.io/mt/73161101/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.