Its been observed that in MenuManagerMenuApp when user
selects a different BootOption using Up/Down key, the
current Cursor position is not chaning.
Still points to the old BootOption.

This changes first dispalys/redraws the old BootOption
followed by new BootOption. Doing so will make current
cursor pointing to the user selected BootOption.

Signed-off-by: Abdul Lateef Attar <abdul@marvell.com>
---
 .../BootManagerMenuApp/BootManagerMenu.c           | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
index 34d4089a55..9e729074ec 100644
--- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
+++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c
@@ -451,20 +451,10 @@ BootMenuSelectItem (
   }
 
   //
-  // Print want to select item
-  //
-  FirstItem = BootMenuData->ScrollBarControl.FirstItem;
-  gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLACK);
-  String = HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[WantSelectItem], NULL);
-  PrintCol = StartCol  + 1;
-  PrintRow = StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - FirstItem;
-  PrintStringAt (PrintCol, PrintRow, String);
-  FreePool (String);
-
-  //
   // if Want Select and selected item isn't the same and doesn't re-draw selectable
   // items, clear select item
   //
+  FirstItem = BootMenuData->ScrollBarControl.FirstItem;
   if (WantSelectItem != BootMenuData->SelectItem && !RePaintItems) {
     gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLUE);
     String = HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[BootMenuData->SelectItem], NULL);
@@ -474,6 +464,16 @@ BootMenuSelectItem (
     FreePool (String);
   }
 
+  //
+  // Print want to select item
+  //
+  gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLACK);
+  String = HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[WantSelectItem], NULL);
+  PrintCol = StartCol  + 1;
+  PrintRow = StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - FirstItem;
+  PrintStringAt (PrintCol, PrintRow, String);
+  FreePool (String);
+
   gST->ConOut->SetAttribute (gST->ConOut, SavedAttribute);
   BootMenuData->SelectItem = WantSelectItem;
   return EFI_SUCCESS;
-- 
2.11.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57614): https://edk2.groups.io/g/devel/message/57614
Mute This Topic: https://groups.io/mt/73146931/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Reviewed-by: Dandan Bi <dandan.bi@intel.com>


Thanks,
Dandan
> -----Original Message-----
> From: Abdul Lateef Attar <abdul@marvell.com>
> Sent: Monday, April 20, 2020 3:06 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Abdul Lateef Attar <abdul@marvell.com>
> Subject: [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption.
> 
> Its been observed that in MenuManagerMenuApp when user selects a
> different BootOption using Up/Down key, the current Cursor position is not
> chaning.
> Still points to the old BootOption.
> 
> This changes first dispalys/redraws the old BootOption followed by new
> BootOption. Doing so will make current cursor pointing to the user selected
> BootOption.
> 
> Signed-off-by: Abdul Lateef Attar <abdul@marvell.com>
> ---
>  .../BootManagerMenuApp/BootManagerMenu.c           | 22 +++++++++++---
> --------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.
> c
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.
> c
> index 34d4089a55..9e729074ec 100644
> ---
> a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.
> c
> +++
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.
> c
> @@ -451,20 +451,10 @@ BootMenuSelectItem (
>    }
> 
>    //
> -  // Print want to select item
> -  //
> -  FirstItem = BootMenuData->ScrollBarControl.FirstItem;
> -  gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE |
> EFI_BACKGROUND_BLACK);
> -  String = HiiGetString (gStringPackHandle, BootMenuData-
> >PtrTokens[WantSelectItem], NULL);
> -  PrintCol = StartCol  + 1;
> -  PrintRow = StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem -
> FirstItem;
> -  PrintStringAt (PrintCol, PrintRow, String);
> -  FreePool (String);
> -
> -  //
>    // if Want Select and selected item isn't the same and doesn't re-draw
> selectable
>    // items, clear select item
>    //
> +  FirstItem = BootMenuData->ScrollBarControl.FirstItem;
>    if (WantSelectItem != BootMenuData->SelectItem && !RePaintItems) {
>      gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE |
> EFI_BACKGROUND_BLUE);
>      String = HiiGetString (gStringPackHandle, BootMenuData-
> >PtrTokens[BootMenuData->SelectItem], NULL); @@ -474,6 +464,16 @@
> BootMenuSelectItem (
>      FreePool (String);
>    }
> 
> +  //
> +  // Print want to select item
> +  //
> +  gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE |
> + EFI_BACKGROUND_BLACK);  String = HiiGetString (gStringPackHandle,
> + BootMenuData->PtrTokens[WantSelectItem], NULL);  PrintCol = StartCol
> + + 1;  PrintRow = StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem -
> + FirstItem;  PrintStringAt (PrintCol, PrintRow, String);  FreePool
> + (String);
> +
>    gST->ConOut->SetAttribute (gST->ConOut, SavedAttribute);
>    BootMenuData->SelectItem = WantSelectItem;
>    return EFI_SUCCESS;
> --
> 2.11.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58783): https://edk2.groups.io/g/devel/message/58783
Mute This Topic: https://groups.io/mt/73146931/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-