1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix
  4. View patch

[edk2-devel] [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines

Laszlo Ersek posted 6 patches 5 years, 9 months ago
[edk2-devel] [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines
Posted by Laszlo Ersek 5 years, 9 months ago 
Wrap the source code and the INF file at 79 characters.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf |  3 ++-
 OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c   | 20 +++++++++++---------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
index 2f24dac87faf..063dc49f2453 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
@@ -15,7 +15,8 @@ [Defines]
   LIBRARY_CLASS                  = ResetSystemLib
 
 #
-# The following information is for reference only and not required by the build tools.
+# The following information is for reference only and not required by the build
+# tools.
 #
 #  VALID_ARCHITECTURES           = IA32 X64
 #
diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
index 2f2e1293a3ef..b3abda80e75a 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -103,10 +103,11 @@ ResetShutdown (
 
 /**
   This function causes a systemwide reset. The exact type of the reset is
-  defined by the EFI_GUID that follows the Null-terminated Unicode string passed
-  into ResetData. If the platform does not recognize the EFI_GUID in ResetData
-  the platform must pick a supported reset type to perform.The platform may
-  optionally log the parameters from any non-normal reset that occurs.
+  defined by the EFI_GUID that follows the Null-terminated Unicode string
+  passed into ResetData. If the platform does not recognize the EFI_GUID in
+  ResetData the platform must pick a supported reset type to perform.The
+  platform may optionally log the parameters from any non-normal reset that
+  occurs.
 
   @param[in]  DataSize   The size, in bytes, of ResetData.
   @param[in]  ResetData  The data buffer starts with a Null-terminated string,
@@ -128,11 +129,12 @@ ResetPlatformSpecific (
   @param[in] ResetType      The type of reset to perform.
   @param[in] ResetStatus    The status code for the reset.
   @param[in] DataSize       The size, in bytes, of ResetData.
-  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
-                            the data buffer starts with a Null-terminated string, optionally
-                            followed by additional binary data. The string is a description
-                            that the caller may use to further indicate the reason for the
-                            system reset.
+  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm, or
+                            EfiResetShutdown the data buffer starts with a
+                            Null-terminated string, optionally followed by
+                            additional binary data. The string is a description
+                            that the caller may use to further indicate the
+                            reason for the system reset.
 **/
 VOID
 EFIAPI
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57518): https://edk2.groups.io/g/devel/message/57518
Mute This Topic: https://groups.io/mt/73085503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines
Posted by Philippe Mathieu-Daudé 5 years, 9 months ago 
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
> Wrap the source code and the INF file at 79 characters.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf |  3 ++-
>   OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c   | 20 +++++++++++---------
>   2 files changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> index 2f24dac87faf..063dc49f2453 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> @@ -15,7 +15,8 @@ [Defines]
>     LIBRARY_CLASS                  = ResetSystemLib
>   
>   #
> -# The following information is for reference only and not required by the build tools.
> +# The following information is for reference only and not required by the build
> +# tools.
>   #
>   #  VALID_ARCHITECTURES           = IA32 X64
>   #
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 2f2e1293a3ef..b3abda80e75a 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -103,10 +103,11 @@ ResetShutdown (
>   
>   /**
>     This function causes a systemwide reset. The exact type of the reset is
> -  defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> -  into ResetData. If the platform does not recognize the EFI_GUID in ResetData
> -  the platform must pick a supported reset type to perform.The platform may
> -  optionally log the parameters from any non-normal reset that occurs.
> +  defined by the EFI_GUID that follows the Null-terminated Unicode string
> +  passed into ResetData. If the platform does not recognize the EFI_GUID in
> +  ResetData the platform must pick a supported reset type to perform.The
> +  platform may optionally log the parameters from any non-normal reset that
> +  occurs.
>   
>     @param[in]  DataSize   The size, in bytes, of ResetData.
>     @param[in]  ResetData  The data buffer starts with a Null-terminated string,
> @@ -128,11 +129,12 @@ ResetPlatformSpecific (
>     @param[in] ResetType      The type of reset to perform.
>     @param[in] ResetStatus    The status code for the reset.
>     @param[in] DataSize       The size, in bytes, of ResetData.
> -  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
> -                            the data buffer starts with a Null-terminated string, optionally
> -                            followed by additional binary data. The string is a description
> -                            that the caller may use to further indicate the reason for the
> -                            system reset.
> +  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm, or
> +                            EfiResetShutdown the data buffer starts with a
> +                            Null-terminated string, optionally followed by
> +                            additional binary data. The string is a description
> +                            that the caller may use to further indicate the
> +                            reason for the system reset.
>   **/
>   VOID
>   EFIAPI
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57525): https://edk2.groups.io/g/devel/message/57525
Mute This Topic: https://groups.io/mt/73085503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.