Hi Pankaj,
When importing these patches, I get a number of git warnings:
0001-Silicon-NXP-Add-I2c-lib.patch
Applying: Silicon/NXP: Add I2c lib
.git/rebase-apply/patch:733: new blank line at EOF.
+
.git/rebase-apply/patch:770: new blank line at EOF.
+
.git/rebase-apply/patch:881: new blank line at EOF.
+
.git/rebase-apply/patch:912: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
0012-Silicon-NXP-Move-RAM-retrieval-from-SocLib.patch
Applying: Silicon/NXP: Move RAM retrieval from SocLib
.git/rebase-apply/patch:337: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
0013-Platform-NXP-LS1043aRdbPkg-Add-Clock-retrieval-APIs.patch
Applying: Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs
.git/rebase-apply/patch:193: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
0016-Silicon-NXP-Add-Chassis2-Package.patch
Applying: Silicon/NXP: Add Chassis2 Package
.git/rebase-apply/patch:45: new blank line at EOF.
+
.git/rebase-apply/patch:244: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
0020-NXP-LS1043aRdbPkg-Use-ArmPlatformHelper.S-from-ArmPl.patch
Applying: NXP: LS1043aRdbPkg: Use ArmPlatformHelper.S from
ArmPlatformPkg
.git/rebase-apply/patch:105: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
These are trivial and I can fix them up here for any patches that are
ready to push, but if there is a v4, can you check and update?
Verify by importing the patches to a clean branch using git am of the
patches you would send to the list.
(Note to self - we really should add a test for this to PatchCheck.py,
I've raised https://bugzilla.tianocore.org/show_bug.cgi?id=2685 to
covert this.)
Regards,
Leif
On Wed, Apr 15, 2020 at 17:43:18 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal@nxp.com>
>
> This patch series adds PEI phase to NXP LS1043ARDB Platform.
> V2 series can be referred here:
> https://edk2.groups.io/g/devel/message/56009
>
> I have taken care of the review comments received on v2 and have
> removed/added these commits w.r.t V2:
>
> Removed in V3 (present in V2):
> 07/28 Silicon/NXP: Implement SerialUartClockLib
> 08/28 Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib
> 09/28 Silicon/NXP: Drop DUartPortLib
>
> These commits have been dropped for now. the discussion in ongoing for
> using BaseSerialPortLib16550 @ https://edk2.groups.io/g/devel/message/54629
> Once that discussion is concluded, i can submit these patches.
>
> 21/28 Slicon/NXP: Add PlatformPei Lib
>
> as per discussion on https://edk2.groups.io/g/devel/message/56015
> i am dropping this commit for now. when i submit the patches to print more
> info about SOC, i can submit this patch with those.
>
> 23/28 NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool
>
> discussion ongoing @ https://edk2.groups.io/g/devel/message/56019
> Once that discussion is concluded, i can submit this patch.
>
> Added in V3 (not present in V2)
> 15/24 Silicon: NXP: Remove direct calls to SwapMmio* APIs
>
> Added as per comments @ https://edk2.groups.io/g/devel/message/56012
>
> Pankaj Bansal (24):
> Silicon/NXP: Add I2c lib
> Silicon/NXP: changes to use I2clib in i2cdxe
> Silicon/NXP/I2cDxe: Fix I2c Timeout with RTC
> Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib
> Silicon/Maxim: Add comments in Ds1307RtcLib
> NXP/LS1043aRdb: Move Soc specific components to soc files
> Silicon/NXP: remove print information from Soc lib
> Silicon/NXP: remove not needed components
> Silicon/NXP: Remove unnecessary PCDs
> Silicon/NXP: Move dsc file
> Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg
> Silicon/NXP: Move RAM retrieval from SocLib
> Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs
> Silicon/NXP: Use Clock retrieval PPI in modules
> Silicon: NXP: Remove direct calls to SwapMmio* APIs
> Silicon/NXP: Add Chassis2 Package
> Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg
> Silicon/NXP/LS1043A: Move SocLib to Soc Package
> NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit
> NXP: LS1043aRdbPkg: Use ArmPlatformHelper.S from ArmPlatformPkg
> Platform/NXP: Use FV rules from ArmVirtPkg
> Platform/NXP/LS1043aRdbPkg: Add VarStore
> Silicon/NXP: move MemoryInitPeiLib as per PEIM structures
> Platform/NXP/LS1043aRdbPkg: Add PEI Phase
>
> Silicon/NXP/Chassis2/Chassis2.dec | 23 +
> Silicon/NXP/NxpQoriqLs.dec | 95 +--
> Silicon/NXP/Chassis2/Chassis2.dsc.inc | 10 +
> Silicon/NXP/LS1043A/LS1043A.dsc.inc | 48 +-
> {Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc | 71 ++-
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 26 +-
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 21 +-
> .../Drivers/PlatformDxe/PlatformDxe.inf | 11 +-
> .../Library/ArmPlatformLib/ArmPlatformLib.inf | 41 ++
> .../Library/PlatformLib/ArmPlatformLib.inf | 55 --
> .../Library/ChassisLib/ChassisLib.inf | 34 +
> Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf | 14 +-
> Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf | 27 +
> .../NXP/Library/DUartPortLib/DUartPortLib.inf | 5 +-
> Silicon/NXP/Library/I2cLib/I2cLib.inf | 31 +
> .../MemoryInitPeiLib.inf | 10 +-
> Silicon/NXP/Library/SocLib/LS1043aSocLib.inf | 45 --
> Silicon/NXP/Chassis2/Include/Chassis.h | 34 +
> Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 50 +-
> Silicon/NXP/Include/Chassis2/LsSerDes.h | 62 --
> Silicon/NXP/Include/Chassis2/NxpSoc.h | 361 -----------
> Silicon/NXP/Include/DramInfo.h | 38 --
> Silicon/NXP/Include/Library/ChassisLib.h | 51 ++
> Silicon/NXP/Include/Library/I2cLib.h | 120 ++++
> Silicon/NXP/Include/Library/IoAccessLib.h | 236 +------
> Silicon/NXP/Include/Library/SocLib.h | 52 ++
> Silicon/NXP/Include/Ppi/NxpPlatformGetClock.h | 53 ++
> Silicon/NXP/LS1043A/Include/Soc.h | 55 ++
> Silicon/NXP/LS1043A/Include/SocSerDes.h | 51 --
> Silicon/NXP/Library/DUartPortLib/DUart.h | 8 +-
> Silicon/NXP/Library/I2cLib/I2cLibInternal.h | 105 ++++
> .../MemoryInitPeiLib/MemoryInitPeiLib.h | 25 +
> Silicon/NXP/Library/SocLib/NxpChassis.h | 136 ----
> .../Drivers/PlatformDxe/PlatformDxe.c | 15 +-
> .../ArmPlatformLib.c | 61 +-
> .../ArmPlatformLibMem.c} | 79 ++-
> .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 23 +-
> .../Chassis2/Library/ChassisLib/ChassisLib.c | 97 +++
> Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 533 +---------------
> Silicon/NXP/LS1043A/Library/SocLib/SocLib.c | 77 +++
> .../NXP/Library/DUartPortLib/DUartPortLib.c | 7 +-
> Silicon/NXP/Library/I2cLib/I2cLib.c | 589 ++++++++++++++++++
> Silicon/NXP/Library/IoAccessLib/IoAccessLib.c | 17 +-
> .../Library/MemoryInitPei/MemoryInitPeiLib.c | 140 -----
> .../MemoryInitPeiLib/MemoryInitPeiLib.c | 267 ++++++++
> Silicon/NXP/Library/SocLib/Chassis.c | 495 ---------------
> Silicon/NXP/Library/SocLib/Chassis2/Soc.c | 162 -----
> Silicon/NXP/Library/SocLib/SerDes.c | 268 --------
> Platform/NXP/FVRules.fdf.inc | 59 +-
> .../AArch64/ArmPlatformHelper.S | 45 ++
> .../Library/PlatformLib/NxpQoriqLsHelper.S | 31 -
> Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc | 91 +++
> 52 files changed, 2131 insertions(+), 2929 deletions(-)
> create mode 100644 Silicon/NXP/Chassis2/Chassis2.dec
> create mode 100644 Silicon/NXP/Chassis2/Chassis2.dsc.inc
> rename {Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc (85%)
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> delete mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf
> create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/ChassisLib.inf
> create mode 100644 Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf
> create mode 100644 Silicon/NXP/Library/I2cLib/I2cLib.inf
> rename Silicon/NXP/Library/{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.inf (74%)
> delete mode 100644 Silicon/NXP/Library/SocLib/LS1043aSocLib.inf
> create mode 100644 Silicon/NXP/Chassis2/Include/Chassis.h
> delete mode 100644 Silicon/NXP/Include/Chassis2/LsSerDes.h
> delete mode 100644 Silicon/NXP/Include/Chassis2/NxpSoc.h
> delete mode 100644 Silicon/NXP/Include/DramInfo.h
> create mode 100644 Silicon/NXP/Include/Library/ChassisLib.h
> create mode 100644 Silicon/NXP/Include/Library/I2cLib.h
> create mode 100644 Silicon/NXP/Include/Library/SocLib.h
> create mode 100644 Silicon/NXP/Include/Ppi/NxpPlatformGetClock.h
> create mode 100644 Silicon/NXP/LS1043A/Include/Soc.h
> delete mode 100644 Silicon/NXP/LS1043A/Include/SocSerDes.h
> create mode 100644 Silicon/NXP/Library/I2cLib/I2cLibInternal.h
> create mode 100644 Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.h
> delete mode 100644 Silicon/NXP/Library/SocLib/NxpChassis.h
> rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c (51%)
> rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} (54%)
> create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/ChassisLib.c
> create mode 100644 Silicon/NXP/LS1043A/Library/SocLib/SocLib.c
> create mode 100644 Silicon/NXP/Library/I2cLib/I2cLib.c
> delete mode 100644 Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.c
> create mode 100644 Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c
> delete mode 100644 Silicon/NXP/Library/SocLib/Chassis.c
> delete mode 100644 Silicon/NXP/Library/SocLib/Chassis2/Soc.c
> delete mode 100644 Silicon/NXP/Library/SocLib/SerDes.c
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S
> delete mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S
> create mode 100644 Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc
>
> --
> 2.17.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57806): https://edk2.groups.io/g/devel/message/57806
Mute This Topic: https://groups.io/mt/73008793/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-