[edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

Samer El-Haj-Mahmoud posted 3 patches 4 years ago
Failed in applying to current master (apply log)
There is a newer version of this series
Platform/RaspberryPi/RPi3/RPi3.dsc            |    2 +-
Platform/RaspberryPi/RPi4/RPi4.dsc            |    2 +-
Platform/RaspberryPi/RPi3/RPi3.fdf            |    2 +-
Platform/RaspberryPi/RPi4/RPi4.fdf            |    2 +-
.../GraphicsConsoleDxe/GraphicsConsoleDxe.inf |   68 -
.../GraphicsConsoleDxe/GraphicsConsole.h      |  585 ------
.../GraphicsConsoleDxe/ComponentName.c        |  177 --
.../GraphicsConsoleDxe/GraphicsConsole.c      | 1831 -----------------
.../Drivers/GraphicsConsoleDxe/NewFont.c      |  281 ---
.../GraphicsConsoleDxe/GraphicsConsoleDxe.uni |   12 -
.../GraphicsConsoleDxeExtra.uni               |   12 -
11 files changed, 4 insertions(+), 2970 deletions(-)
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.h
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/ComponentName.c
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.c
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/NewFont.c
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni
delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni
[edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe
Posted by Samer El-Haj-Mahmoud 4 years ago
Switch RaspberryPi from using a private GraphicsConsoleDxe to 
the common GraphicsConsoleDxe in MdeModulePkg.

Samer El-Haj-Mahmoud (3):
  Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
  Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
  Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe

 Platform/RaspberryPi/RPi3/RPi3.dsc            |    2 +-
 Platform/RaspberryPi/RPi4/RPi4.dsc            |    2 +-
 Platform/RaspberryPi/RPi3/RPi3.fdf            |    2 +-
 Platform/RaspberryPi/RPi4/RPi4.fdf            |    2 +-
 .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf |   68 -
 .../GraphicsConsoleDxe/GraphicsConsole.h      |  585 ------
 .../GraphicsConsoleDxe/ComponentName.c        |  177 --
 .../GraphicsConsoleDxe/GraphicsConsole.c      | 1831 -----------------
 .../Drivers/GraphicsConsoleDxe/NewFont.c      |  281 ---
 .../GraphicsConsoleDxe/GraphicsConsoleDxe.uni |   12 -
 .../GraphicsConsoleDxeExtra.uni               |   12 -
 11 files changed, 4 insertions(+), 2970 deletions(-)
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.h
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/ComponentName.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/NewFont.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57256): https://edk2.groups.io/g/devel/message/57256
Mute This Topic: https://groups.io/mt/72947316/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe
Posted by Ard Biesheuvel 4 years ago
On 4/11/20 5:56 PM, Samer El-Haj-Mahmoud via groups.io wrote:
> Switch RaspberryPi from using a private GraphicsConsoleDxe to
> the common GraphicsConsoleDxe in MdeModulePkg.
> 
> Samer El-Haj-Mahmoud (3):
>    Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
>    Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
>    Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe
> 

Thanks Samer

The only thing missing from these patches is setting the following 
feature PCD in the DSCs somewhere:

gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE

This is needed because the generic GraphicsConsoleDxe has UGA support as 
well (which Andrei ripped out for the RPi clone, I suppose), and it is 
enabled by default, unless you set the PCD to FALSE to disable it.

Can you incorporate this into patches 1 and 2, and resend? Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57281): https://edk2.groups.io/g/devel/message/57281
Mute This Topic: https://groups.io/mt/72947316/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-