SynQuacer: fix driver model integration of NetSec

[edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

Posted by Ard Biesheuvel 4 years ago

Currently, the way the SynQuacer NetSec driver implements the EFI driver
model is slightly quirky. Two changes are needed to move it closer to the
intent of the driver model, which is the ability to boot using only the
drivers that are required to drive the devices that are needed at boot.
This series does not complete the picture entirely yet for SynQuacer, and
it still relies on the unconditional EfiBootManagerConnectAll() call that
exists in the PlatformBootManagerLib implementation in ArmPkg. This is left
for future work.

Ard Biesheuvel (2):
  Silicon/SynQuacer/PlatformDxe: defer device registration until
    EndOfDxe
  Silicon/SynQuacer/NetsecDxe: move device path to root device

 .../Drivers/Net/NetsecDxe/NetsecDxe.c         | 12 ---
 .../Drivers/Net/NetsecDxe/NetsecDxe.h         |  9 --
 .../Drivers/PlatformDxe/PlatformDxe.c         | 92 +++++++++++++++++--
 .../Drivers/PlatformDxe/PlatformDxe.h         |  1 +
 .../Drivers/PlatformDxe/PlatformDxe.inf       |  3 +
 5 files changed, 86 insertions(+), 31 deletions(-)

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57067): https://edk2.groups.io/g/devel/message/57067
Mute This Topic: https://groups.io/mt/72877587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

Posted by Leif Lindholm 4 years ago

On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote:
> Currently, the way the SynQuacer NetSec driver implements the EFI driver
> model is slightly quirky. Two changes are needed to move it closer to the
> intent of the driver model, which is the ability to boot using only the
> drivers that are required to drive the devices that are needed at boot.
> This series does not complete the picture entirely yet for SynQuacer, and
> it still relies on the unconditional EfiBootManagerConnectAll() call that
> exists in the PlatformBootManagerLib implementation in ArmPkg. This is left
> for future work.
> 
> Ard Biesheuvel (2):
>   Silicon/SynQuacer/PlatformDxe: defer device registration until
>     EndOfDxe
>   Silicon/SynQuacer/NetsecDxe: move device path to root device

LGTM.

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>


>  .../Drivers/Net/NetsecDxe/NetsecDxe.c         | 12 ---
>  .../Drivers/Net/NetsecDxe/NetsecDxe.h         |  9 --
>  .../Drivers/PlatformDxe/PlatformDxe.c         | 92 +++++++++++++++++--
>  .../Drivers/PlatformDxe/PlatformDxe.h         |  1 +
>  .../Drivers/PlatformDxe/PlatformDxe.inf       |  3 +
>  5 files changed, 86 insertions(+), 31 deletions(-)
> 
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57071): https://edk2.groups.io/g/devel/message/57071
Mute This Topic: https://groups.io/mt/72877587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

Posted by Ard Biesheuvel 4 years ago

On 4/8/20 6:26 PM, Leif Lindholm wrote:
> On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote:
>> Currently, the way the SynQuacer NetSec driver implements the EFI driver
>> model is slightly quirky. Two changes are needed to move it closer to the
>> intent of the driver model, which is the ability to boot using only the
>> drivers that are required to drive the devices that are needed at boot.
>> This series does not complete the picture entirely yet for SynQuacer, and
>> it still relies on the unconditional EfiBootManagerConnectAll() call that
>> exists in the PlatformBootManagerLib implementation in ArmPkg. This is left
>> for future work.
>>
>> Ard Biesheuvel (2):
>>    Silicon/SynQuacer/PlatformDxe: defer device registration until
>>      EndOfDxe
>>    Silicon/SynQuacer/NetsecDxe: move device path to root device
> 
> LGTM.
> 
> For the series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> 

Thanks. Series pushed.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57098): https://edk2.groups.io/g/devel/message/57098
Mute This Topic: https://groups.io/mt/72877587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-