CryptoPkg: Retire the deprecate function

[edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

Posted by Gao, Zhichao 5 years, 10 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682

iSCSI driver required the MD5 function. Change the PcdMD5Enable
to TRUE when NETWORK_ISCSI_ENABLE is TURE.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 NetworkPkg/NetworkPcds.dsc.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/NetworkPkg/NetworkPcds.dsc.inc b/NetworkPkg/NetworkPcds.dsc.inc
index f874b382ef..7a81f0cb2d 100644
--- a/NetworkPkg/NetworkPcds.dsc.inc
+++ b/NetworkPkg/NetworkPcds.dsc.inc
@@ -5,7 +5,7 @@
 # by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD settings
 # according to the value of flags described in "NetworkDefines.dsc.inc".
 #
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
 #
 #    SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -14,3 +14,6 @@
 !if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE
   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
 !endif
+!if $(NETWORK_ISCSI_ENABLE) == TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdMD5Enable|TRUE
+!endif
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56446): https://edk2.groups.io/g/devel/message/56446
Mute This Topic: https://groups.io/mt/72579468/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

Posted by Maciej Rabeda 5 years, 10 months ago

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 27-Mar-20 02:56, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
>
> iSCSI driver required the MD5 function. Change the PcdMD5Enable
> to TRUE when NETWORK_ISCSI_ENABLE is TURE.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>   NetworkPkg/NetworkPcds.dsc.inc | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/NetworkPcds.dsc.inc b/NetworkPkg/NetworkPcds.dsc.inc
> index f874b382ef..7a81f0cb2d 100644
> --- a/NetworkPkg/NetworkPcds.dsc.inc
> +++ b/NetworkPkg/NetworkPcds.dsc.inc
> @@ -5,7 +5,7 @@
>   # by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD settings
>   # according to the value of flags described in "NetworkDefines.dsc.inc".
>   #
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
>   #
>   #    SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -14,3 +14,6 @@
>   !if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE
>     gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>   !endif
> +!if $(NETWORK_ISCSI_ENABLE) == TRUE
> +  gEfiCryptoPkgTokenSpaceGuid.PcdMD5Enable|TRUE
> +!endif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56627): https://edk2.groups.io/g/devel/message/56627
Mute This Topic: https://groups.io/mt/72579468/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

Posted by Siyuan, Fu 5 years, 10 months ago

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: 2020年3月27日 9:56
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
> 
> iSCSI driver required the MD5 function. Change the PcdMD5Enable
> to TRUE when NETWORK_ISCSI_ENABLE is TURE.
> 
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  NetworkPkg/NetworkPcds.dsc.inc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/NetworkPcds.dsc.inc
> b/NetworkPkg/NetworkPcds.dsc.inc
> index f874b382ef..7a81f0cb2d 100644
> --- a/NetworkPkg/NetworkPcds.dsc.inc
> +++ b/NetworkPkg/NetworkPcds.dsc.inc
> @@ -5,7 +5,7 @@
>  # by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD settings
>  # according to the value of flags described in "NetworkDefines.dsc.inc".
>  #
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
>  #
>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -14,3 +14,6 @@
>  !if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE
>    gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>  !endif
> +!if $(NETWORK_ISCSI_ENABLE) == TRUE
> +  gEfiCryptoPkgTokenSpaceGuid.PcdMD5Enable|TRUE
> +!endif
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56453): https://edk2.groups.io/g/devel/message/56453
Mute This Topic: https://groups.io/mt/72579468/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-