remove generation of EFI properties table

[edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Ard Biesheuvel 5 years, 10 months ago

The EFI properties table is broken by design, deprecated, and seems to be
causing confusion as it is unclear to some how it differs from the memory
attributes table (which supersedes it). So let's get rid of the code that
generates it entirely, along with the GUID definitions, PCDs etc.

Due to how the two implementations are intertwined, patch #2 makes the
minimal changes required to stop producing the table (and to allow patch
#3 to remove the associated definitions from MdePkg). Patch #4 is optional
and merges the code together.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>

Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633

Ard Biesheuvel (4):
  OvmfPkg: remove handling of properties table
  MdeModulePkg: disable properties table generation but retain the code
  MdePkg: remove PropertiesTable GUID
  MdeModulePkg/DxeCore: merge properties table routines into MAT
    handling

 MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
 MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
 .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
 MdeModulePkg/MdeModulePkg.dec                 |   24 -
 MdeModulePkg/MdeModulePkg.uni                 |   21 -
 MdePkg/Include/Guid/PropertiesTable.h         |   31 -
 MdePkg/MdePkg.dec                             |    3 -
 OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
 OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
 OvmfPkg/OvmfPkgX64.dsc                        |    1 -
 OvmfPkg/OvmfXen.dsc                           |    1 -
 OvmfPkg/PlatformPei/Platform.c                |    1 -
 OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
 16 files changed, 1222 insertions(+), 1476 deletions(-)
 delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
 delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56387): https://edk2.groups.io/g/devel/message/56387
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Dandan Bi 5 years, 10 months ago

For the functionality, it is the same with before for platforms which set PcdPropertiesTableEnable to false by default.
Reviewed-by: Dandan Bi <dandan.bi@intel.com> for patch [PATCH 2/4] [PATCH 3/4] [PATCH 4/4].


If anyone still has the use case of enabling PcdPropertiesTableEnable, please comment.


Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, March 26, 2020 6:25 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> 
> The EFI properties table is broken by design, deprecated, and seems to be
> causing confusion as it is unclear to some how it differs from the memory
> attributes table (which supersedes it). So let's get rid of the code that
> generates it entirely, along with the GUID definitions, PCDs etc.
> 
> Due to how the two implementations are intertwined, patch #2 makes the
> minimal changes required to stop producing the table (and to allow patch
> #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> and merges the code together.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> 
> Ard Biesheuvel (4):
>   OvmfPkg: remove handling of properties table
>   MdeModulePkg: disable properties table generation but retain the code
>   MdePkg: remove PropertiesTable GUID
>   MdeModulePkg/DxeCore: merge properties table routines into MAT
>     handling
> 
>  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
>  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
>  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
>  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
>  MdeModulePkg/MdeModulePkg.dec                 |   24 -
>  MdeModulePkg/MdeModulePkg.uni                 |   21 -
>  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
>  MdePkg/MdePkg.dec                             |    3 -
>  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
>  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
>  OvmfPkg/OvmfXen.dsc                           |    1 -
>  OvmfPkg/PlatformPei/Platform.c                |    1 -
>  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
>  16 files changed, 1222 insertions(+), 1476 deletions(-)  delete mode 100644
> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> 
> --
> 2.17.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56919): https://edk2.groups.io/g/devel/message/56919
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Ard Biesheuvel 5 years, 10 months ago

On Fri, 3 Apr 2020 at 04:22, Bi, Dandan <dandan.bi@intel.com> wrote:
>
> For the functionality, it is the same with before for platforms which set PcdPropertiesTableEnable to false by default.
> Reviewed-by: Dandan Bi <dandan.bi@intel.com> for patch [PATCH 2/4] [PATCH 3/4] [PATCH 4/4].
>
>
> If anyone still has the use case of enabling PcdPropertiesTableEnable, please comment.
>

Thank you Dandan.

Jian, Hao, do you have any comments on this series? If you are too
busy to have a closer look immediately, could you please indicate so
instead of not responding at all? Thanks.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56980): https://edk2.groups.io/g/devel/message/56980
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Wang, Jian J 5 years, 10 months ago

Ard,

My apologies. I was indeed working desperately to catch some deadlines recently.
I agree to remove the properties table.

For the whole series, 

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Monday, April 06, 2020 7:42 PM
> To: Bi, Dandan <dandan.bi@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Wu, Hao A <hao.a.wu@intel.com>
> Cc: devel@edk2.groups.io; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> 
> On Fri, 3 Apr 2020 at 04:22, Bi, Dandan <dandan.bi@intel.com> wrote:
> >
> > For the functionality, it is the same with before for platforms which set
> PcdPropertiesTableEnable to false by default.
> > Reviewed-by: Dandan Bi <dandan.bi@intel.com> for patch [PATCH 2/4]
> [PATCH 3/4] [PATCH 4/4].
> >
> >
> > If anyone still has the use case of enabling PcdPropertiesTableEnable, please
> comment.
> >
> 
> Thank you Dandan.
> 
> Jian, Hao, do you have any comments on this series? If you are too
> busy to have a closer look immediately, could you please indicate so
> instead of not responding at all? Thanks.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57014): https://edk2.groups.io/g/devel/message/57014
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Ard Biesheuvel 5 years, 10 months ago

On 4/7/20 9:27 AM, Wang, Jian J via groups.io wrote:
> Ard,
> 
> My apologies. I was indeed working desperately to catch some deadlines recently.
> I agree to remove the properties table.
> 
> For the whole series,
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> 

Thanks all.

Merged into edk2/master.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57018): https://edk2.groups.io/g/devel/message/57018
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Yao, Jiewen 5 years, 10 months ago

Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

I cannot remember if there is windows OS still using the properties table.
Maybe Microsoft people can comment.

If no, I agree we can remove the old code.



> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Thursday, March 26, 2020 6:25 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [PATCH 0/4] remove generation of EFI properties table
> 
> The EFI properties table is broken by design, deprecated, and seems to be
> causing confusion as it is unclear to some how it differs from the memory
> attributes table (which supersedes it). So let's get rid of the code that
> generates it entirely, along with the GUID definitions, PCDs etc.
> 
> Due to how the two implementations are intertwined, patch #2 makes the
> minimal changes required to stop producing the table (and to allow patch
> #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> and merges the code together.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> 
> Ard Biesheuvel (4):
>   OvmfPkg: remove handling of properties table
>   MdeModulePkg: disable properties table generation but retain the code
>   MdePkg: remove PropertiesTable GUID
>   MdeModulePkg/DxeCore: merge properties table routines into MAT
>     handling
> 
>  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
>  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
>  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
>  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
>  MdeModulePkg/MdeModulePkg.dec                 |   24 -
>  MdeModulePkg/MdeModulePkg.uni                 |   21 -
>  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
>  MdePkg/MdePkg.dec                             |    3 -
>  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
>  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
>  OvmfPkg/OvmfXen.dsc                           |    1 -
>  OvmfPkg/PlatformPei/Platform.c                |    1 -
>  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
>  16 files changed, 1222 insertions(+), 1476 deletions(-)
>  delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> 
> --
> 2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56470): https://edk2.groups.io/g/devel/message/56470
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Liming Gao 5 years, 10 months ago

Ack-by: Liming Gao <liming.gao@intel.com> 

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Friday, March 27, 2020 1:01 PM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> 
> Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> I cannot remember if there is windows OS still using the properties table.
> Maybe Microsoft people can comment.
> 
> If no, I agree we can remove the old code.
> 
> 
> 
> > -----Original Message-----
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Sent: Thursday, March 26, 2020 6:25 PM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Subject: [PATCH 0/4] remove generation of EFI properties table
> >
> > The EFI properties table is broken by design, deprecated, and seems to be
> > causing confusion as it is unclear to some how it differs from the memory
> > attributes table (which supersedes it). So let's get rid of the code that
> > generates it entirely, along with the GUID definitions, PCDs etc.
> >
> > Due to how the two implementations are intertwined, patch #2 makes the
> > minimal changes required to stop producing the table (and to allow patch
> > #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> > and merges the code together.
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> >
> > Ard Biesheuvel (4):
> >   OvmfPkg: remove handling of properties table
> >   MdeModulePkg: disable properties table generation but retain the code
> >   MdePkg: remove PropertiesTable GUID
> >   MdeModulePkg/DxeCore: merge properties table routines into MAT
> >     handling
> >
> >  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
> >  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
> >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
> >  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
> >  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
> >  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
> >  MdeModulePkg/MdeModulePkg.dec                 |   24 -
> >  MdeModulePkg/MdeModulePkg.uni                 |   21 -
> >  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
> >  MdePkg/MdePkg.dec                             |    3 -
> >  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
> >  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
> >  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
> >  OvmfPkg/OvmfXen.dsc                           |    1 -
> >  OvmfPkg/PlatformPei/Platform.c                |    1 -
> >  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
> >  16 files changed, 1222 insertions(+), 1476 deletions(-)
> >  delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
> >  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> >
> > --
> > 2.17.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56635): https://edk2.groups.io/g/devel/message/56635
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Ard Biesheuvel 5 years, 10 months ago

(adding Jian and Hao)

Thanks for the acks, and apologies for failing to cc the MdeModulePkg
maintainers.

Jian, Hao, do you have any opinion on this series?




On Mon, 30 Mar 2020 at 15:42, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ack-by: Liming Gao <liming.gao@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> > Sent: Friday, March 27, 2020 1:01 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; devel@edk2.groups.io
> > Cc: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> >
> > Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
> > I cannot remember if there is windows OS still using the properties table.
> > Maybe Microsoft people can comment.
> >
> > If no, I agree we can remove the old code.
> >
> >
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Sent: Thursday, March 26, 2020 6:25 PM
> > > To: devel@edk2.groups.io
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Subject: [PATCH 0/4] remove generation of EFI properties table
> > >
> > > The EFI properties table is broken by design, deprecated, and seems to be
> > > causing confusion as it is unclear to some how it differs from the memory
> > > attributes table (which supersedes it). So let's get rid of the code that
> > > generates it entirely, along with the GUID definitions, PCDs etc.
> > >
> > > Due to how the two implementations are intertwined, patch #2 makes the
> > > minimal changes required to stop producing the table (and to allow patch
> > > #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> > > and merges the code together.
> > >
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >
> > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> > >
> > > Ard Biesheuvel (4):
> > >   OvmfPkg: remove handling of properties table
> > >   MdeModulePkg: disable properties table generation but retain the code
> > >   MdePkg: remove PropertiesTable GUID
> > >   MdeModulePkg/DxeCore: merge properties table routines into MAT
> > >     handling
> > >
> > >  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
> > >  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
> > >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
> > >  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
> > >  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
> > >  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
> > >  MdeModulePkg/MdeModulePkg.dec                 |   24 -
> > >  MdeModulePkg/MdeModulePkg.uni                 |   21 -
> > >  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
> > >  MdePkg/MdePkg.dec                             |    3 -
> > >  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
> > >  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
> > >  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
> > >  OvmfPkg/OvmfXen.dsc                           |    1 -
> > >  OvmfPkg/PlatformPei/Platform.c                |    1 -
> > >  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
> > >  16 files changed, 1222 insertions(+), 1476 deletions(-)
> > >  delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
> > >  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> > >
> > > --
> > > 2.17.1
> >
> >
> > 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56678): https://edk2.groups.io/g/devel/message/56678
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Posted by Ard Biesheuvel 5 years, 10 months ago

On Mon, 30 Mar 2020 at 19:57, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> (adding Jian and Hao)
>
> Thanks for the acks, and apologies for failing to cc the MdeModulePkg
> maintainers.
>
> Jian, Hao, do you have any opinion on this series?
>

Jian, Hao, Liming, Michael,

It is not always clear to me how you at Intel divide up the maintainer
duties between yourselves.

Liming and Jiewen have acked this entire series, but they are not the
MdeModulePkg maintainers, so I assume either Jian or Hao should
approve it as well before i can proceed with it.

If this is the case, could Jian and Hao please acknowledge that they
read this email, and perhaps indicate a timeframe within which they
will be able to give their verdict on these changes?

Thanks,
Ard.





>
>
> On Mon, 30 Mar 2020 at 15:42, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > Ack-by: Liming Gao <liming.gao@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> > > Sent: Friday, March 27, 2020 1:01 PM
> > > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; devel@edk2.groups.io
> > > Cc: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> > > <ray.ni@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> > >
> > > Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> > >
> > > I cannot remember if there is windows OS still using the properties table.
> > > Maybe Microsoft people can comment.
> > >
> > > If no, I agree we can remove the old code.
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > Sent: Thursday, March 26, 2020 6:25 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> > > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> > > > <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > Subject: [PATCH 0/4] remove generation of EFI properties table
> > > >
> > > > The EFI properties table is broken by design, deprecated, and seems to be
> > > > causing confusion as it is unclear to some how it differs from the memory
> > > > attributes table (which supersedes it). So let's get rid of the code that
> > > > generates it entirely, along with the GUID definitions, PCDs etc.
> > > >
> > > > Due to how the two implementations are intertwined, patch #2 makes the
> > > > minimal changes required to stop producing the table (and to allow patch
> > > > #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> > > > and merges the code together.
> > > >
> > > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > >
> > > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> > > >
> > > > Ard Biesheuvel (4):
> > > >   OvmfPkg: remove handling of properties table
> > > >   MdeModulePkg: disable properties table generation but retain the code
> > > >   MdePkg: remove PropertiesTable GUID
> > > >   MdeModulePkg/DxeCore: merge properties table routines into MAT
> > > >     handling
> > > >
> > > >  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
> > > >  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
> > > >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
> > > >  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
> > > >  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
> > > >  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
> > > >  MdeModulePkg/MdeModulePkg.dec                 |   24 -
> > > >  MdeModulePkg/MdeModulePkg.uni                 |   21 -
> > > >  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
> > > >  MdePkg/MdePkg.dec                             |    3 -
> > > >  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
> > > >  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
> > > >  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
> > > >  OvmfPkg/OvmfXen.dsc                           |    1 -
> > > >  OvmfPkg/PlatformPei/Platform.c                |    1 -
> > > >  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
> > > >  16 files changed, 1222 insertions(+), 1476 deletions(-)
> > > >  delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
> > > >  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> > > >
> > > > --
> > > > 2.17.1
> > >
> > >
> > > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56861): https://edk2.groups.io/g/devel/message/56861
Mute This Topic: https://groups.io/mt/72560881/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-