[v5] Add RpmcLib and VariableKeyLib

[edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Posted by Wang, Jian J 4 years, 1 month ago

> v5: change VariableRootKey to VariableKey
> v4: remove CounterId which should not be exposed
> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> v2: change CounterIndex to CounterId in RpmcLib prototype.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v5

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>

Jian J Wang (3):
  SecurityPkg: add RpmcLib and VariableKeyLib public headers
  SecurityPkg: add null version of RpmcLib
  SecurityPkg: add null version of VariableKeyLib

 SecurityPkg/Include/Library/RpmcLib.h         | 42 ++++++++++++
 SecurityPkg/Include/Library/VariableKeyLib.h  | 59 ++++++++++++++++
 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
 .../Library/RpmcLibNull/RpmcLibNull.inf       | 33 +++++++++
 .../VariableKeyLibNull/VariableKeyLibNull.c   | 67 +++++++++++++++++++
 .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
 SecurityPkg/SecurityPkg.dec                   |  8 +++
 SecurityPkg/SecurityPkg.dsc                   |  8 +++
 8 files changed, 297 insertions(+)
 create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
 create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
 create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
 create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
 create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
 create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf

-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56371): https://edk2.groups.io/g/devel/message/56371
Mute This Topic: https://groups.io/mt/72559442/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Posted by Michael Kubacki 4 years, 1 month ago

For the series:

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 3/26/2020 12:49 AM, Wang, Jian J wrote:
>> v5: change VariableRootKey to VariableKey
> 
>> v4: remove CounterId which should not be exposed
> 
>> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> 
>> v2: change CounterIndex to CounterId in RpmcLib prototype.
> 
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> 
> Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v5
> 
> 
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> 
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> 
> Jian J Wang (3):
>    SecurityPkg: add RpmcLib and VariableKeyLib public headers
>    SecurityPkg: add null version of RpmcLib
>    SecurityPkg: add null version of VariableKeyLib
> 
>   SecurityPkg/Include/Library/RpmcLib.h         | 42 ++++++++++++
>   SecurityPkg/Include/Library/VariableKeyLib.h  | 59 ++++++++++++++++
>   SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
>   .../Library/RpmcLibNull/RpmcLibNull.inf       | 33 +++++++++
>   .../VariableKeyLibNull/VariableKeyLibNull.c   | 67 +++++++++++++++++++
>   .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
>   SecurityPkg/SecurityPkg.dec                   |  8 +++
>   SecurityPkg/SecurityPkg.dsc                   |  8 +++
>   8 files changed, 297 insertions(+)
>   create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
>   create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
>   create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
>   create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
>   create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
>   create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56415): https://edk2.groups.io/g/devel/message/56415
Mute This Topic: https://groups.io/mt/72559442/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Posted by Wang, Jian J 4 years, 1 month ago

Michael,

Good to see you "back"😊 and thanks for the review.

Regards,
Jian

> -----Original Message-----
> From: Michael Kubacki <michael.kubacki@outlook.com>
> Sent: Friday, March 27, 2020 1:25 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
> 
> For the series:
> 
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> On 3/26/2020 12:49 AM, Wang, Jian J wrote:
> >> v5: change VariableRootKey to VariableKey
> >
> >> v4: remove CounterId which should not be exposed
> >
> >> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> >
> >> v2: change CounterIndex to CounterId in RpmcLib prototype.
> >
> >
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> >
> > Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-
> interfaces-between-platform-and-edk2-v5
> >
> >
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> >
> > Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> >
> > Jian J Wang (3):
> >    SecurityPkg: add RpmcLib and VariableKeyLib public headers
> >    SecurityPkg: add null version of RpmcLib
> >    SecurityPkg: add null version of VariableKeyLib
> >
> >   SecurityPkg/Include/Library/RpmcLib.h         | 42 ++++++++++++
> >   SecurityPkg/Include/Library/VariableKeyLib.h  | 59 ++++++++++++++++
> >   SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
> >   .../Library/RpmcLibNull/RpmcLibNull.inf       | 33 +++++++++
> >   .../VariableKeyLibNull/VariableKeyLibNull.c   | 67 +++++++++++++++++++
> >   .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
> >   SecurityPkg/SecurityPkg.dec                   |  8 +++
> >   SecurityPkg/SecurityPkg.dsc                   |  8 +++
> >   8 files changed, 297 insertions(+)
> >   create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
> >   create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
> >   create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> >   create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
> >   create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> >   create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56437): https://edk2.groups.io/g/devel/message/56437
Mute This Topic: https://groups.io/mt/72559442/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Posted by Yao, Jiewen 4 years, 1 month ago

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Wang, Jian J <jian.j.wang@intel.com>
> Sent: Thursday, March 26, 2020 3:50 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
> 
> > v5: change VariableRootKey to VariableKey
> 
> > v4: remove CounterId which should not be exposed
> 
> > v3: update retval description in RpmcLib.h and RpmcLibNull.c
> 
> > v2: change CounterIndex to CounterId in RpmcLib prototype.
> 
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> 
> Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-
> interfaces-between-platform-and-edk2-v5
> 
> 
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> 
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> 
> Jian J Wang (3):
>   SecurityPkg: add RpmcLib and VariableKeyLib public headers
>   SecurityPkg: add null version of RpmcLib
>   SecurityPkg: add null version of VariableKeyLib
> 
>  SecurityPkg/Include/Library/RpmcLib.h         | 42 ++++++++++++
>  SecurityPkg/Include/Library/VariableKeyLib.h  | 59 ++++++++++++++++
>  SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
>  .../Library/RpmcLibNull/RpmcLibNull.inf       | 33 +++++++++
>  .../VariableKeyLibNull/VariableKeyLibNull.c   | 67 +++++++++++++++++++
>  .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
>  SecurityPkg/SecurityPkg.dec                   |  8 +++
>  SecurityPkg/SecurityPkg.dsc                   |  8 +++
>  8 files changed, 297 insertions(+)
>  create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
>  create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
>  create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
>  create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
>  create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
>  create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
> 
> --
> 2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56438): https://edk2.groups.io/g/devel/message/56438
Mute This Topic: https://groups.io/mt/72559442/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-