From: Pankaj Bansal <pankaj.bansal@nxp.com>
Implement SerialUartClockLib for all NXP Layerscape Platforms.
Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---
.../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++
.../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++
2 files changed, 53 insertions(+)
create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
new file mode 100644
index 000000000000..9d49d7b4748b
--- /dev/null
+++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
@@ -0,0 +1,27 @@
+/** @file
+*
+* Copyright 2020 NXP
+*
+* SPDX-License-Identifier: BSD-2-Clause-Patent
+*
+**/
+
+#include <Base.h>
+
+extern
+UINT64
+GetBusFrequency (
+ VOID
+ );
+
+/**
+ Return clock in for Uart IP
+**/
+UINT32
+EFIAPI
+BaseSerialPortGetClock (
+ VOID
+ )
+{
+ return GetBusFrequency ();
+}
diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
new file mode 100644
index 000000000000..9a3e80cf521d
--- /dev/null
+++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
@@ -0,0 +1,26 @@
+# @file
+# Copyright 2020 NXP
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#
+
+[Defines]
+ INF_VERSION = 1.27
+ BASE_NAME = SerialUartClockLib
+ FILE_GUID = fa65495e-d3c8-4ea3-9737-994e9ccbaf11
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = SerialUartClockLib
+
+[Packages]
+ MdeModulePkg/MdeModulePkg.dec
+ MdePkg/MdePkg.dec
+ Silicon/NXP/NxpQoriqLs.dec
+
+[Sources.common]
+ SerialUartClockLib.c
+
+[LibraryClasses]
+ SocLib
+
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56004): https://edk2.groups.io/g/devel/message/56004
Mute This Topic: https://groups.io/mt/72077432/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal@nxp.com>
>
> Implement SerialUartClockLib for all NXP Layerscape Platforms.
>
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> ---
> .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++
> .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++
I requested after the initial submission that you "either follow the
manual git setup steps from
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers
or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore
repositories"
Now, neither appears to have happened, as .c still comes before .inf
and paths are still truncated.
But in addition to that, we realised that git happily ignores settings
for --stat. So, please, execute aforementioned script, but then
generate v3 with --stat=1000 --stat-graph-width=20.
For this particular patch, the side discussion on the edk2 portion may
make it redundant, so I'm deferring review.
/
Leif
> 2 files changed, 53 insertions(+)
> create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
>
> diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> new file mode 100644
> index 000000000000..9d49d7b4748b
> --- /dev/null
> +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> @@ -0,0 +1,27 @@
> +/** @file
> +*
> +* Copyright 2020 NXP
> +*
> +* SPDX-License-Identifier: BSD-2-Clause-Patent
> +*
> +**/
> +
> +#include <Base.h>
> +
> +extern
> +UINT64
> +GetBusFrequency (
> + VOID
> + );
> +
> +/**
> + Return clock in for Uart IP
> +**/
> +UINT32
> +EFIAPI
> +BaseSerialPortGetClock (
> + VOID
> + )
> +{
> + return GetBusFrequency ();
> +}
> diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> new file mode 100644
> index 000000000000..9a3e80cf521d
> --- /dev/null
> +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> @@ -0,0 +1,26 @@
> +# @file
> +# Copyright 2020 NXP
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +#
> +
> +[Defines]
> + INF_VERSION = 1.27
> + BASE_NAME = SerialUartClockLib
> + FILE_GUID = fa65495e-d3c8-4ea3-9737-994e9ccbaf11
> + MODULE_TYPE = BASE
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = SerialUartClockLib
> +
> +[Packages]
> + MdeModulePkg/MdeModulePkg.dec
> + MdePkg/MdePkg.dec
> + Silicon/NXP/NxpQoriqLs.dec
> +
> +[Sources.common]
> + SerialUartClockLib.c
> +
> +[LibraryClasses]
> + SocLib
> +
> --
> 2.17.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56830): https://edk2.groups.io/g/devel/message/56830
Mute This Topic: https://groups.io/mt/72077432/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Wednesday, April 1, 2020 3:23 PM
> To: Pankaj Bansal (OSS) <pankaj.bansal@oss.nxp.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; devel@edk2.groups.io; Varun Sethi
> <V.Sethi@nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Jon Nettleton <jon@solid-run.com>
> Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib
>
> On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote:
> > From: Pankaj Bansal <pankaj.bansal@nxp.com>
> >
> > Implement SerialUartClockLib for all NXP Layerscape Platforms.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> > ---
> > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++
> > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++
>
> I requested after the initial submission that you "either follow the
> manual git setup steps from
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-
> git-guide-for-edk2-contributors-and-maintainers
> or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore
> repositories"
>
> Now, neither appears to have happened, as .c still comes before .inf
> and paths are still truncated.
I had executed the SetupGit.py script, I will check again.
>
> But in addition to that, we realised that git happily ignores settings
> for --stat. So, please, execute aforementioned script, but then
> generate v3 with --stat=1000 --stat-graph-width=20.
>
Ok. I will follow these steps as well.
> For this particular patch, the side discussion on the edk2 portion may
> make it redundant, so I'm deferring review.
Right now, I am yet to work on the review comments of other edk2 patch
and since it touches other platforms as well, it requires thorough vetting from other
platform maintainers. It seems like that would take more time. If I send this patch
series without removing DuartLib (i.e. drop patches 7, 8, 9 from this series), can you
please merge. Parallelly, I will work on edk2 patch and once that is accepted, I will send
patches 7, 8, 9 after that in new series ?
>
> /
> Leif
>
> > 2 files changed, 53 insertions(+)
> > create mode 100644
> Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> > create mode 100644
> Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> >
> > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> > new file mode 100644
> > index 000000000000..9d49d7b4748b
> > --- /dev/null
> > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> > @@ -0,0 +1,27 @@
> > +/** @file
> > +*
> > +* Copyright 2020 NXP
> > +*
> > +* SPDX-License-Identifier: BSD-2-Clause-Patent
> > +*
> > +**/
> > +
> > +#include <Base.h>
> > +
> > +extern
> > +UINT64
> > +GetBusFrequency (
> > + VOID
> > + );
> > +
> > +/**
> > + Return clock in for Uart IP
> > +**/
> > +UINT32
> > +EFIAPI
> > +BaseSerialPortGetClock (
> > + VOID
> > + )
> > +{
> > + return GetBusFrequency ();
> > +}
> > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> > new file mode 100644
> > index 000000000000..9a3e80cf521d
> > --- /dev/null
> > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> > @@ -0,0 +1,26 @@
> > +# @file
> > +# Copyright 2020 NXP
> > +#
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +#
> > +
> > +[Defines]
> > + INF_VERSION = 1.27
> > + BASE_NAME = SerialUartClockLib
> > + FILE_GUID = fa65495e-d3c8-4ea3-9737-994e9ccbaf11
> > + MODULE_TYPE = BASE
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = SerialUartClockLib
> > +
> > +[Packages]
> > + MdeModulePkg/MdeModulePkg.dec
> > + MdePkg/MdePkg.dec
> > + Silicon/NXP/NxpQoriqLs.dec
> > +
> > +[Sources.common]
> > + SerialUartClockLib.c
> > +
> > +[LibraryClasses]
> > + SocLib
> > +
> > --
> > 2.17.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56971): https://edk2.groups.io/g/devel/message/56971
Mute This Topic: https://groups.io/mt/72077432/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On Mon, Apr 06, 2020 at 06:33:40 +0000, Pankaj Bansal (OSS) wrote:
>
>
> > -----Original Message-----
> > From: Leif Lindholm <leif@nuviainc.com>
> > Sent: Wednesday, April 1, 2020 3:23 PM
> > To: Pankaj Bansal (OSS) <pankaj.bansal@oss.nxp.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; devel@edk2.groups.io; Varun Sethi
> > <V.Sethi@nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud@arm.com>; Jon Nettleton <jon@solid-run.com>
> > Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib
> >
> > On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote:
> > > From: Pankaj Bansal <pankaj.bansal@nxp.com>
> > >
> > > Implement SerialUartClockLib for all NXP Layerscape Platforms.
> > >
> > > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> > > ---
> > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++
> > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++
> >
> > I requested after the initial submission that you "either follow the
> > manual git setup steps from
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-
> > git-guide-for-edk2-contributors-and-maintainers
> > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore
> > repositories"
> >
> > Now, neither appears to have happened, as .c still comes before .inf
> > and paths are still truncated.
>
> I had executed the SetupGit.py script, I will check again.
>
> >
> > But in addition to that, we realised that git happily ignores settings
> > for --stat. So, please, execute aforementioned script, but then
> > generate v3 with --stat=1000 --stat-graph-width=20.
> >
>
> Ok. I will follow these steps as well.
>
> > For this particular patch, the side discussion on the edk2 portion may
> > make it redundant, so I'm deferring review.
>
> Right now, I am yet to work on the review comments of other edk2 patch
> and since it touches other platforms as well, it requires thorough vetting from other
> platform maintainers. It seems like that would take more time. If I send this patch
> series without removing DuartLib (i.e. drop patches 7, 8, 9 from this series), can you
> please merge. Parallelly, I will work on edk2 patch and once that is accepted, I will send
> patches 7, 8, 9 after that in new series ?
See comment in my previous email on merging code only to remove it
shortly afterwards.
As you have seen on that thread, a couple of proposals have been made
for how to fix this without affecting other platforms (the HOB variant[1]
and the separate .inf[2] variant). I will keep chasing on that
occasionally, but please also contribute to that conversation yourself.
/
Leif
[1] https://edk2.groups.io/g/devel/message/56605
[2] https://edk2.groups.io/g/devel/message/56767
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56979): https://edk2.groups.io/g/devel/message/56979
Mute This Topic: https://groups.io/mt/72077432/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hi Leif, Please find my comments inline. Regards Varun -----Original Message----- From: Leif Lindholm <leif@nuviainc.com> Sent: Monday, April 6, 2020 4:55 PM To: Pankaj Bansal (OSS) <pankaj.bansal@oss.nxp.com> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io; Varun Sethi <V.Sethi@nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Jon Nettleton <jon@solid-run.com> Subject: [EXT] Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Caution: EXT Email On Mon, Apr 06, 2020 at 06:33:40 +0000, Pankaj Bansal (OSS) wrote: > > > > -----Original Message----- > > From: Leif Lindholm <leif@nuviainc.com> > > Sent: Wednesday, April 1, 2020 3:23 PM > > To: Pankaj Bansal (OSS) <pankaj.bansal@oss.nxp.com> > > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Michael D > > Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io; Varun > > Sethi <V.Sethi@nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj- > > Mahmoud@arm.com>; Jon Nettleton <jon@solid-run.com> > > Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement > > SerialUartClockLib > > > > On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > > > From: Pankaj Bansal <pankaj.bansal@nxp.com> > > > > > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > > > > > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com> > > > --- > > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 > > > ++++++++++++++++++ > > > > I requested after the initial submission that you "either follow the > > manual git setup steps from > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi > > thub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%2527s-unk > > empt-&data=02%7C01%7CV.Sethi%40nxp.com%7C147ef25a5d6e4a0c899408d > > 7da1d2288%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6372176909755 > > 41422&sdata=6A%2Bg1jAmhpu9p%2FISIddejL0dhzQs%2FS%2BqbYCXtgPAUfk% > > 3D&reserved=0 git-guide-for-edk2-contributors-and-maintainers > > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the > > tianocore repositories" > > > > Now, neither appears to have happened, as .c still comes before .inf > > and paths are still truncated. > > I had executed the SetupGit.py script, I will check again. > > > > > But in addition to that, we realised that git happily ignores > > settings for --stat. So, please, execute aforementioned script, but > > then generate v3 with --stat=1000 --stat-graph-width=20. > > > > Ok. I will follow these steps as well. > > > For this particular patch, the side discussion on the edk2 portion > > may make it redundant, so I'm deferring review. > > Right now, I am yet to work on the review comments of other edk2 patch > and since it touches other platforms as well, it requires thorough > vetting from other platform maintainers. It seems like that would take > more time. If I send this patch series without removing DuartLib (i.e. > drop patches 7, 8, 9 from this series), can you please merge. > Parallelly, I will work on edk2 patch and once that is accepted, I will send patches 7, 8, 9 after that in new series ? >See comment in my previous email on merging code only to remove it shortly afterwards. We will certainly take of this going forward. >As you have seen on that thread, a couple of proposals have been made for how to fix this without affecting other platforms (the HOB variant[1] and the separate .inf[2] variant). I will keep chasing on that >occasionally, but please also contribute to that conversation yourself. Pankaj would be responding to this thread and make changes accordingly. Please allow us to pursue this patchset as a separate thread. We need the base patches to be merged asap so that we can submit patches for LX2160A and LS1046A. We have urgent releases planned for these platforms. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57110): https://edk2.groups.io/g/devel/message/57110 Mute This Topic: https://groups.io/mt/72892622/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, Apr 09, 2020 at 07:44:48 +0000, Varun Sethi wrote:
> > > Now, neither appears to have happened, as .c still comes before .inf
> > > and paths are still truncated.
> >
> > I had executed the SetupGit.py script, I will check again.
> >
> > > But in addition to that, we realised that git happily ignores
> > > settings for --stat. So, please, execute aforementioned script, but
> > > then generate v3 with --stat=1000 --stat-graph-width=20.
> >
> > Ok. I will follow these steps as well.
> >
> > > For this particular patch, the side discussion on the edk2 portion
> > > may make it redundant, so I'm deferring review.
> >
> > Right now, I am yet to work on the review comments of other edk2 patch
> > and since it touches other platforms as well, it requires thorough
> > vetting from other platform maintainers. It seems like that would take
> > more time. If I send this patch series without removing DuartLib (i.e.
> > drop patches 7, 8, 9 from this series), can you please merge.
> > Parallelly, I will work on edk2 patch and once that is accepted, I
> > will send patches 7, 8, 9 after that in new series ?
>
> >See comment in my previous email on merging code only to remove it
> >shortly afterwards.
>
> We will certainly take of this going forward.
>
> >As you have seen on that thread, a couple of proposals have been
> >made for how to fix this without affecting other platforms (the HOB
> >variant[1] and the separate .inf[2] variant). I will keep chasing
> >on that >occasionally, but please also contribute to that
> >conversation yourself.
>
> Pankaj would be responding to this thread and make changes
> accordingly. Please allow us to pursue this patchset as a separate
> thread. We need the base patches to be merged asap so that we can
> submit patches for LX2160A and LS1046A. We have urgent releases
> planned for these platforms.
I (intimately) understand the situation you're in, but we cannot
compromise normal development process of the upstream project due to
project plans of individual contributors.
My suggestion is that if this is holding your release back, then drop
the console changes completely from this set and do your release based
on upstream plus specifically those patches cherry-picked on top.
I would not (for example) mind those patches being sent out to the
list with a --subject-prefix of "DO NOT MERGE edk2-platforms" instead
of "PATCH edk2-platforms". While staying close to upstream is both
laudable and more efficient, productising based *only* on upstream is
... shall we say extremely optimistic.
If you prepare to do the cherry-pick solution, then you can very
quickly revert that and use upstream only if the full solution gets
there in time.
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57117): https://edk2.groups.io/g/devel/message/57117
Mute This Topic: https://groups.io/mt/72893634/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
> > --- > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ > > I requested after the initial submission that you "either follow the > manual git setup steps from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt- > git-guide-for-edk2-contributors-and-maintainers > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore > repositories" > > Now, neither appears to have happened, as .c still comes before .inf > and paths are still truncated. > > But in addition to that, we realised that git happily ignores settings > for --stat. So, please, execute aforementioned script, but then > generate v3 with --stat=1000 --stat-graph-width=20. > I am preparing the v3 of patches, and I am still seeing this issue after running SetupGit.py again. After some tinkering I figured out the problem. The git diff is ignoring the diff.Orderfile The reason is line ending of edk2/BaseTools/Conf/diff.order The current line ending of diff.order is windows, while I am using Linux to prepare patches. If I change it to unix (dos2unix), then git is able to show proper diff I wonder if same problem is with edk2/BaseTools/Conf/gitattributes ? Looks like SetupGit.py needs to be modified to take into account the git running environment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57274): https://edk2.groups.io/g/devel/message/57274 Mute This Topic: https://groups.io/mt/72077432/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2026 Red Hat, Inc.