[edk2-devel] [PATCH] .pytool: Add two keys in cspell.base.yaml

Zhang, Shenglei posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
.pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
1 file changed, 2 insertions(+)

[edk2-devel] [PATCH] .pytool: Add two keys in cspell.base.yaml

Posted by Zhang, Shenglei 2 weeks ago
In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
 several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2593

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 53000fc38141..7620dff3ceb2 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,6 +21,8 @@
         "*.jpg"
     ],
     "minWordLength": 5,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "allowCompoundWords": false,
     "ignoreWords": [
         "muchange"
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55988): https://edk2.groups.io/g/devel/message/55988
Mute This Topic: https://groups.io/mt/72070613/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml

Posted by Bret Barkelew via Groups.Io 2 weeks ago
Reviewed-by: Bret Barkelew <Bret.barkelew@microsoft.com>

- Bret
________________________________
From: Shenglei Zhang <shenglei.zhang@intel.com>
Sent: Thursday, March 19, 2020 2:37:54 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <liming.gao@intel.com>
Subject: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml

In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
 several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2593&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7Cfc576b01311c475fe39008d7cbe93a55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637202074886021018&amp;sdata=jWldOGRLBGli6KGd0D86FvWXRxHJek6nIyXTXytxgF4%3D&amp;reserved=0

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 53000fc38141..7620dff3ceb2 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,6 +21,8 @@
         "*.jpg"
     ],
     "minWordLength": 5,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "allowCompoundWords": false,
     "ignoreWords": [
         "muchange"
--
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55993): https://edk2.groups.io/g/devel/message/55993
Mute This Topic: https://groups.io/mt/72076715/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-