[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Nate DeSimone posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
edkrepo/common/common_repo_functions.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Posted by Nate DeSimone 2 weeks ago
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/common/common_repo_functions.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
 import unicodedata
 import urllib.request
 import subprocess
+import traceback
 
 import git
 from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
         if combination_is_in_manifest(combo_or_sha, manifest):
             manifest.write_current_combo(combo_or_sha)
     except:
-        print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+        if verbose:
+            traceback.print_exc()
+        print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
         # Return to the initial combo, since there was an issue with cheking out the selected combo
         checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
     finally:
-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55960): https://edk2.groups.io/g/devel/message/55960
Mute This Topic: https://groups.io/mt/72057834/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Posted by Desimone, Ashley E 2 weeks ago
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Wednesday, March 18, 2020 12:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/common/common_repo_functions.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
 import unicodedata
 import urllib.request
 import subprocess
+import traceback
 
 import git
 from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
         if combination_is_in_manifest(combo_or_sha, manifest):
             manifest.write_current_combo(combo_or_sha)
     except:
-        print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+        if verbose:
+            traceback.print_exc()
+        print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
         # Return to the initial combo, since there was an issue with cheking out the selected combo
         checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
     finally:
-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55962): https://edk2.groups.io/g/devel/message/55962
Mute This Topic: https://groups.io/mt/72057834/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Posted by Bjorge, Erik C 2 weeks ago
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Wednesday, March 18, 2020 12:43 PM
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; devel@edk2.groups.io
Cc: Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: RE: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Wednesday, March 18, 2020 12:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/common/common_repo_functions.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
 import unicodedata
 import urllib.request
 import subprocess
+import traceback
 
 import git
 from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
         if combination_is_in_manifest(combo_or_sha, manifest):
             manifest.write_current_combo(combo_or_sha)
     except:
-        print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+        if verbose:
+            traceback.print_exc()
+        print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
         # Return to the initial combo, since there was an issue with cheking out the selected combo
         checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
     finally:
-- 
2.24.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55968): https://edk2.groups.io/g/devel/message/55968
Mute This Topic: https://groups.io/mt/72057834/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-