[v1] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[edk2-devel] [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

Posted by TinaX Y Chen 4 years, 1 month ago

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318

Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.

Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
cc: Ray Ni <ray.ni@intel.com>
cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
cc: Chasel Chiu <chasel.chiu@intel.com>
cc: Ethan Tsao <ethan.tsao@intel.com>
---
 Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
index 37c77d8f..2f25bdb3 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Component description file for the Coffee Lake silicon package DSC file.
 #
-# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved. <BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -147,7 +147,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
 # Silicon Init Common Library
 #
 !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
-ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf
+ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf
 PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/BasePchTraceHubInitLib.inf
 
 [LibraryClasses.IA32]
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55869): https://edk2.groups.io/g/devel/message/55869
Mute This Topic: https://groups.io/mt/72001271/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

Posted by Chiu, Chasel 4 years, 1 month ago

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chen, TinaX Y <tinax.y.chen@intel.com>
> Sent: Monday, March 16, 2020 10:41 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Tsao, Ethan <ethan.tsao@intel.com>
> Subject: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> 
> Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.
> 
> Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
> Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
> cc: Ray Ni <ray.ni@intel.com>
> cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> cc: Chasel Chiu <chasel.chiu@intel.com>
> cc: Ethan Tsao <ethan.tsao@intel.com>
> ---
>  Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> index 37c77d8f..2f25bdb3 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Component description file for the Coffee Lake silicon package DSC file.
>  #
> -# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> +<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -147,7 +147,7 @@
> gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
>  # Silicon Init Common Library
>  #
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
> -ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBl
> -ConfigBlockLib|ockLib.inf
> +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo
> +ConfigBlockLib|ckLib.inf
> 
> PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/BasePch
> TraceHubInitLib.inf
> 
>  [LibraryClasses.IA32]
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55905): https://edk2.groups.io/g/devel/message/55905
Mute This Topic: https://groups.io/mt/72001271/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

Posted by Chiu, Chasel 4 years, 1 month ago

Sorry Tina, the commit message and code review subject format were wrong, please refer to other edk2-platform patches and re-send again.

Thanks,
Chasel


> -----Original Message-----
> From: Chiu, Chasel
> Sent: Tuesday, March 17, 2020 8:08 AM
> To: Chen, TinaX Y <tinax.y.chen@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Tsao, Ethan <ethan.tsao@intel.com>
> Subject: RE: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> > -----Original Message-----
> > From: Chen, TinaX Y <tinax.y.chen@intel.com>
> > Sent: Monday, March 16, 2020 10:41 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> > Tsao, Ethan <ethan.tsao@intel.com>
> > Subject: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> >
> > Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.
> >
> > Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
> > Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
> > cc: Ray Ni <ray.ni@intel.com>
> > cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > cc: Chasel Chiu <chasel.chiu@intel.com>
> > cc: Ethan Tsao <ethan.tsao@intel.com>
> > ---
> >  Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > index 37c77d8f..2f25bdb3 100644
> > --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > @@ -1,7 +1,7 @@
> >  ## @file
> >  #  Component description file for the Coffee Lake silicon package DSC
> file.
> >  #
> > -# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> > +<BR>
> >  #
> >  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -147,7 +147,7 @@
> > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
> >  # Silicon Init Common Library
> >  #
> >  !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
> > -ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfig
> > -ConfigBlockLib|Bl
> > -ConfigBlockLib|ockLib.inf
> > +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > +ConfigBlockLib|lo
> > +ConfigBlockLib|ckLib.inf
> >
> > PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/Bas
> > PchTraceHubInitLib|ePch
> > TraceHubInitLib.inf
> >
> >  [LibraryClasses.IA32]
> > --
> > 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55906): https://edk2.groups.io/g/devel/message/55906
Mute This Topic: https://groups.io/mt/72001271/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-