Arm*Pkg: convert LFs to CRLF, expand hard TABs

[edk2-devel] [PATCH 0/3] Arm*Pkg: convert LFs to CRLF, expand hard TABs

Posted by Laszlo Ersek 4 years, 1 month ago

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1659
Repo:     https://github.com/lersek/edk2.git
Branch:   crlf_bz_1659

Future patches for some Arm*Pkg source files would either introduce CRLF
lines into LF files, or add more LF lines. The first would increase
inconsistency, the second would make "PatchCheck.py" yell. Convert these
files to CRLF uniformly (and while at it, expand hard TABS, because
"PatchCheck.py" catches those too).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks,
Laszlo

Laszlo Ersek (3):
  ArmPkg: convert LFs to CRLF, expand hard TABs
  ArmVirtPkg: convert LFs to CRLF
  ArmPlatformPkg: convert LFs to CRLF, expand hard TABs

 ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c     |  32 +-
 ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.c | 566 ++++++++---------
 ArmPkg/Library/CompilerIntrinsicsLib/memset.c    | 110 ++--
 ArmPkg/Library/GccLto/liblto-aarch64.s           |  42 +-
 ArmPkg/Library/GccLto/liblto-arm.s               | 110 ++--
 ArmPlatformPkg/Scripts/Ds5/profile.py            | 656 ++++++++++----------
 ArmVirtPkg/Include/Platform/Hidden.h             |  44 +-
 7 files changed, 780 insertions(+), 780 deletions(-)

-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55039): https://edk2.groups.io/g/devel/message/55039
Mute This Topic: https://groups.io/mt/71596310/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Arm*Pkg: convert LFs to CRLF, expand hard TABs

Posted by Ard Biesheuvel 4 years, 1 month ago

On Thu, 27 Feb 2020 at 22:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1659
> Repo:     https://github.com/lersek/edk2.git
> Branch:   crlf_bz_1659
>
> Future patches for some Arm*Pkg source files would either introduce CRLF
> lines into LF files, or add more LF lines. The first would increase
> inconsistency, the second would make "PatchCheck.py" yell. Convert these
> files to CRLF uniformly (and while at it, expand hard TABS, because
> "PatchCheck.py" catches those too).
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (3):
>   ArmPkg: convert LFs to CRLF, expand hard TABs
>   ArmVirtPkg: convert LFs to CRLF
>   ArmPlatformPkg: convert LFs to CRLF, expand hard TABs
>

For the series,

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>  ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c     |  32 +-
>  ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.c | 566 ++++++++---------
>  ArmPkg/Library/CompilerIntrinsicsLib/memset.c    | 110 ++--
>  ArmPkg/Library/GccLto/liblto-aarch64.s           |  42 +-
>  ArmPkg/Library/GccLto/liblto-arm.s               | 110 ++--
>  ArmPlatformPkg/Scripts/Ds5/profile.py            | 656 ++++++++++----------
>  ArmVirtPkg/Include/Platform/Hidden.h             |  44 +-
>  7 files changed, 780 insertions(+), 780 deletions(-)
>
> --
> 2.19.1.3.g30247aa5d201
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55042): https://edk2.groups.io/g/devel/message/55042
Mute This Topic: https://groups.io/mt/71596310/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Arm*Pkg: convert LFs to CRLF, expand hard TABs

Posted by Philippe Mathieu-Daudé 4 years, 1 month ago

On 2/27/20 10:39 PM, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1659
> Repo:     https://github.com/lersek/edk2.git
> Branch:   crlf_bz_1659
> 
> Future patches for some Arm*Pkg source files would either introduce CRLF
> lines into LF files, or add more LF lines. The first would increase
> inconsistency, the second would make "PatchCheck.py" yell. Convert these
> files to CRLF uniformly (and while at it, expand hard TABS, because
> "PatchCheck.py" catches those too).
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (3):
>    ArmPkg: convert LFs to CRLF, expand hard TABs
>    ArmVirtPkg: convert LFs to CRLF
>    ArmPlatformPkg: convert LFs to CRLF, expand hard TABs
> 
>   ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c     |  32 +-
>   ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.c | 566 ++++++++---------
>   ArmPkg/Library/CompilerIntrinsicsLib/memset.c    | 110 ++--
>   ArmPkg/Library/GccLto/liblto-aarch64.s           |  42 +-
>   ArmPkg/Library/GccLto/liblto-arm.s               | 110 ++--
>   ArmPlatformPkg/Scripts/Ds5/profile.py            | 656 ++++++++++----------
>   ArmVirtPkg/Include/Platform/Hidden.h             |  44 +-
>   7 files changed, 780 insertions(+), 780 deletions(-)
> 

Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55060): https://edk2.groups.io/g/devel/message/55060
Mute This Topic: https://groups.io/mt/71596310/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Arm*Pkg: convert LFs to CRLF, expand hard TABs

Posted by Laszlo Ersek 4 years, 1 month ago

On 02/27/20 22:39, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1659
> Repo:     https://github.com/lersek/edk2.git
> Branch:   crlf_bz_1659
> 
> Future patches for some Arm*Pkg source files would either introduce CRLF
> lines into LF files, or add more LF lines. The first would increase
> inconsistency, the second would make "PatchCheck.py" yell. Convert these
> files to CRLF uniformly (and while at it, expand hard TABS, because
> "PatchCheck.py" catches those too).
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (3):
>   ArmPkg: convert LFs to CRLF, expand hard TABs
>   ArmVirtPkg: convert LFs to CRLF
>   ArmPlatformPkg: convert LFs to CRLF, expand hard TABs
> 
>  ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c     |  32 +-
>  ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.c | 566 ++++++++---------
>  ArmPkg/Library/CompilerIntrinsicsLib/memset.c    | 110 ++--
>  ArmPkg/Library/GccLto/liblto-aarch64.s           |  42 +-
>  ArmPkg/Library/GccLto/liblto-arm.s               | 110 ++--
>  ArmPlatformPkg/Scripts/Ds5/profile.py            | 656 ++++++++++----------
>  ArmVirtPkg/Include/Platform/Hidden.h             |  44 +-
>  7 files changed, 780 insertions(+), 780 deletions(-)
> 

Merged as commit range 1158fc8e2c7b..e63d54db9526, via
<https://github.com/tianocore/edk2/pull/416/>.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55411): https://edk2.groups.io/g/devel/message/55411
Mute This Topic: https://groups.io/mt/71596310/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-