[edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2

marcandre.lureau@redhat.com posted 5 patches 4 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200226152433.1295789-1-marcandre.lureau@redhat.com
OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +
OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
8 files changed, 151 insertions(+), 63 deletions(-)
[edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
Posted by marcandre.lureau@redhat.com 4 years, 1 month ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

The following patches add basic TPM 1.2 support for Ovmf/QEMU.

Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough,
and emulated CRB/TPM 2.0.

Git branch: https://github.com/elmarco/edk2.git tpm1

v4:
 - misc style changes
 - drop "OvmfPkg: add TCG Configuration menu to the Device Manager menu" patch
 - add r-b tags

v3:
 - send a TPM 1.2 command to test TPM version
 - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
   2.0 commits

Marc-André Lureau (5):
  OvmfPkg: rename TPM2 config prefix to TPM
  OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
  OvmfPkg: include TcgPei module
  OvmfPkg: include TcgDxe module
  OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe

 OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
 OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
 OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
 OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
 OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
 OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +
 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
 8 files changed, 151 insertions(+), 63 deletions(-)

-- 
2.25.0.rc2.1.g09a9a1a997


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54894): https://edk2.groups.io/g/devel/message/54894
Mute This Topic: https://groups.io/mt/71568433/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
Posted by Simon Hardy 4 years, 1 month ago
I have successfully tested this on a machine with TPM 1.2, using passthrough mode to enable Bitlocker on the Windows 10 guest.

-----Original Message-----
From: marcandre.lureau@redhat.com [mailto:marcandre.lureau@redhat.com] 
Sent: 26 February 2020 15:24
To: devel@edk2.groups.io
Cc: lersek@redhat.com; Simon Hardy <simon.hardy@itdev.co.uk>; stefanb@linux.ibm.com; Marc-André Lureau <marcandre.lureau@redhat.com>
Subject: [PATCH v4 0/5] Ovmf: enable TPM 1.2

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

The following patches add basic TPM 1.2 support for Ovmf/QEMU.

Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough, and emulated CRB/TPM 2.0.

Git branch: https://github.com/elmarco/edk2.git tpm1

v4:
 - misc style changes
 - drop "OvmfPkg: add TCG Configuration menu to the Device Manager menu" patch
 - add r-b tags

v3:
 - send a TPM 1.2 command to test TPM version
 - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
   2.0 commits

Marc-André Lureau (5):
  OvmfPkg: rename TPM2 config prefix to TPM
  OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
  OvmfPkg: include TcgPei module
  OvmfPkg: include TcgDxe module
  OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe

 OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
 OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
 OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
 OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
 OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
 OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
 8 files changed, 151 insertions(+), 63 deletions(-)

--
2.25.0.rc2.1.g09a9a1a997


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55103): https://edk2.groups.io/g/devel/message/55103
Mute This Topic: https://groups.io/mt/71568433/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
Posted by Laszlo Ersek 4 years, 1 month ago
On 02/28/20 16:44, Simon Hardy wrote:
> I have successfully tested this on a machine with TPM 1.2, using passthrough mode to enable Bitlocker on the Windows 10 guest.

Thank you, Simon!

Can I take it as:

Tested-by: Simon Hardy <simon.hardy@itdev.co.uk>

for the whole series?

Thanks!
Laszlo

> 
> -----Original Message-----
> From: marcandre.lureau@redhat.com [mailto:marcandre.lureau@redhat.com] 
> Sent: 26 February 2020 15:24
> To: devel@edk2.groups.io
> Cc: lersek@redhat.com; Simon Hardy <simon.hardy@itdev.co.uk>; stefanb@linux.ibm.com; Marc-André Lureau <marcandre.lureau@redhat.com>
> Subject: [PATCH v4 0/5] Ovmf: enable TPM 1.2
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> The following patches add basic TPM 1.2 support for Ovmf/QEMU.
> 
> Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough, and emulated CRB/TPM 2.0.
> 
> Git branch: https://github.com/elmarco/edk2.git tpm1
> 
> v4:
>  - misc style changes
>  - drop "OvmfPkg: add TCG Configuration menu to the Device Manager menu" patch
>  - add r-b tags
> 
> v3:
>  - send a TPM 1.2 command to test TPM version
>  - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
>    2.0 commits
> 
> Marc-André Lureau (5):
>   OvmfPkg: rename TPM2 config prefix to TPM
>   OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
>   OvmfPkg: include TcgPei module
>   OvmfPkg: include TcgDxe module
>   OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
>  OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
>  OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
>  OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
>  8 files changed, 151 insertions(+), 63 deletions(-)
> 
> --
> 2.25.0.rc2.1.g09a9a1a997
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55100): https://edk2.groups.io/g/devel/message/55100
Mute This Topic: https://groups.io/mt/71568433/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
Posted by Simon Hardy 4 years, 1 month ago
Yes, that seems appropriate.

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: 29 February 2020 06:22
To: Simon Hardy <simon.hardy@itdev.co.uk>; marcandre.lureau@redhat.com; devel@edk2.groups.io
Cc: stefanb@linux.ibm.com
Subject: Re: [PATCH v4 0/5] Ovmf: enable TPM 1.2

On 02/28/20 16:44, Simon Hardy wrote:
> I have successfully tested this on a machine with TPM 1.2, using passthrough mode to enable Bitlocker on the Windows 10 guest.

Thank you, Simon!

Can I take it as:

Tested-by: Simon Hardy <simon.hardy@itdev.co.uk>

for the whole series?

Thanks!
Laszlo

> 
> -----Original Message-----
> From: marcandre.lureau@redhat.com [mailto:marcandre.lureau@redhat.com] 
> Sent: 26 February 2020 15:24
> To: devel@edk2.groups.io
> Cc: lersek@redhat.com; Simon Hardy <simon.hardy@itdev.co.uk>; stefanb@linux.ibm.com; Marc-André Lureau <marcandre.lureau@redhat.com>
> Subject: [PATCH v4 0/5] Ovmf: enable TPM 1.2
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> The following patches add basic TPM 1.2 support for Ovmf/QEMU.
> 
> Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough, and emulated CRB/TPM 2.0.
> 
> Git branch: https://github.com/elmarco/edk2.git tpm1
> 
> v4:
>  - misc style changes
>  - drop "OvmfPkg: add TCG Configuration menu to the Device Manager menu" patch
>  - add r-b tags
> 
> v3:
>  - send a TPM 1.2 command to test TPM version
>  - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
>    2.0 commits
> 
> Marc-André Lureau (5):
>   OvmfPkg: rename TPM2 config prefix to TPM
>   OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
>   OvmfPkg: include TcgPei module
>   OvmfPkg: include TcgDxe module
>   OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
>  OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
>  OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
>  OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
>  8 files changed, 151 insertions(+), 63 deletions(-)
> 
> --
> 2.25.0.rc2.1.g09a9a1a997
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55161): https://edk2.groups.io/g/devel/message/55161
Mute This Topic: https://groups.io/mt/71568433/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
Posted by Laszlo Ersek 4 years, 1 month ago
On 02/26/20 16:24, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> The following patches add basic TPM 1.2 support for Ovmf/QEMU.
> 
> Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough,
> and emulated CRB/TPM 2.0.
> 
> Git branch: https://github.com/elmarco/edk2.git tpm1
> 
> v4:
>  - misc style changes
>  - drop "OvmfPkg: add TCG Configuration menu to the Device Manager menu" patch
>  - add r-b tags
> 
> v3:
>  - send a TPM 1.2 command to test TPM version
>  - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
>    2.0 commits
> 
> Marc-André Lureau (5):
>   OvmfPkg: rename TPM2 config prefix to TPM
>   OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
>   OvmfPkg: include TcgPei module
>   OvmfPkg: include TcgDxe module
>   OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                  | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
>  OvmfPkg/OvmfPkgIa32X64.dsc               | 33 ++++++----
>  OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
>  OvmfPkg/OvmfPkgX64.dsc                   | 33 ++++++----
>  OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 82 +++++++++++++++++++-----
>  8 files changed, 151 insertions(+), 63 deletions(-)
> 

Merged as commit range ecb30848fdc9..61d3b2d4279e, via
<https://github.com/tianocore/edk2/pull/416/>.

Thanks,
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55409): https://edk2.groups.io/g/devel/message/55409
Mute This Topic: https://groups.io/mt/71568433/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-