1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.

Siyuan, Fu posted 1 patch 4 years, 1 month ago
Failed in applying to current master (apply log)
.../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
Posted by Siyuan, Fu 4 years, 1 month ago 
This patch fixes a potential compiler error introduced by commit
b0099a39bd since not all compiler can support empty array member.

BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
 .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
index d1a9d79a51..d887b39123 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
@@ -33,7 +33,7 @@ typedef struct {
   // An array with MicrocodeCount elements that stores
   // the shadowed microcode patch address in memory.
   //
-  UINT64    MicrocodeAddrInMemory[];
+  UINT64    MicrocodeAddrInMemory[0];
   //
   // A buffer which contains details about the storage information
   // specific to StorageType.
-- 
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54828): https://edk2.groups.io/g/devel/message/54828
Mute This Topic: https://groups.io/mt/71546083/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
Posted by Liming Gao 4 years, 1 month ago 
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Siyuan, Fu
> Sent: Wednesday, February 26, 2020 9:08 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
> 
> This patch fixes a potential compiler error introduced by commit
> b0099a39bd since not all compiler can support empty array member.
> 
> BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
>  .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> index d1a9d79a51..d887b39123 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> @@ -33,7 +33,7 @@ typedef struct {
>    // An array with MicrocodeCount elements that stores
>    // the shadowed microcode patch address in memory.
>    //
> -  UINT64    MicrocodeAddrInMemory[];
> +  UINT64    MicrocodeAddrInMemory[0];
>    //
>    // A buffer which contains details about the storage information
>    // specific to StorageType.
> --
> 2.19.1.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54829): https://edk2.groups.io/g/devel/message/54829
Mute This Topic: https://groups.io/mt/71546083/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
Posted by Chaganty, Rangasai V 4 years, 1 month ago 
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Fu, Siyuan <siyuan.fu@intel.com> 
Sent: Tuesday, February 25, 2020 5:08 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.

This patch fixes a potential compiler error introduced by commit b0099a39bd since not all compiler can support empty array member.

BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
 .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
index d1a9d79a51..d887b39123 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.
+++ h
@@ -33,7 +33,7 @@ typedef struct {
   // An array with MicrocodeCount elements that stores
   // the shadowed microcode patch address in memory.
   //
-  UINT64    MicrocodeAddrInMemory[];
+  UINT64    MicrocodeAddrInMemory[0];
   //
   // A buffer which contains details about the storage information
   // specific to StorageType.
--
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54833): https://edk2.groups.io/g/devel/message/54833
Mute This Topic: https://groups.io/mt/71546083/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
Posted by Ni, Ray 4 years, 1 month ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Sent: Wednesday, February 26, 2020 9:39 AM
> To: Fu, Siyuan <siyuan.fu@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
> 
> Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
> 
> -----Original Message-----
> From: Fu, Siyuan <siyuan.fu@intel.com>
> Sent: Tuesday, February 25, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
> 
> This patch fixes a potential compiler error introduced by commit b0099a39bd since not all compiler can support empty
> array member.
> 
> BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
>  .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> index d1a9d79a51..d887b39123 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.
> +++ h
> @@ -33,7 +33,7 @@ typedef struct {
>    // An array with MicrocodeCount elements that stores
>    // the shadowed microcode patch address in memory.
>    //
> -  UINT64    MicrocodeAddrInMemory[];
> +  UINT64    MicrocodeAddrInMemory[0];
>    //
>    // A buffer which contains details about the storage information
>    // specific to StorageType.
> --
> 2.19.1.windows.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54836): https://edk2.groups.io/g/devel/message/54836
Mute This Topic: https://groups.io/mt/71546083/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.