1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu

Ard Biesheuvel posted 5 patches 4 years, 2 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
ArmVirtPkg/ArmVirt.dsc.inc                    |   6 +
ArmVirtPkg/ArmVirtPkg.dec                     |   6 +
ArmVirtPkg/ArmVirtQemu.dsc                    |  75 ++++++
ArmVirtPkg/ArmVirtQemu.fdf                    |   6 +
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc          |  10 +
.../ArmVirtPsciResetSystemPeiLib.c            | 232 ++++++++++++++++++
.../ArmVirtPsciResetSystemPeiLib.inf          |  39 +++
.../Library/PlatformPeiLib/PlatformPeiLib.c   | 101 +++++++-
.../Library/PlatformPeiLib/PlatformPeiLib.inf |  20 +-
OvmfPkg/OvmfPkg.dec                           |   5 +
OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf      |   6 +-
11 files changed, 491 insertions(+), 15 deletions(-)
create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.c
create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.inf
[edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu
Posted by Ard Biesheuvel 4 years, 2 months ago 
Wire up the various existing pieces so that we can implement measured
boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
been implemented for x86 in OvmfPkg.

The main difference is that on ARM, we first need to discover the TPM base
address from the device tree provided by QEMU, as well as the PSCI method
used to perform a cold reset.

Changes since v1:
- use a separate ResetSystemLib instance based on on-demand parsing of the
  DT, and expose it via the ResetSystem PPI to other client PEIMs
- add Laszlo's ack to #1
- incorporate Laszlo's review feedback across the board

Cc: lersek@redhat.com
Cc: eric.auger@redhat.com
Cc: philmd@redhat.com
Cc: marcandre.lureau@redhat.com
Cc: stefanb@linux.ibm.com
Cc: leif@nuviainc.com

Ard Biesheuvel (5):
  OvmfPkg/Tcg2ConfigPei: introduce a signalling PPI to depex on
  ArmVirtPkg/PlatformPeiLib: make PcdLib dependency explicit in .INF
  ArmVirtPkg/PlatformPeiLib: discover the TPM base address from the DT
  ArmVirtPkg: implement ArmVirtPsciResetSystemPeiLib
  ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

 ArmVirtPkg/ArmVirt.dsc.inc                    |   6 +
 ArmVirtPkg/ArmVirtPkg.dec                     |   6 +
 ArmVirtPkg/ArmVirtQemu.dsc                    |  75 ++++++
 ArmVirtPkg/ArmVirtQemu.fdf                    |   6 +
 ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc          |  10 +
 .../ArmVirtPsciResetSystemPeiLib.c            | 232 ++++++++++++++++++
 .../ArmVirtPsciResetSystemPeiLib.inf          |  39 +++
 .../Library/PlatformPeiLib/PlatformPeiLib.c   | 101 +++++++-
 .../Library/PlatformPeiLib/PlatformPeiLib.inf |  20 +-
 OvmfPkg/OvmfPkg.dec                           |   5 +
 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf      |   6 +-
 11 files changed, 491 insertions(+), 15 deletions(-)
 create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.c
 create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.inf

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54779): https://edk2.groups.io/g/devel/message/54779
Mute This Topic: https://groups.io/mt/71530900/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu
Posted by Ard Biesheuvel 4 years, 2 months ago 
On Tue, 25 Feb 2020 at 11:45, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> Wire up the various existing pieces so that we can implement measured
> boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
> been implemented for x86 in OvmfPkg.
>
> The main difference is that on ARM, we first need to discover the TPM base
> address from the device tree provided by QEMU, as well as the PSCI method
> used to perform a cold reset.
>
> Changes since v1:
> - use a separate ResetSystemLib instance based on on-demand parsing of the
>   DT, and expose it via the ResetSystem PPI to other client PEIMs
> - add Laszlo's ack to #1
> - incorporate Laszlo's review feedback across the board
>

Forgot to include the link to the QEMU work being done by Eric in parallel:

https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03830.html


> Cc: lersek@redhat.com
> Cc: eric.auger@redhat.com
> Cc: philmd@redhat.com
> Cc: marcandre.lureau@redhat.com
> Cc: stefanb@linux.ibm.com
> Cc: leif@nuviainc.com
>
> Ard Biesheuvel (5):
>   OvmfPkg/Tcg2ConfigPei: introduce a signalling PPI to depex on
>   ArmVirtPkg/PlatformPeiLib: make PcdLib dependency explicit in .INF
>   ArmVirtPkg/PlatformPeiLib: discover the TPM base address from the DT
>   ArmVirtPkg: implement ArmVirtPsciResetSystemPeiLib
>   ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot
>
>  ArmVirtPkg/ArmVirt.dsc.inc                    |   6 +
>  ArmVirtPkg/ArmVirtPkg.dec                     |   6 +
>  ArmVirtPkg/ArmVirtQemu.dsc                    |  75 ++++++
>  ArmVirtPkg/ArmVirtQemu.fdf                    |   6 +
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc          |  10 +
>  .../ArmVirtPsciResetSystemPeiLib.c            | 232 ++++++++++++++++++
>  .../ArmVirtPsciResetSystemPeiLib.inf          |  39 +++
>  .../Library/PlatformPeiLib/PlatformPeiLib.c   | 101 +++++++-
>  .../Library/PlatformPeiLib/PlatformPeiLib.inf |  20 +-
>  OvmfPkg/OvmfPkg.dec                           |   5 +
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf      |   6 +-
>  11 files changed, 491 insertions(+), 15 deletions(-)
>  create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.c
>  create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.inf
>
> --
> 2.17.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54785): https://edk2.groups.io/g/devel/message/54785
Mute This Topic: https://groups.io/mt/71530900/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu
Posted by Laszlo Ersek 4 years, 2 months ago 
On 02/25/20 11:44, Ard Biesheuvel wrote:
> Wire up the various existing pieces so that we can implement measured
> boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
> been implemented for x86 in OvmfPkg.
> 
> The main difference is that on ARM, we first need to discover the TPM base
> address from the device tree provided by QEMU, as well as the PSCI method
> used to perform a cold reset.
> 
> Changes since v1:
> - use a separate ResetSystemLib instance based on on-demand parsing of the
>   DT, and expose it via the ResetSystem PPI to other client PEIMs
> - add Laszlo's ack to #1
> - incorporate Laszlo's review feedback across the board

Can you please file a new tianocore feature request BZ for this, and hook the BZ ref into all of the commit messages?

Also, in the BZ, can you please reference both versions posted thus far:

* [edk2-devel] [PATCH 0/4]
  ArmVirtPkg: implement measured boot for ArmVirtQemu

  https://edk2.groups.io/g/devel/message/52972
  http://mid.mail-archive.com/20200107094800.4488-1-ard.biesheuvel@linaro.org

* [edk2-devel] [PATCH v2 0/5]
  ArmVirtPkg: implement measured boot for ArmVirtQemu

  https://edk2.groups.io/g/devel/message/54779
  http://mid.mail-archive.com/20200225104449.22453-1-ard.biesheuvel@linaro.org

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54812): https://edk2.groups.io/g/devel/message/54812
Mute This Topic: https://groups.io/mt/71530900/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu
Posted by Ard Biesheuvel 4 years, 2 months ago 
On Wed, 26 Feb 2020 at 01:17, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 02/25/20 11:44, Ard Biesheuvel wrote:
> > Wire up the various existing pieces so that we can implement measured
> > boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
> > been implemented for x86 in OvmfPkg.
> >
> > The main difference is that on ARM, we first need to discover the TPM base
> > address from the device tree provided by QEMU, as well as the PSCI method
> > used to perform a cold reset.
> >
> > Changes since v1:
> > - use a separate ResetSystemLib instance based on on-demand parsing of the
> >   DT, and expose it via the ResetSystem PPI to other client PEIMs
> > - add Laszlo's ack to #1
> > - incorporate Laszlo's review feedback across the board
>
> Can you please file a new tianocore feature request BZ for this, and hook the BZ ref into all of the commit messages?
>
> Also, in the BZ, can you please reference both versions posted thus far:
>
> * [edk2-devel] [PATCH 0/4]
>   ArmVirtPkg: implement measured boot for ArmVirtQemu
>
>   https://edk2.groups.io/g/devel/message/52972
>   http://mid.mail-archive.com/20200107094800.4488-1-ard.biesheuvel@linaro.org
>
> * [edk2-devel] [PATCH v2 0/5]
>   ArmVirtPkg: implement measured boot for ArmVirtQemu
>
>   https://edk2.groups.io/g/devel/message/54779
>   http://mid.mail-archive.com/20200225104449.22453-1-ard.biesheuvel@linaro.org
>

Done!

https://bugzilla.tianocore.org/show_bug.cgi?id=2560

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54871): https://edk2.groups.io/g/devel/message/54871
Mute This Topic: https://groups.io/mt/71530900/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.