1. Patchew
  2. EDK2
  3. [edk2-devel] [Patch 0/2] Disable EBC for unit tests
  4. View patch

[edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

Michael D Kinney posted 2 patches 5 years, 12 months ago
[edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
Posted by Michael D Kinney 5 years, 12 months ago 
https://bugzilla.tianocore.org/show_bug.cgi?id=2514

Remove EBC as one of the supported architectures
in the UnitTestFrameworkPkg DSC file.  The EBC
compiler does not support cararg macros and the
UnitTestLib class uses this feature.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
index 0ad4482273..53d8f52754 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
@@ -13,7 +13,7 @@ [Defines]
   PLATFORM_VERSION        = 1.00
   DSC_SPECIFICATION       = 0x00010005
   OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
-  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
+  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
   BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER        = DEFAULT
 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54163): https://edk2.groups.io/g/devel/message/54163
Mute This Topic: https://groups.io/mt/71148316/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
Posted by Laszlo Ersek 5 years, 12 months ago 
On 02/10/20 21:24, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2514
> 
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file.  The EBC
> compiler does not support cararg macros and the

small typo: s/cararg/vararg/

Thanks
Laszlo

> UnitTestLib class uses this feature.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> index 0ad4482273..53d8f52754 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> @@ -13,7 +13,7 @@ [Defines]
>    PLATFORM_VERSION        = 1.00
>    DSC_SPECIFICATION       = 0x00010005
>    OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
> -  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
>    BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER        = DEFAULT
>  
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54190): https://edk2.groups.io/g/devel/message/54190
Mute This Topic: https://groups.io/mt/71148316/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
Posted by Bret Barkelew via Groups.Io 5 years, 11 months ago 
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Tuesday, February 11, 2020 1:02:17 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

On 02/10/20 21:24, Michael D Kinney wrote:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cabce6dc4e8984e69faae08d7aed12330%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637170085571112419&amp;sdata=J40%2BxMF1CTlCdsZMK4%2Fjtp2jKkSdunF1b07tU34BIk4%3D&amp;reserved=0
>
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file.  The EBC
> compiler does not support cararg macros and the

small typo: s/cararg/vararg/

Thanks
Laszlo

> UnitTestLib class uses this feature.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> index 0ad4482273..53d8f52754 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> @@ -13,7 +13,7 @@ [Defines]
>    PLATFORM_VERSION        = 1.00
>    DSC_SPECIFICATION       = 0x00010005
>    OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
> -  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
>    BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER        = DEFAULT
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54661): https://edk2.groups.io/g/devel/message/54661
Mute This Topic: https://groups.io/mt/71412843/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
Posted by Bret Barkelew via Groups.Io 5 years, 12 months ago 
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>

- Bret

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io>
Sent: Monday, February 10, 2020 12:24:40 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C9e9da4e9e08b40dca06308d7ae67455a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169630879174350&amp;sdata=ye%2FQPMZgnrj8BE3spu07pO5optLKsh%2F%2Fa8YRZruZZ94%3D&amp;reserved=0

Remove EBC as one of the supported architectures
in the UnitTestFrameworkPkg DSC file.  The EBC
compiler does not support cararg macros and the
UnitTestLib class uses this feature.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
index 0ad4482273..53d8f52754 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
@@ -13,7 +13,7 @@ [Defines]
   PLATFORM_VERSION        = 1.00
   DSC_SPECIFICATION       = 0x00010005
   OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
-  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
+  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
   BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER        = DEFAULT

--
2.21.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54234): https://edk2.groups.io/g/devel/message/54234
Mute This Topic: https://groups.io/mt/71180438/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.