[edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

Chiu, Chasel posted 2 patches 32 weeks ago
Failed in applying to current master (apply log)
IntelFsp2Pkg/Tools/GenCfgOpt.py   |  3 ++-
IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
2 files changed, 7 insertions(+), 6 deletions(-)

[edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

Posted by Chiu, Chasel 32 weeks ago
GenCfgOpt.py:
Issue was: invalid_operation: Invalid operation on
null-like value "Base".
Fixed it by initializing Base to 0 before entering
while loop.

SplitFspBin.py:
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on
null-like value "roffset".
3. invalid_operation: Invalid operation on
null-like value "rsize".
Fixed them by initializing roffset and rsize as PE32
image type and overriding them when PE32+ header found.

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>

Chasel Chiu (2):
  IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.
  IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues.

 IntelFsp2Pkg/Tools/GenCfgOpt.py   |  3 ++-
 IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

-- 
2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54105): https://edk2.groups.io/g/devel/message/54105
Mute This Topic: https://groups.io/mt/71127614/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

Posted by Nate DeSimone 32 weeks ago
For the patch series...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> 
Sent: Sunday, February 9, 2020 7:53 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice <maurice.ma@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

GenCfgOpt.py:
Issue was: invalid_operation: Invalid operation on null-like value "Base".
Fixed it by initializing Base to 0 before entering while loop.

SplitFspBin.py:
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on null-like value "roffset".
3. invalid_operation: Invalid operation on null-like value "rsize".
Fixed them by initializing roffset and rsize as PE32 image type and overriding them when PE32+ header found.

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>

Chasel Chiu (2):
  IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.
  IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues.

 IntelFsp2Pkg/Tools/GenCfgOpt.py   |  3 ++-
 IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

--
2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54271): https://edk2.groups.io/g/devel/message/54271
Mute This Topic: https://groups.io/mt/71127614/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

Posted by Zeng, Star 32 weeks ago
Reviewed-by: Star Zeng <star.zeng@intel.com>

> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Monday, February 10, 2020 11:53 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
> 
> GenCfgOpt.py:
> Issue was: invalid_operation: Invalid operation on null-like value "Base".
> Fixed it by initializing Base to 0 before entering while loop.
> 
> SplitFspBin.py:
> Issues were:
> 1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
> 2. invalid_operation: Invalid operation on null-like value "roffset".
> 3. invalid_operation: Invalid operation on null-like value "rsize".
> Fixed them by initializing roffset and rsize as PE32 image type and overriding
> them when PE32+ header found.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> Chasel Chiu (2):
>   IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.
>   IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues.
> 
>  IntelFsp2Pkg/Tools/GenCfgOpt.py   |  3 ++-
>  IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> --
> 2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54112): https://edk2.groups.io/g/devel/message/54112
Mute This Topic: https://groups.io/mt/71127614/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-