[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

Javeed, Ashraf posted 1 patch 33 weeks ago
Failed in applying to current master (apply log)
MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

Posted by Javeed, Ashraf 33 weeks ago
Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
index dc58268..bb2c8c8 100644
--- a/MdePkg/Include/Protocol/PciExpressPlatform.h
+++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
@@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
 };
 
 ///
-/// Reserves for future use
-///
-typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
-
-///
-/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
-/// byte field representing one PCI standerd feature defined in the PCI Express Base
-/// Specification 4.0, version 1.0.
+/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
+/// to its version, with each byte field represents one PCI Express feature and
+/// its bitmask define the legal combinations to represent all the valid combinations
+/// of its attributes, defined in the PCI Express Base Specification.
 ///
 typedef struct {
   EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE  DeviceCtlMPS;
@@ -384,7 +380,6 @@ typedef struct {
   EFI_PCI_EXPRESS_CTO_SUPPORT       CTOsupport;
   EFI_PCI_EXPRESS_CPM               LinkCtlCPM;
   EFI_PCI_EXPRESS_L1PM_SUBSTATES    L1PMSubstates;
-  EFI_PCI_EXPRESS_RESERVES          Reserves[114];
 } EFI_PCI_EXPRESS_DEVICE_POLICY;
 
 ///
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53858): https://edk2.groups.io/g/devel/message/53858
Mute This Topic: https://groups.io/mt/71019797/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

Posted by Ni, Ray 32 weeks ago
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
> 
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
>  };
> 
>  ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
> -/// byte field representing one PCI standerd feature defined in the PCI Express Base
> -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
> +/// to its version, with each byte field represents one PCI Express feature and
> +/// its bitmask define the legal combinations to represent all the valid combinations
> +/// of its attributes, defined in the PCI Express Base Specification.
>  ///
>  typedef struct {
>    EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE  DeviceCtlMPS;
> @@ -384,7 +380,6 @@ typedef struct {
>    EFI_PCI_EXPRESS_CTO_SUPPORT       CTOsupport;
>    EFI_PCI_EXPRESS_CPM               LinkCtlCPM;
>    EFI_PCI_EXPRESS_L1PM_SUBSTATES    L1PMSubstates;
> -  EFI_PCI_EXPRESS_RESERVES          Reserves[114];
>  } EFI_PCI_EXPRESS_DEVICE_POLICY;
> 
>  ///
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54103): https://edk2.groups.io/g/devel/message/54103
Mute This Topic: https://groups.io/mt/71019797/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

Posted by Liming Gao 33 weeks ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
> 
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
>  };
> 
>  ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
> -/// byte field representing one PCI standerd feature defined in the PCI Express Base
> -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
> +/// to its version, with each byte field represents one PCI Express feature and
> +/// its bitmask define the legal combinations to represent all the valid combinations
> +/// of its attributes, defined in the PCI Express Base Specification.
>  ///
>  typedef struct {
>    EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE  DeviceCtlMPS;
> @@ -384,7 +380,6 @@ typedef struct {
>    EFI_PCI_EXPRESS_CTO_SUPPORT       CTOsupport;
>    EFI_PCI_EXPRESS_CPM               LinkCtlCPM;
>    EFI_PCI_EXPRESS_L1PM_SUBSTATES    L1PMSubstates;
> -  EFI_PCI_EXPRESS_RESERVES          Reserves[114];
>  } EFI_PCI_EXPRESS_DEVICE_POLICY;
> 
>  ///
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54003): https://edk2.groups.io/g/devel/message/54003
Mute This Topic: https://groups.io/mt/71019797/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-