[edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub

Pete Batard posted 3 patches 4 years, 2 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c   |  45 ++++++++
Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf |  43 ++++++++
Platform/RaspberryPi/RPi4/RPi4.dsc                             |   5 +
Platform/RaspberryPi/RPi4/RPi4.fdf                             |   1 +
Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf       |  40 +++++++
Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c               | 114 ++++++++++++++++++++
Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h               |  20 ++++
Silicon/Broadcom/Drivers/Net/BcmNet.dec                        |  22 ++++
8 files changed, 290 insertions(+)
create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec
[edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub
Posted by Pete Batard 4 years, 2 months ago
Changes from v2:
* Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check

Jeremy Linton (2):
  Silicon/Broadcom/Net: Add Genet stub driver to setup MAC
  Platform/RPi4: Enable Broadcom Genet stub driver

Pete Batard (1):
  Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c   |  45 ++++++++
 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf |  43 ++++++++
 Platform/RaspberryPi/RPi4/RPi4.dsc                             |   5 +
 Platform/RaspberryPi/RPi4/RPi4.fdf                             |   1 +
 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf       |  40 +++++++
 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c               | 114 ++++++++++++++++++++
 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h               |  20 ++++
 Silicon/Broadcom/Drivers/Net/BcmNet.dec                        |  22 ++++
 8 files changed, 290 insertions(+)
 create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
 create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
 create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf
 create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
 create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h
 create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53656): https://edk2.groups.io/g/devel/message/53656
Mute This Topic: https://groups.io/mt/70945773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub
Posted by Ard Biesheuvel 4 years, 2 months ago
On Mon, 3 Feb 2020 at 13:14, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v2:
> * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check
>
> Jeremy Linton (2):
>   Silicon/Broadcom/Net: Add Genet stub driver to setup MAC
>   Platform/RPi4: Enable Broadcom Genet stub driver
>
> Pete Batard (1):
>   Platform/RPi: Add PlatformPcdLib to set the Genet MAC address
>

For the series,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 2253a252a61b..3f0d14bb1358


>  Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c   |  45 ++++++++
>  Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf |  43 ++++++++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                             |   5 +
>  Platform/RaspberryPi/RPi4/RPi4.fdf                             |   1 +
>  Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf       |  40 +++++++
>  Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c               | 114 ++++++++++++++++++++
>  Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h               |  20 ++++
>  Silicon/Broadcom/Drivers/Net/BcmNet.dec                        |  22 ++++
>  8 files changed, 290 insertions(+)
>  create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
>  create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
>  create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf
>  create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
>  create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h
>  create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec
>
> --
> 2.21.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54092): https://edk2.groups.io/g/devel/message/54092
Mute This Topic: https://groups.io/mt/70945773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub
Posted by Pete Batard 4 years, 2 months ago
Hi Ard,

On 2020.02.08 08:50, Ard Biesheuvel wrote:
> On Mon, 3 Feb 2020 at 13:14, Pete Batard <pete@akeo.ie> wrote:
>>
>> Changes from v2:
>> * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check
>>
>> Jeremy Linton (2):
>>    Silicon/Broadcom/Net: Add Genet stub driver to setup MAC
>>    Platform/RPi4: Enable Broadcom Genet stub driver
>>
>> Pete Batard (1):
>>    Platform/RPi: Add PlatformPcdLib to set the Genet MAC address
>>
> 
> For the series,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Pushed as 2253a252a61b..3f0d14bb1358

Thanks.


I guess I'll use this opportunity to send another reminder about Jared's 
two liner (who must start to feel desperate to ever see his work 
integrated into platforms) as well as other RPi patches, that came 
before this one, and that I hope are not in the process of falling 
through the cracks...

- https://edk2.groups.io/g/devel/topic/69331625#52611
- https://edk2.groups.io/g/devel/topic/69532223#53028
- https://edk2.groups.io/g/devel/topic/69532224#53029

Regards,

/Pete


> 
> 
>>   Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c   |  45 ++++++++
>>   Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf |  43 ++++++++
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                             |   5 +
>>   Platform/RaspberryPi/RPi4/RPi4.fdf                             |   1 +
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf       |  40 +++++++
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c               | 114 ++++++++++++++++++++
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h               |  20 ++++
>>   Silicon/Broadcom/Drivers/Net/BcmNet.dec                        |  22 ++++
>>   8 files changed, 290 insertions(+)
>>   create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
>>   create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec
>>
>> --
>> 2.21.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54095): https://edk2.groups.io/g/devel/message/54095
Mute This Topic: https://groups.io/mt/70945773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-