Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency

[edk2-devel] [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency

Posted by Ard Biesheuvel 4 years, 3 months ago

StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
away with not declaring it in its INF because of a transitive
dependency. However, this dependency got dropped in core EDK2,
resulting in build failures of the Styx platform.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
index bcc2306ec93d..54a2e4ea9da6 100644
--- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
+++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
@@ -35,6 +35,9 @@
   UefiRuntimeLib
   DxeServicesTableLib
 
+[Guids]
+  gEfiEventVirtualAddressChangeGuid
+
 [FixedPcd]
   gArmTokenSpaceGuid.PcdFdBaseAddress
 
-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53280): https://edk2.groups.io/g/devel/message/53280
Mute This Topic: https://groups.io/mt/69718927/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency

Posted by Leif Lindholm 4 years, 3 months ago

On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote:
> StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> away with not declaring it in its INF because of a transitive
> dependency. However, this dependency got dropped in core EDK2,
> resulting in build failures of the Styx platform.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> index bcc2306ec93d..54a2e4ea9da6 100644
> --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> @@ -35,6 +35,9 @@
>    UefiRuntimeLib
>    DxeServicesTableLib
>  
> +[Guids]
> +  gEfiEventVirtualAddressChangeGuid
> +
>  [FixedPcd]
>    gArmTokenSpaceGuid.PcdFdBaseAddress
>  
> -- 
> 2.20.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53326): https://edk2.groups.io/g/devel/message/53326
Mute This Topic: https://groups.io/mt/69718927/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency

Posted by Ard Biesheuvel 4 years, 3 months ago

On Thu, 16 Jan 2020 at 22:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote:
> > StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> > away with not declaring it in its INF because of a transitive
> > dependency. However, this dependency got dropped in core EDK2,
> > resulting in build failures of the Styx platform.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed, thanks.

> > ---
> >  Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > index bcc2306ec93d..54a2e4ea9da6 100644
> > --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > @@ -35,6 +35,9 @@
> >    UefiRuntimeLib
> >    DxeServicesTableLib
> >
> > +[Guids]
> > +  gEfiEventVirtualAddressChangeGuid
> > +
> >  [FixedPcd]
> >    gArmTokenSpaceGuid.PcdFdBaseAddress
> >
> > --
> > 2.20.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53346): https://edk2.groups.io/g/devel/message/53346
Mute This Topic: https://groups.io/mt/69718927/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-