[edk2-devel] [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc

Lan-chinX Hsu posted 1 patch 4 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200115104219.530-1-lan-chinx.hsu@intel.com
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
Posted by Lan-chinX Hsu 4 years, 3 months ago
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030

Change MTOC PATH to reference $PATH to find mtoc.

The Patch is going to fix this issue

Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
---
 BaseTools/Conf/tools_def.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index feee2bbf16..39b8c2e7df 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
 *_XCODE5_*_ASLPP_PATH    = clang
 *_XCODE5_*_ASLDLINK_PATH = ld
 *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
-*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
+*_XCODE5_*_MTOC_PATH     = mtoc
 *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
 
 ##################
-- 
2.25.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53275): https://edk2.groups.io/g/devel/message/53275
Mute This Topic: https://groups.io/mt/69715840/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
Posted by Liming Gao 4 years, 3 months ago
Hi, 
  DSYMUTIL path can be changed together.

Thanks
Liming
> -----Original Message-----
> From: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>
> Sent: Wednesday, January 15, 2020 6:42 PM
> To: devel@edk2.groups.io
> Cc: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030
> 
> Change MTOC PATH to reference $PATH to find mtoc.
> 
> The Patch is going to fix this issue
> 
> Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index feee2bbf16..39b8c2e7df 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
>  *_XCODE5_*_ASLPP_PATH    = clang
> 
>  *_XCODE5_*_ASLDLINK_PATH = ld
> 
>  *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
> 
> -*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
> 
> +*_XCODE5_*_MTOC_PATH     = mtoc
> 
>  *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
> 
> 
> 
>  ##################
> 
> --
> 2.25.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53279): https://edk2.groups.io/g/devel/message/53279
Mute This Topic: https://groups.io/mt/69715840/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-