REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463
Perform Data and Address line test only if not ignore memory test.
Signed-off-by: Heng Luo <heng.luo@intel.com>
---
.../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c
index ce9e5e659b..fe24e490d4 100644
--- a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c
+++ b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -677,10 +677,12 @@ GenMemoryTestFinished (
Private = GENERIC_MEMORY_TEST_PRIVATE_FROM_THIS (This);
//
- // Perform Data and Address line test
+ // Perform Data and Address line test only if not ignore memory test
//
- Status = PerformAddressDataLineTest (Private);
- ASSERT_EFI_ERROR (Status);
+ if (Private->CoverLevel != IGNORE) {
+ Status = PerformAddressDataLineTest (Private);
+ ASSERT_EFI_ERROR (Status);
+ }
//
// Add the non tested memory range to system memory map through GCD service
--
2.24.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#53222): https://edk2.groups.io/g/devel/message/53222
Mute This Topic: https://groups.io/mt/69692450/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo > Sent: Tuesday, January 14, 2020 4:54 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463 > > Perform Data and Address line test only if not ignore memory test. > > Signed-off-by: Heng Luo <heng.luo@intel.com> > --- > .../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c > b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c > index ce9e5e659b..fe24e490d4 100644 > --- a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c > +++ b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c > @@ -1,6 +1,6 @@ > /** @file > > > > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> > > + Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR> > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -677,10 +677,12 @@ GenMemoryTestFinished ( > Private = GENERIC_MEMORY_TEST_PRIVATE_FROM_THIS (This); > > > > // > > - // Perform Data and Address line test > > + // Perform Data and Address line test only if not ignore memory test > > // > > - Status = PerformAddressDataLineTest (Private); > > - ASSERT_EFI_ERROR (Status); > > + if (Private->CoverLevel != IGNORE) { > > + Status = PerformAddressDataLineTest (Private); > > + ASSERT_EFI_ERROR (Status); > > + } > > > > // > > // Add the non tested memory range to system memory map through GCD service > > -- > 2.24.0.windows.2 > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#53222): https://edk2.groups.io/g/devel/message/53222 > Mute This Topic: https://groups.io/mt/69692450/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53822): https://edk2.groups.io/g/devel/message/53822 Mute This Topic: https://groups.io/mt/69692450/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Heng: The change is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com> Thanks Liming -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo Sent: 2020年1月14日 16:54 To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463 Perform Data and Address line test only if not ignore memory test. Signed-off-by: Heng Luo <heng.luo@intel.com> --- .../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c index ce9e5e659b..fe24e490d4 100644 --- a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c +++ b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemory +++ Test.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>+ Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -677,10 +677,12 @@ GenMemoryTestFinished ( Private = GENERIC_MEMORY_TEST_PRIVATE_FROM_THIS (This); //- // Perform Data and Address line test+ // Perform Data and Address line test only if not ignore memory test //- Status = PerformAddressDataLineTest (Private);- ASSERT_EFI_ERROR (Status);+ if (Private->CoverLevel != IGNORE) {+ Status = PerformAddressDataLineTest (Private);+ ASSERT_EFI_ERROR (Status);+ } // // Add the non tested memory range to system memory map through GCD service-- 2.24.0.windows.2 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53222): https://edk2.groups.io/g/devel/message/53222 Mute This Topic: https://groups.io/mt/69692450/1759384 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53387): https://edk2.groups.io/g/devel/message/53387 Mute This Topic: https://groups.io/mt/69692450/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.