IntelSiliconPkg-VTd: Fixed a ECC Error

[edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

Posted by Evelyn Wang 4 years, 3 months ago

The function has NO comment immediately preceding it.
Need to remove the space between the function and the comment

Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: More Shih <more.shih@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>

---
In V1:
Add a issue description
---
 Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
index ebfe904053..86c519f48d 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
@@ -13,7 +13,6 @@
   Get the global VT-d protected memory alignment.
   @return The maximum protected memory alignment. Ex: 0x100000
 **/
-
 UINTN
 EFIAPI
 GetGlobalVtdPmrAlignment (
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53096): https://edk2.groups.io/g/devel/message/53096
Mute This Topic: https://groups.io/mt/69589399/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

Posted by Yao, Jiewen 4 years, 3 months ago

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Wang, Iwen Evelyn <iwen.evelyn.wang@intel.com>
> Sent: Friday, January 10, 2020 6:15 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
> 
> The function has NO comment immediately preceding it.
> Need to remove the space between the function and the comment
> 
> Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
> Cc: Jenny Huang <jenny.huang@intel.com>
> Cc: More Shih <more.shih@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> 
> ---
> In V1:
> Add a issue description
> ---
>  Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> index ebfe904053..86c519f48d 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> @@ -13,7 +13,6 @@
>    Get the global VT-d protected memory alignment.
>    @return The maximum protected memory alignment. Ex: 0x100000
>  **/
> -
>  UINTN
>  EFIAPI
>  GetGlobalVtdPmrAlignment (
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53099): https://edk2.groups.io/g/devel/message/53099
Mute This Topic: https://groups.io/mt/69589399/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

Posted by Chaganty, Rangasai V 4 years, 3 months ago

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Wang, Iwen Evelyn <iwen.evelyn.wang@intel.com> 
Sent: Thursday, January 09, 2020 2:15 PM
To: devel@edk2.groups.io
Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

The function has NO comment immediately preceding it.
Need to remove the space between the function and the comment

Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: More Shih <more.shih@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>

---
In V1:
Add a issue description
---
 Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
index ebfe904053..86c519f48d 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmen
+++ tLib.h
@@ -13,7 +13,6 @@
   Get the global VT-d protected memory alignment.
   @return The maximum protected memory alignment. Ex: 0x100000  **/
-
 UINTN
 EFIAPI
 GetGlobalVtdPmrAlignment (
--
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53097): https://edk2.groups.io/g/devel/message/53097
Mute This Topic: https://groups.io/mt/69589399/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-