[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

Dong, Eric posted 1 patch 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200109052641.767-1-eric.dong@intel.com
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
1 file changed, 2 insertions(+)

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

Posted by Dong, Eric 1 week ago
This issue caused by below change:
  SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
  * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
  REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 35a6996ba3..c285a70ebb 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -1142,6 +1142,8 @@ FindFirstFreeToken (
 
   If no free token, allocate new tokens then return the free one.
 
+  @param RunningApsCount    The Running Aps count for this token.
+
   @retval    return the first free PROCEDURE_TOKEN.
 
 **/
-- 
2.23.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53046): https://edk2.groups.io/g/devel/message/53046
Mute This Topic: https://groups.io/mt/69569495/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

Posted by Ni, Ray 1 week ago
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dong, Eric
> Sent: Thursday, January 9, 2020 1:27 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
> 
> This issue caused by below change:
>   SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
>   * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
>   REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 35a6996ba3..c285a70ebb 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1142,6 +1142,8 @@ FindFirstFreeToken (
> 
> 
>    If no free token, allocate new tokens then return the free one.
> 
> 
> 
> +  @param RunningApsCount    The Running Aps count for this token.
> 
> +
> 
>    @retval    return the first free PROCEDURE_TOKEN.
> 
> 
> 
>  **/
> 
> --
> 2.23.0.windows.1
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#53046): https://edk2.groups.io/g/devel/message/53046
> Mute This Topic: https://groups.io/mt/69569495/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [ray.ni@intel.com]
> -=-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53106): https://edk2.groups.io/g/devel/message/53106
Mute This Topic: https://groups.io/mt/69569495/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

Posted by Laszlo Ersek 1 week ago
On 01/09/20 06:26, Eric Dong wrote:
> This issue caused by below change:
>   SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
>   * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
>   REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 35a6996ba3..c285a70ebb 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1142,6 +1142,8 @@ FindFirstFreeToken (
>  
>    If no free token, allocate new tokens then return the free one.
>  
> +  @param RunningApsCount    The Running Aps count for this token.
> +
>    @retval    return the first free PROCEDURE_TOKEN.
>  
>  **/
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53084): https://edk2.groups.io/g/devel/message/53084
Mute This Topic: https://groups.io/mt/69569495/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-