[edk2-devel] [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements

Pete Batard posted 2 patches 30 weeks ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 20 ++++++++++++--------
Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |  2 ++
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         |  5 +++--
3 files changed, 17 insertions(+), 10 deletions(-)

[edk2-devel] [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements

Posted by Pete Batard 30 weeks ago
This series of patches improves the reporting of the firmware version
and platform serial number for the Raspberry Pi platforms.

Since there is only so much we can do with 16 bits and the firmware revision
reported by the VideoCore mailbox is really a timestamp of when the VC
firmware was build, we convert it to a YY.MM revision, which should be good
enough for our purpose, which is indicational and end-user readable.

A serial number fix is also needed as RPi4 platforms appear to report
0x0000000010000000 as the board serial, so the case where we fell back to
the MAC address when the board serial is 0 needs to be amended.

Pete Batard (2):
  Platform/RPi/SmbiosDxe: Report a more human readable firmware revision
  Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4

 Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 20 ++++++++++++--------
 Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |  2 ++
 Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         |  5 +++--
 3 files changed, 17 insertions(+), 10 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53027): https://edk2.groups.io/g/devel/message/53027
Mute This Topic: https://groups.io/mt/69532222/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements

Posted by Ard Biesheuvel 25 weeks ago
On Wed, 8 Jan 2020 at 18:00, Pete Batard <pete@akeo.ie> wrote:
>
> This series of patches improves the reporting of the firmware version
> and platform serial number for the Raspberry Pi platforms.
>
> Since there is only so much we can do with 16 bits and the firmware revision
> reported by the VideoCore mailbox is really a timestamp of when the VC
> firmware was build, we convert it to a YY.MM revision, which should be good
> enough for our purpose, which is indicational and end-user readable.
>
> A serial number fix is also needed as RPi4 platforms appear to report
> 0x0000000010000000 as the board serial, so the case where we fell back to
> the MAC address when the board serial is 0 needs to be amended.
>
> Pete Batard (2):
>   Platform/RPi/SmbiosDxe: Report a more human readable firmware revision
>   Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 314c45bc620b..9369b01e86ad

Thanks!


>  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   | 20 ++++++++++++--------
>  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |  2 ++
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         |  5 +++--
>  3 files changed, 17 insertions(+), 10 deletions(-)
>
> --
> 2.21.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54436): https://edk2.groups.io/g/devel/message/54436
Mute This Topic: https://groups.io/mt/69532222/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-