[edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements

Pete Batard posted 7 patches 4 years, 4 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf    |   3 +
Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c   |   8 ++
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h           |  12 +-
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf         |   8 +-
Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc              |  42 +++---
Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc              | 105 +++++++++++++--
Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl               |   1 +
Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc              |  99 ++++++++++----
Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc              |  30 ++---
Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc              |  11 +-
Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                |   4 +-
Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                  |   6 +-
Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                  |   8 +-
Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl               |  48 -------
Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc              |  96 ++++++++++++++
Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl               |   6 +-
Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl               | 137 ++++++++++++++++++++
Platform/RaspberryPi/RPi4/RPi4.dsc                          |  29 +++++
Platform/RaspberryPi/RPi4/RPi4.fdf                          |   7 +
Platform/RaspberryPi/RPi4/Readme.md                         |  52 ++++++--
Platform/RaspberryPi/RaspberryPi.dec                        |   3 +
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h |  17 ++-
22 files changed, 570 insertions(+), 162 deletions(-)
delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc
create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl
[edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements
Posted by Pete Batard 4 years, 4 months ago
Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348):
* Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use
  those in the SPCR and DBG2 tables
* Use default values in FADT wherever possible
* Drop MCFG table
* Improve computation of MMIO window in XHCI table
* Improve/clarify macro definitions in XHCI table
* Fix a typo in one of the new sections from the Readme

Andrei Warkentin (1):
  Platform/RPi4: Add XHCI ACPI table

Ard Biesheuvel (1):
  Platform/RPi4: Add ACPI basic mode build option

Pete Batard (5):
  Silicon/Bcm283x: Add UART constants for PL011 and miniUART
  Platform/RPi4: Clean up ACPI definitions
  Platform/RPi4: Improve FADT ACPI table generation
  Platform/RPi4: Improve SPCR and DBG2 ACPI table generation
  Platform/RPi4: Add switch to select between PL011 and miniUART

 Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf    |   3 +
 Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c   |   8 ++
 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h           |  12 +-
 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf         |   8 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc              |  42 +++---
 Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc              | 105 +++++++++++++--
 Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl               |   1 +
 Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc              |  99 ++++++++++----
 Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc              |  30 ++---
 Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc              |  11 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                |   4 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                  |   6 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                  |   8 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl               |  48 -------
 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc              |  96 ++++++++++++++
 Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl               |   6 +-
 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl               | 137 ++++++++++++++++++++
 Platform/RaspberryPi/RPi4/RPi4.dsc                          |  29 +++++
 Platform/RaspberryPi/RPi4/RPi4.fdf                          |   7 +
 Platform/RaspberryPi/RPi4/Readme.md                         |  52 ++++++--
 Platform/RaspberryPi/RaspberryPi.dec                        |   3 +
 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h |  17 ++-
 22 files changed, 570 insertions(+), 162 deletions(-)
 delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
 create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc
 create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52405): https://edk2.groups.io/g/devel/message/52405
Mute This Topic: https://groups.io/mt/68829920/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements
Posted by Ard Biesheuvel 4 years, 4 months ago
On Thu, 19 Dec 2019 at 14:14, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348):
> * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use
>   those in the SPCR and DBG2 tables
> * Use default values in FADT wherever possible
> * Drop MCFG table
> * Improve computation of MMIO window in XHCI table
> * Improve/clarify macro definitions in XHCI table
> * Fix a typo in one of the new sections from the Readme
>
> Andrei Warkentin (1):
>   Platform/RPi4: Add XHCI ACPI table
>
> Ard Biesheuvel (1):
>   Platform/RPi4: Add ACPI basic mode build option
>
> Pete Batard (5):
>   Silicon/Bcm283x: Add UART constants for PL011 and miniUART
>   Platform/RPi4: Clean up ACPI definitions
>   Platform/RPi4: Improve FADT ACPI table generation
>   Platform/RPi4: Improve SPCR and DBG2 ACPI table generation
>   Platform/RPi4: Add switch to select between PL011 and miniUART
>

For the series
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 8187c6f35035..e9395c53ba2c

Thanks all


>  Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf    |   3 +
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c   |   8 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h           |  12 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf         |   8 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc              |  42 +++---
>  Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc              | 105 +++++++++++++--
>  Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl               |   1 +
>  Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc              |  99 ++++++++++----
>  Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc              |  30 ++---
>  Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc              |  11 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                |   4 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                  |   6 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                  |   8 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl               |  48 -------
>  Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc              |  96 ++++++++++++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl               |   6 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl               | 137 ++++++++++++++++++++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                          |  29 +++++
>  Platform/RaspberryPi/RPi4/RPi4.fdf                          |   7 +
>  Platform/RaspberryPi/RPi4/Readme.md                         |  52 ++++++--
>  Platform/RaspberryPi/RaspberryPi.dec                        |   3 +
>  Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h |  17 ++-
>  22 files changed, 570 insertions(+), 162 deletions(-)
>  delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl
>
> --
> 2.21.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52432): https://edk2.groups.io/g/devel/message/52432
Mute This Topic: https://groups.io/mt/68829920/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements
Posted by Pete Batard 4 years, 4 months ago
On 2019.12.19 16:55, Ard Biesheuvel wrote:
> On Thu, 19 Dec 2019 at 14:14, Pete Batard <pete@akeo.ie> wrote:
>>
>> Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348):
>> * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use
>>    those in the SPCR and DBG2 tables
>> * Use default values in FADT wherever possible
>> * Drop MCFG table
>> * Improve computation of MMIO window in XHCI table
>> * Improve/clarify macro definitions in XHCI table
>> * Fix a typo in one of the new sections from the Readme
>>
>> Andrei Warkentin (1):
>>    Platform/RPi4: Add XHCI ACPI table
>>
>> Ard Biesheuvel (1):
>>    Platform/RPi4: Add ACPI basic mode build option
>>
>> Pete Batard (5):
>>    Silicon/Bcm283x: Add UART constants for PL011 and miniUART
>>    Platform/RPi4: Clean up ACPI definitions
>>    Platform/RPi4: Improve FADT ACPI table generation
>>    Platform/RPi4: Improve SPCR and DBG2 ACPI table generation
>>    Platform/RPi4: Add switch to select between PL011 and miniUART
>>
> 
> For the series
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Pushed as 8187c6f35035..e9395c53ba2c

Awesome!

Can I ask for someone to please push 
https://edk2.groups.io/g/devel/topic/68154411#52131 as well, since it's 
been reviewed? This may become quite relevant for people playing with 
DEBUG versions of the Pi 4 firmware...

Thanks,

/Pete

> 
> Thanks all
> 
> 
>>   Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf    |   3 +
>>   Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c   |   8 ++
>>   Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h           |  12 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf         |   8 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc              |  42 +++---
>>   Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc              | 105 +++++++++++++--
>>   Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl               |   1 +
>>   Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc              |  99 ++++++++++----
>>   Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc              |  30 ++---
>>   Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc              |  11 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                |   4 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                  |   6 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                  |   8 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl               |  48 -------
>>   Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc              |  96 ++++++++++++++
>>   Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl               |   6 +-
>>   Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl               | 137 ++++++++++++++++++++
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                          |  29 +++++
>>   Platform/RaspberryPi/RPi4/RPi4.fdf                          |   7 +
>>   Platform/RaspberryPi/RPi4/Readme.md                         |  52 ++++++--
>>   Platform/RaspberryPi/RaspberryPi.dec                        |   3 +
>>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h |  17 ++-
>>   22 files changed, 570 insertions(+), 162 deletions(-)
>>   delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
>>   create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc
>>   create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl
>>
>> --
>> 2.21.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52434): https://edk2.groups.io/g/devel/message/52434
Mute This Topic: https://groups.io/mt/68829920/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-