MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

[edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Liming Gao 4 years, 4 months ago

From: Daniel Pawel Banaszek <daniel.pawel.banaszek@intel.com>

Device Control 2 Structure have an issue.
 LtrMechanism - there is 2 bits instead of 1.

Signed-off-by: Daniel Pawel Banaszek <daniel.pawel.banaszek@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdePkg/Include/IndustryStandard/PciExpress21.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h b/MdePkg/Include/IndustryStandard/PciExpress21.h
index f17f570775..2c07cb560e 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
@@ -304,7 +304,7 @@ typedef union {
     UINT16 AtomicOpEgressBlocking : 1;
     UINT16 IdoRequest : 1;
     UINT16 IdoCompletion : 1;
-    UINT16 LtrMechanism : 2;
+    UINT16 LtrMechanism : 1;
     UINT16 EmergencyPowerReductionRequest : 1;
     UINT16 TenBitTagRequesterEnable : 1;
     UINT16 Obff : 2;
-- 
2.13.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52350): https://edk2.groups.io/g/devel/message/52350
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Javeed, Ashraf 4 years, 4 months ago

Good catch!
Please rename the LtrMechanism to LtrMechanismEnable to match with the PCI Base Specification.
Thanks

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52355): https://edk2.groups.io/g/devel/message/52355
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Javeed, Ashraf 4 years, 4 months ago

I want to withdraw my request as by renaming it would cause build failures in the code that is already using this register definition.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52356): https://edk2.groups.io/g/devel/message/52356
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Liming Gao 4 years, 4 months ago

Yes. We keep the same name to avoid the incompatible issue.

Thanks
Liming
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed, Ashraf
Sent: Wednesday, December 18, 2019 10:55 PM
To: Javeed; Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

I want to withdraw my request as by renaming it would cause build failures in the code that is already using this register definition.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52358): https://edk2.groups.io/g/devel/message/52358
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Ni, Ray 4 years, 4 months ago

Reviewed-by: Ray Ni <ray.ni@intel.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52395): https://edk2.groups.io/g/devel/message/52395
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Posted by Liming Gao 4 years, 4 months ago

Merge @665afccc52e1a02ee329147e02f04b8e9cf1d571

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, December 19, 2019 10:22 AM
To: Gao; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits


Reviewed-by: Ray Ni ray.ni@intel.com<mailto:ray.ni@intel.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52430): https://edk2.groups.io/g/devel/message/52430
Mute This Topic: https://groups.io/mt/68796766/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-