New implementation of MM communicate for standalone MM

[edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Ard Biesheuvel 4 years, 4 months ago

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

This series implements the changes proposed by Mantis ticket 1993, which
describes how we need to modify the MM communicate protocol to make it
compatible with standalone MM based DXE_RUNTIME_DRIVER MM client using
virtually remapped memory.

These changes have been accepted as errata for PI spec v1.7

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Achin Gupta <achin.gupta@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>

Ard Biesheuvel (7):
  MdePkg: introduce MM communicate 2 protocol
  MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
  ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
  MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
  MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
    protocol
  MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
    protocol
  StandaloneMmPkg: switch to MM communicate 2 protocol

 .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
 .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
 .../Application/VariableInfo/VariableInfo.c   | 19 +++--
 .../Application/VariableInfo/VariableInfo.inf |  2 +-
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
 MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
 .../FaultTolerantWriteSmmCommon.h             |  2 +-
 .../FaultTolerantWriteSmmDxe.c                | 25 +++---
 .../FaultTolerantWriteSmmDxe.h                |  2 +-
 .../FaultTolerantWriteSmmDxe.inf              |  4 +-
 .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
 .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
 MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
 MdePkg/MdePkg.dec                             |  7 ++
 StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
 .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
 17 files changed, 254 insertions(+), 94 deletions(-)
 create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51978): https://edk2.groups.io/g/devel/message/51978
Mute This Topic: https://groups.io/mt/67497114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Ard Biesheuvel 4 years, 3 months ago

On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
>
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> This series implements the changes proposed by Mantis ticket 1993, which
> describes how we need to modify the MM communicate protocol to make it
> compatible with standalone MM based DXE_RUNTIME_DRIVER MM client using
> virtually remapped memory.
>
> These changes have been accepted as errata for PI spec v1.7
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>

Ping?


> Ard Biesheuvel (7):
>   MdePkg: introduce MM communicate 2 protocol
>   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
>   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
>   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
>   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
>     protocol
>   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
>     protocol
>   StandaloneMmPkg: switch to MM communicate 2 protocol
>
>  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
>  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
>  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
>  .../Application/VariableInfo/VariableInfo.inf |  2 +-
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
>  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
>  .../FaultTolerantWriteSmmCommon.h             |  2 +-
>  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
>  .../FaultTolerantWriteSmmDxe.h                |  2 +-
>  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
>  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
>  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
>  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
>  MdePkg/MdePkg.dec                             |  7 ++
>  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
>  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
>  17 files changed, 254 insertions(+), 94 deletions(-)
>  create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
>
> --
> 2.17.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52824): https://edk2.groups.io/g/devel/message/52824
Mute This Topic: https://groups.io/mt/67497114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Liming Gao 4 years, 3 months ago

Ard:
 The changes are good to me. But, I think this change will not be added into MdePkg until PI1.7 errata A is published.  

Thanks
Liming
-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org> 
Sent: 2020年1月3日 21:03
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
>
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> This series implements the changes proposed by Mantis ticket 1993, 
> which describes how we need to modify the MM communicate protocol to 
> make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM 
> client using virtually remapped memory.
>
> These changes have been accepted as errata for PI spec v1.7
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>

Ping?


> Ard Biesheuvel (7):
>   MdePkg: introduce MM communicate 2 protocol
>   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
>   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
>   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
>   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
>     protocol
>   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
>     protocol
>   StandaloneMmPkg: switch to MM communicate 2 protocol
>
>  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
>  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
>  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
>  .../Application/VariableInfo/VariableInfo.inf |  2 +-
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
>  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
>  .../FaultTolerantWriteSmmCommon.h             |  2 +-
>  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
>  .../FaultTolerantWriteSmmDxe.h                |  2 +-
>  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
>  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
>  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
>  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
>  MdePkg/MdePkg.dec                             |  7 ++
>  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
>  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
>  17 files changed, 254 insertions(+), 94 deletions(-)  create mode 
> 100644 MdePkg/Include/Protocol/MmCommunication2.h
>
> --
> 2.17.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52854): https://edk2.groups.io/g/devel/message/52854
Mute This Topic: https://groups.io/mt/67497114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Ard Biesheuvel 4 years, 1 month ago

(adding PIWG and some other folks to cc)

On Mon, 6 Jan 2020 at 02:16, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>  The changes are good to me. But, I think this change will not be added into MdePkg until PI1.7 errata A is published.
>

Hello all,

Due to the Huawei situation, and now the fact that there is little
movement in the PIWG, these changes have been in limbo for over a year
now.

Is there any way we can progress with this independently? Or push on
with the publication of PI 1.7 errata A ?

Thanks,
Ard.



> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: 2020年1月3日 21:03
> To: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [PATCH 0/7] New implementation of MM communicate for standalone MM
>
> On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
> >
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > This series implements the changes proposed by Mantis ticket 1993,
> > which describes how we need to modify the MM communicate protocol to
> > make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM
> > client using virtually remapped memory.
> >
> > These changes have been accepted as errata for PI spec v1.7
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Achin Gupta <achin.gupta@arm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
>
> Ping?
>
>
> > Ard Biesheuvel (7):
> >   MdePkg: introduce MM communicate 2 protocol
> >   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
> >   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
> >   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
> >   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
> >     protocol
> >   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
> >     protocol
> >   StandaloneMmPkg: switch to MM communicate 2 protocol
> >
> >  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
> >  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
> >  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
> >  .../Application/VariableInfo/VariableInfo.inf |  2 +-
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
> >  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
> >  .../FaultTolerantWriteSmmCommon.h             |  2 +-
> >  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
> >  .../FaultTolerantWriteSmmDxe.h                |  2 +-
> >  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
> >  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
> >  MdePkg/MdePkg.dec                             |  7 ++
> >  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
> >  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
> >  17 files changed, 254 insertions(+), 94 deletions(-)  create mode
> > 100644 MdePkg/Include/Protocol/MmCommunication2.h
> >
> > --
> > 2.17.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55591): https://edk2.groups.io/g/devel/message/55591
Mute This Topic: https://groups.io/mt/67497114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Doran, Mark 4 years, 1 month ago

Apologies for the delay -- I just found this by accident looking at the PIWG email archive for something else which prompted me to find the note below in the spam trap for some reason.  Anyhow...

UEFI spec publications and errata are kind of demand-driven - we don't keep a regular schedule so much as make one for an errata or new spec version when a contributor requests that they want one to meet a product deliverable or some equivalent external event that needs to read on an update.  Lazy evaluation if you will.

Which is to say right now there isn't a PI 1.7A schedule but we can make one 😊  

To be sure we have this right is there one specific PI ECR we're talking about or more than one for this??  If we can identify which peg we need put into an errata version to hang these code changes from then I can get with Vincent and we can have the work group crank this handle.

That said...

The one caveat that applies right this second is that the conversion of the spec sources is in flight.  Our tech writer may tell me that there are some related limitations on when exactly we can practically make an update.  I don't want to pollute the open lists copied here with that UEFI Forum internal housekeeping but I did want to mention that as a factor by way of not wanting to over-promise an instant fix.

--
Cheers,

Mark.

-----Original Message-----
From: piwg@uefi.org <piwg@uefi.org> On Behalf Of Ard Biesheuvel
Sent: Friday, March 6, 2020 2:38 AM
To: Gao, Liming <liming.gao@intel.com>; Stuart Yoder <Stuart.Yoder@arm.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; piwg@uefi.org
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

(adding PIWG and some other folks to cc)

On Mon, 6 Jan 2020 at 02:16, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>  The changes are good to me. But, I think this change will not be added into MdePkg until PI1.7 errata A is published.
>

Hello all,

Due to the Huawei situation, and now the fact that there is little movement in the PIWG, these changes have been in limbo for over a year now.

Is there any way we can progress with this independently? Or push on with the publication of PI 1.7 errata A ?

Thanks,
Ard.



> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: 2020年1月3日 21:03
> To: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Leif Lindholm 
> <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Wu, 
> Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray 
> <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen 
> <jiewen.yao@intel.com>
> Subject: Re: [PATCH 0/7] New implementation of MM communicate for 
> standalone MM
>
> On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
> >
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > This series implements the changes proposed by Mantis ticket 1993, 
> > which describes how we need to modify the MM communicate protocol to 
> > make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM 
> > client using virtually remapped memory.
> >
> > These changes have been accepted as errata for PI spec v1.7
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Achin Gupta <achin.gupta@arm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
>
> Ping?
>
>
> > Ard Biesheuvel (7):
> >   MdePkg: introduce MM communicate 2 protocol
> >   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
> >   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
> >   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
> >   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
> >     protocol
> >   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
> >     protocol
> >   StandaloneMmPkg: switch to MM communicate 2 protocol
> >
> >  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
> >  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
> >  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
> >  .../Application/VariableInfo/VariableInfo.inf |  2 +-
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
> >  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
> >  .../FaultTolerantWriteSmmCommon.h             |  2 +-
> >  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
> >  .../FaultTolerantWriteSmmDxe.h                |  2 +-
> >  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
> >  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
> >  MdePkg/MdePkg.dec                             |  7 ++
> >  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
> >  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
> >  17 files changed, 254 insertions(+), 94 deletions(-)  create mode
> > 100644 MdePkg/Include/Protocol/MmCommunication2.h
> >
> > --
> > 2.17.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55769): https://edk2.groups.io/g/devel/message/55769
Mute This Topic: https://groups.io/mt/71885159/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Ard Biesheuvel 4 years, 1 month ago

thanks Mark

this is about mantis ticket 1993, which is a prerequisite for building
anything based on standalone mm that involves a va switch at runtime

i don't care deeply about the pace at which things move, as long as they
move at all, so I'm happy to settle for whatever is workable for the
editorial team


On Wed, Mar 11, 2020, 14:12 Doran, Mark <mark.doran@intel.com> wrote:

> Apologies for the delay -- I just found this by accident looking at the
> PIWG email archive for something else which prompted me to find the note
> below in the spam trap for some reason.  Anyhow...
>
> UEFI spec publications and errata are kind of demand-driven - we don't
> keep a regular schedule so much as make one for an errata or new spec
> version when a contributor requests that they want one to meet a product
> deliverable or some equivalent external event that needs to read on an
> update.  Lazy evaluation if you will.
>
> Which is to say right now there isn't a PI 1.7A schedule but we can make
> one 😊
>
> To be sure we have this right is there one specific PI ECR we're talking
> about or more than one for this??  If we can identify which peg we need put
> into an errata version to hang these code changes from then I can get with
> Vincent and we can have the work group crank this handle.
>
> That said...
>
> The one caveat that applies right this second is that the conversion of
> the spec sources is in flight.  Our tech writer may tell me that there are
> some related limitations on when exactly we can practically make an
> update.  I don't want to pollute the open lists copied here with that UEFI
> Forum internal housekeeping but I did want to mention that as a factor by
> way of not wanting to over-promise an instant fix.
>
> --
> Cheers,
>
> Mark.
>
> -----Original Message-----
> From: piwg@uefi.org <piwg@uefi.org> On Behalf Of Ard Biesheuvel
> Sent: Friday, March 6, 2020 2:38 AM
> To: Gao, Liming <liming.gao@intel.com>; Stuart Yoder <Stuart.Yoder@arm.com>;
> Zimmer, Vincent <vincent.zimmer@intel.com>; piwg@uefi.org
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; edk2-devel-groups-io <
> devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Wu, Hao A <hao.a.wu@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta
> <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [piwg] Re: [PATCH 0/7] New implementation of MM communicate for
> standalone MM
>
> (adding PIWG and some other folks to cc)
>
> On Mon, 6 Jan 2020 at 02:16, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > Ard:
> >  The changes are good to me. But, I think this change will not be added
> into MdePkg until PI1.7 errata A is published.
> >
>
> Hello all,
>
> Due to the Huawei situation, and now the fact that there is little
> movement in the PIWG, these changes have been in limbo for over a year now.
>
> Is there any way we can progress with this independently? Or push on with
> the publication of PI 1.7 errata A ?
>
> Thanks,
> Ard.
>
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Sent: 2020年1月3日 21:03
> > To: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Leif Lindholm
> > <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Wu,
> > Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>
> > Subject: Re: [PATCH 0/7] New implementation of MM communicate for
> > standalone MM
> >
> > On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com>
> wrote:
> > >
> > > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > This series implements the changes proposed by Mantis ticket 1993,
> > > which describes how we need to modify the MM communicate protocol to
> > > make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM
> > > client using virtually remapped memory.
> > >
> > > These changes have been accepted as errata for PI spec v1.7
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Eric Dong <eric.dong@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Achin Gupta <achin.gupta@arm.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > >
> >
> > Ping?
> >
> >
> > > Ard Biesheuvel (7):
> > >   MdePkg: introduce MM communicate 2 protocol
> > >   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
> > >   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
> > >   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
> > >   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
> > >     protocol
> > >   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
> > >     protocol
> > >   StandaloneMmPkg: switch to MM communicate 2 protocol
> > >
> > >  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
> > >  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
> > >  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
> > >  .../Application/VariableInfo/VariableInfo.inf |  2 +-
> > >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
> > >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
> > >  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
> > >  .../FaultTolerantWriteSmmCommon.h             |  2 +-
> > >  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
> > >  .../FaultTolerantWriteSmmDxe.h                |  2 +-
> > >  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
> > >  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
> > >  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
> > >  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
> > >  MdePkg/MdePkg.dec                             |  7 ++
> > >  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
> > >  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
> > >  17 files changed, 254 insertions(+), 94 deletions(-)  create mode
> > > 100644 MdePkg/Include/Protocol/MmCommunication2.h
> > >
> > > --
> > > 2.17.1
> > >
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55770): https://edk2.groups.io/g/devel/message/55770
Mute This Topic: https://groups.io/mt/71885159/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

Posted by Shaw, Kevin W 4 years, 1 month ago

I haven't started the conversion work for the PI spec, so we can do an errata update promptly if we decide on that soon (say by end of March).  

- Kevin

-----Original Message-----
From: piwg@uefi.org <piwg@uefi.org> On Behalf Of Doran, Mark
Sent: Wednesday, March 11, 2020 11:12 AM
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Gao, Liming <liming.gao@intel.com>; Stuart Yoder <Stuart.Yoder@arm.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; piwg@uefi.org
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: RE: [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

Apologies for the delay -- I just found this by accident looking at the PIWG email archive for something else which prompted me to find the note below in the spam trap for some reason.  Anyhow...

UEFI spec publications and errata are kind of demand-driven - we don't keep a regular schedule so much as make one for an errata or new spec version when a contributor requests that they want one to meet a product deliverable or some equivalent external event that needs to read on an update.  Lazy evaluation if you will.

Which is to say right now there isn't a PI 1.7A schedule but we can make one 😊  

To be sure we have this right is there one specific PI ECR we're talking about or more than one for this??  If we can identify which peg we need put into an errata version to hang these code changes from then I can get with Vincent and we can have the work group crank this handle.

That said...

The one caveat that applies right this second is that the conversion of the spec sources is in flight.  Our tech writer may tell me that there are some related limitations on when exactly we can practically make an update.  I don't want to pollute the open lists copied here with that UEFI Forum internal housekeeping but I did want to mention that as a factor by way of not wanting to over-promise an instant fix.

--
Cheers,

Mark.

-----Original Message-----
From: piwg@uefi.org <piwg@uefi.org> On Behalf Of Ard Biesheuvel
Sent: Friday, March 6, 2020 2:38 AM
To: Gao, Liming <liming.gao@intel.com>; Stuart Yoder <Stuart.Yoder@arm.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; piwg@uefi.org
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: [piwg] Re: [PATCH 0/7] New implementation of MM communicate for standalone MM

(adding PIWG and some other folks to cc)

On Mon, 6 Jan 2020 at 02:16, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>  The changes are good to me. But, I think this change will not be added into MdePkg until PI1.7 errata A is published.
>

Hello all,

Due to the Huawei situation, and now the fact that there is little movement in the PIWG, these changes have been in limbo for over a year now.

Is there any way we can progress with this independently? Or push on with the publication of PI 1.7 errata A ?

Thanks,
Ard.



> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: 2020年1月3日 21:03
> To: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Leif Lindholm 
> <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Wu, 
> Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray 
> <ray.ni@intel.com>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen 
> <jiewen.yao@intel.com>
> Subject: Re: [PATCH 0/7] New implementation of MM communicate for 
> standalone MM
>
> On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
> >
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > This series implements the changes proposed by Mantis ticket 1993, 
> > which describes how we need to modify the MM communicate protocol to 
> > make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM 
> > client using virtually remapped memory.
> >
> > These changes have been accepted as errata for PI spec v1.7
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Achin Gupta <achin.gupta@arm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
>
> Ping?
>
>
> > Ard Biesheuvel (7):
> >   MdePkg: introduce MM communicate 2 protocol
> >   MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
> >   ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
> >   MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
> >   MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
> >     protocol
> >   MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
> >     protocol
> >   StandaloneMmPkg: switch to MM communicate 2 protocol
> >
> >  .../MmCommunicationDxe/MmCommunication.c      | 79 +++++++++----------
> >  .../MmCommunicationDxe/MmCommunication.inf    |  6 +-
> >  .../Application/VariableInfo/VariableInfo.c   | 19 +++--
> >  .../Application/VariableInfo/VariableInfo.inf |  2 +-
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        | 79 +++++++++++++++++++
> >  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      |  1 +
> >  MdeModulePkg/Include/Guid/SmmVariableCommon.h |  6 +-
> >  .../FaultTolerantWriteSmmCommon.h             |  2 +-
> >  .../FaultTolerantWriteSmmDxe.c                | 25 +++---
> >  .../FaultTolerantWriteSmmDxe.h                |  2 +-
> >  .../FaultTolerantWriteSmmDxe.inf              |  4 +-
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 39 ++++-----
> >  .../RuntimeDxe/VariableSmmRuntimeDxe.inf      |  4 +-
> >  MdePkg/Include/Protocol/MmCommunication2.h    | 69 ++++++++++++++++
> >  MdePkg/MdePkg.dec                             |  7 ++
> >  StandaloneMmPkg/Core/StandaloneMmCore.h       |  2 +-
> >  .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |  2 +-
> >  17 files changed, 254 insertions(+), 94 deletions(-)  create mode
> > 100644 MdePkg/Include/Protocol/MmCommunication2.h
> >
> > --
> > 2.17.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55773): https://edk2.groups.io/g/devel/message/55773
Mute This Topic: https://groups.io/mt/71885159/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-