[edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin

Philippe Mathieu-Daudé posted 105 patches 6 years, 2 months ago
There is a newer version of this series
[edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin
Posted by Philippe Mathieu-Daudé 6 years, 2 months ago
We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Yu-Chen Lin to have his name and email address
displayed properly in the git history.

Cc: Yu-Chen Lin <yuchenlin@synology.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
 named developers in the cover. Therefore I'm adapting the explaination
 from the cover in each patch]

This patch won't get merged if Yu-Chen Lin doesn't give his
approval, by replying to this patch with:
  Reviewed-by: Yu-Chen Lin <yuchenlin@synology.com>

If you think this patch is inappropriate, you don't need to justify,
reply with:
  NAcked-by: Yu-Chen Lin <yuchenlin@synology.com>
or simply:
  NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
 .mailmap | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index dc0e59705f6c..1e385f7591c2 100644
--- a/.mailmap
+++ b/.mailmap
@@ -196,3 +196,4 @@ Yeh Greg <gregx.yeh@intel.com> GregX Yeh <devel@edk2.groups.io>
 Yingke Liu <yingke.d.liu@intel.com> <yingke@Edk2>
 Yonghong Zhu <yonghong.zhu@intel.com>
 Yonghong Zhu <yonghong.zhu@intel.com> <yzhu52@Edk2>
+Yu-Chen Lin <yuchenlin@synology.com>
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51953): https://edk2.groups.io/g/devel/message/51953
Mute This Topic: https://groups.io/mt/67468846/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin
Posted by yuchenlin via Groups.Io 6 years, 2 months ago
Hi, Cool, it is a good idea for mapping this. However, I have two mail address, named npes87184@gmail.com and yuchenlin@synology.com (mailto:yuchenlin@synology.com) IMO, the entry should be diff --git a/.mailmap b/.mailmap index 3816e4effe..3fbf3902a3 100644 --- a/.mailmap +++ b/.mailmap @@ -151,7 +151,8 @@ Xiaoqiang Zhao <zxq_yx_007@163.com> Xinhua Cao <caoxinhua@huawei.com> Xiong Zhang <xiong.y.zhang@intel.com> Yin Yin <yin.yin@cs2c.com.cn> -yuchenlin <npes87184@gmail.com> +Yu-Chen Lin <npes87184@gmail.com> +Yu-Chen Lin <npes87184@gmail.com> <yuchenlin@synology.com> YunQiang Su <syq@debian.org> YunQiang Su <ysu@wavecomp.com> Yuri Pudgorodskiy <yur@virtuozzo.com> And the final output of `git shortlog -s -n -e | grep Yu-Chen` will be 12 Yu-Chen Lin <npes87184@gmail.com> It is correct! Thank you -- Best Regards, Yu-Chen Lin Philippe Mathieu-Daude <philmd@redhat.com> 於 2019-12-06 21:03 寫道: > > We use .mailmap to display contributors email addresses in an > uniform format. > > Add an entry for Yu-Chen Lin to have his name and email address > displayed properly in the git history. > > Cc: Yu-Chen Lin <yuchenlin@synology.com> > Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com> > --- > [Due to MTA restricting the recipient list to 100, I can not Cc all the > named developers in the cover. Therefore I'm adapting the explaination > from the cover in each patch] > > This patch won't get merged if Yu-Chen Lin doesn't give his > approval, by replying to this patch with: > Reviewed-by: Yu-Chen Lin <yuchenlin@synology.com> > > If you think this patch is inappropriate, you don't need to justify, > reply with: > NAcked-by: Yu-Chen Lin <yuchenlin@synology.com> > or simply: > NACK > > If your Firstname Lastname order is incorrect, tell me and I will fix it. > > You can also ignore this mail, but I might resend it and keep bothering > you. > > Regards, > > Phil. > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap b/.mailmap > index dc0e59705f6c..1e385f7591c2 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -196,3 +196,4 @@ Yeh Greg <gregx.yeh@intel.com> GregX Yeh <devel@edk2.groups.io> > Yingke Liu <yingke.d.liu@intel.com> <yingke@Edk2> > Yonghong Zhu <yonghong.zhu@intel.com> > Yonghong Zhu <yonghong.zhu@intel.com> <yzhu52@Edk2> > +Yu-Chen Lin <yuchenlin@synology.com> > -- > 2.21.0 >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51958): https://edk2.groups.io/g/devel/message/51958
Mute This Topic: https://groups.io/mt/67468846/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin
Posted by yuchenlin via Groups.Io 6 years, 2 months ago
Oops, please ignore my last mail... I mistakenly think this patch is about qemu mailmap. In edk2, I am ok for this patch. Reviewed-by: Yu-Chen Lin <yuchenlin@synology.com> -- Best Regards, Yu-Chen Lin yuchenlin <yuchenlin@synology.com> 於 2019-12-06 21:59 寫道: > > Hi, > > > > Cool, it is a good idea for mapping this. > > However, I have two mail address, named npes87184@gmail.com and yuchenlin@synology.com (mailto:yuchenlin@synology.com) > > > > IMO, the entry should be > > > > diff --git a/.mailmap b/.mailmap > > index 3816e4effe..3fbf3902a3 100644 > > --- a/.mailmap > > +++ b/.mailmap > > @@ -151,7 +151,8 @@ Xiaoqiang Zhao <zxq_yx_007@163.com> > > Xinhua Cao <caoxinhua@huawei.com> > > Xiong Zhang <xiong.y.zhang@intel.com> > > Yin Yin <yin.yin@cs2c.com.cn> > > -yuchenlin <npes87184@gmail.com> > > +Yu-Chen Lin <npes87184@gmail.com> > > +Yu-Chen Lin <npes87184@gmail.com> <yuchenlin@synology.com> > > YunQiang Su <syq@debian.org> > > YunQiang Su <ysu@wavecomp.com> > > Yuri Pudgorodskiy <yur@virtuozzo.com> > > > > And the final output of `git shortlog -s -n -e | grep Yu-Chen` will be > > > > 12 Yu-Chen Lin <npes87184@gmail.com> > > > > It is correct! > > > > Thank you > > > -- > > Best Regards, > > Yu-Chen Lin > > > > > > Philippe Mathieu-Daude <philmd@redhat.com> 於 2019-12-06 21:03 寫道: > > > > > > We use .mailmap to display contributors email addresses in an > > uniform format. > > > > Add an entry for Yu-Chen Lin to have his name and email address > > displayed properly in the git history. > > > > Cc: Yu-Chen Lin <yuchenlin@synology.com> > > Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com> > > --- > > [Due to MTA restricting the recipient list to 100, I can not Cc all the > > named developers in the cover. Therefore I'm adapting the explaination > > from the cover in each patch] > > > > This patch won't get merged if Yu-Chen Lin doesn't give his > > approval, by replying to this patch with: > > Reviewed-by: Yu-Chen Lin <yuchenlin@synology.com> > > > > If you think this patch is inappropriate, you don't need to justify, > > reply with: > > NAcked-by: Yu-Chen Lin <yuchenlin@synology.com> > > or simply: > > NACK > > > > If your Firstname Lastname order is incorrect, tell me and I will fix it. > > > > You can also ignore this mail, but I might resend it and keep bothering > > you. > > > > Regards, > > > > Phil. > > --- > > .mailmap | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.mailmap b/.mailmap > > index dc0e59705f6c..1e385f7591c2 100644 > > --- a/.mailmap > > +++ b/.mailmap > > @@ -196,3 +196,4 @@ Yeh Greg <gregx.yeh@intel.com> GregX Yeh <devel@edk2.groups.io> > > Yingke Liu <yingke.d.liu@intel.com> <yingke@Edk2> > > Yonghong Zhu <yonghong.zhu@intel.com> > > Yonghong Zhu <yonghong.zhu@intel.com> <yzhu52@Edk2> > > +Yu-Chen Lin <yuchenlin@synology.com> > > -- > > 2.21.0 > > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51959): https://edk2.groups.io/g/devel/message/51959
Mute This Topic: https://groups.io/mt/67468846/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-