.../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + .../SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ------------ .../SynQuacer/Drivers/PlatformDxe/Optee.asl | 23 +++++ .../Drivers/PlatformDxe/PlatformDxe.c | 83 +++++++++++++++++++ .../Drivers/PlatformDxe/PlatformDxe.h | 2 + .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + 6 files changed, 111 insertions(+), 55 deletions(-) create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl
Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in the code in patch #2 to expose a SSDT with a device node describing OP-TEE when booting in ACPI mode and OP-TEE is present. Ard Biesheuvel (2): Silicon/SynQuacer/PlatformDxe: move EMMC SSDT handling to core routine Silicon/SynQuacer/PlatformDxe: add ACPI device node for OP-TEE if present .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + .../SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ------------ .../SynQuacer/Drivers/PlatformDxe/Optee.asl | 23 +++++ .../Drivers/PlatformDxe/PlatformDxe.c | 83 +++++++++++++++++++ .../Drivers/PlatformDxe/PlatformDxe.h | 2 + .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + 6 files changed, 111 insertions(+), 55 deletions(-) create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51507): https://edk2.groups.io/g/devel/message/51507 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > the code in patch #2 to expose a SSDT with a device node describing > OP-TEE when booting in ACPI mode and OP-TEE is present. If we need any more SSDTs for this platform in future, I'll probably start grumbling about refactoring away the per-table global variables, but I guess it would be a bit overkill at this point... For the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Ard Biesheuvel (2): > Silicon/SynQuacer/PlatformDxe: move EMMC SSDT handling to core routine > Silicon/SynQuacer/PlatformDxe: add ACPI device node for OP-TEE if > present > > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > .../SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ------------ > .../SynQuacer/Drivers/PlatformDxe/Optee.asl | 23 +++++ > .../Drivers/PlatformDxe/PlatformDxe.c | 83 +++++++++++++++++++ > .../Drivers/PlatformDxe/PlatformDxe.h | 2 + > .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + > 6 files changed, 111 insertions(+), 55 deletions(-) > create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl > > -- > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51510): https://edk2.groups.io/g/devel/message/51510 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > the code in patch #2 to expose a SSDT with a device node describing > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > If we need any more SSDTs for this platform in future, I'll probably > start grumbling about refactoring away the per-table global variables, > but I guess it would be a bit overkill at this point... > Yeah, the thought crossed my mind as well, but let's defer that to the next time. > For the series: > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks, > > Ard Biesheuvel (2): > > Silicon/SynQuacer/PlatformDxe: move EMMC SSDT handling to core routine > > Silicon/SynQuacer/PlatformDxe: add ACPI device node for OP-TEE if > > present > > > > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > > .../SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ------------ > > .../SynQuacer/Drivers/PlatformDxe/Optee.asl | 23 +++++ > > .../Drivers/PlatformDxe/PlatformDxe.c | 83 +++++++++++++++++++ > > .../Drivers/PlatformDxe/PlatformDxe.h | 2 + > > .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + > > 6 files changed, 111 insertions(+), 55 deletions(-) > > create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl > > > > -- > > 2.17.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51511): https://edk2.groups.io/g/devel/message/51511 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > > the code in patch #2 to expose a SSDT with a device node describing > > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > > > If we need any more SSDTs for this platform in future, I'll probably > > start grumbling about refactoring away the per-table global variables, > > but I guess it would be a bit overkill at this point... > > > > Yeah, the thought crossed my mind as well, but let's defer that to the > next time. > > > For the series: > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > Actually, I need to apply this on top --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c @@ -282,13 +282,16 @@ InstallAcpiTables ( return; } + if (mEmmcSsdtSize > 0) { Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize, &TableKey); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n", __FUNCTION__, Status)); } + } + if (mTos0SsdtSize > 0) { Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize, &TableKey); if (EFI_ERROR (Status)) { @@ -296,6 +299,7 @@ InstallAcpiTables ( __FUNCTION__, Status)); } } +} EFI_STATUS EFIAPI or we will call InstallAcpiTable() with a zero size if we're only installing one of the tables. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51519): https://edk2.groups.io/g/devel/message/51519 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote: > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > > > the code in patch #2 to expose a SSDT with a device node describing > > > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > > > > > If we need any more SSDTs for this platform in future, I'll probably > > > start grumbling about refactoring away the per-table global variables, > > > but I guess it would be a bit overkill at this point... > > > > > > > Yeah, the thought crossed my mind as well, but let's defer that to the > > next time. > > > > > For the series: > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > > > > > Actually, I need to apply this on top > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > @@ -282,13 +282,16 @@ InstallAcpiTables ( > return; > } > > + if (mEmmcSsdtSize > 0) { > Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize, > &TableKey); Indentation presumably added for clarity? > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n", > __FUNCTION__, Status)); > } > + } > > + if (mTos0SsdtSize > 0) { > Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize, > &TableKey); > if (EFI_ERROR (Status)) { > @@ -296,6 +299,7 @@ InstallAcpiTables ( > __FUNCTION__, Status)); > } > } > +} LGTM. Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > EFI_STATUS > EFIAPI > > or we will call InstallAcpiTable() with a zero size if we're only > installing one of the tables. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51528): https://edk2.groups.io/g/devel/message/51528 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, 2 Dec 2019 at 13:02, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote: > > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > > > > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > > > > the code in patch #2 to expose a SSDT with a device node describing > > > > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > > > > > > > If we need any more SSDTs for this platform in future, I'll probably > > > > start grumbling about refactoring away the per-table global variables, > > > > but I guess it would be a bit overkill at this point... > > > > > > > > > > Yeah, the thought crossed my mind as well, but let's defer that to the > > > next time. > > > > > > > For the series: > > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > > > > > > > > > Actually, I need to apply this on top > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > > @@ -282,13 +282,16 @@ InstallAcpiTables ( > > return; > > } > > > > + if (mEmmcSsdtSize > 0) { > > Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize, > > &TableKey); > > Indentation presumably added for clarity? > Yep > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n", > > __FUNCTION__, Status)); > > } > > + } > > > > + if (mTos0SsdtSize > 0) { > > Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize, > > &TableKey); > > if (EFI_ERROR (Status)) { > > @@ -296,6 +299,7 @@ InstallAcpiTables ( > > __FUNCTION__, Status)); > > } > > } > > +} > > LGTM. > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks, > > EFI_STATUS > > EFIAPI > > > > or we will call InstallAcpiTable() with a zero size if we're only > > installing one of the tables. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51532): https://edk2.groups.io/g/devel/message/51532 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, 2 Dec 2019 at 15:08, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Mon, 2 Dec 2019 at 13:02, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > > > On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote: > > > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > > > > > > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > > > > > the code in patch #2 to expose a SSDT with a device node describing > > > > > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > > > > > > > > > If we need any more SSDTs for this platform in future, I'll probably > > > > > start grumbling about refactoring away the per-table global variables, > > > > > but I guess it would be a bit overkill at this point... > > > > > > > > > > > > > Yeah, the thought crossed my mind as well, but let's defer that to the > > > > next time. > > > > > > > > > For the series: > > > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > > > > > > > > > > > > > Actually, I need to apply this on top > > > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > > > @@ -282,13 +282,16 @@ InstallAcpiTables ( > > > return; > > > } > > > > > > + if (mEmmcSsdtSize > 0) { > > > Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize, > > > &TableKey); > > > > Indentation presumably added for clarity? > > > > Yep > > > > if (EFI_ERROR (Status)) { > > > DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n", > > > __FUNCTION__, Status)); > > > } > > > + } > > > > > > + if (mTos0SsdtSize > 0) { > > > Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize, > > > &TableKey); > > > if (EFI_ERROR (Status)) { > > > @@ -296,6 +299,7 @@ InstallAcpiTables ( > > > __FUNCTION__, Status)); > > > } > > > } > > > +} > > > > LGTM. > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > > Thanks, > Pushed as 3688ab6500e2..c5a2065ee8c2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52072): https://edk2.groups.io/g/devel/message/52072 Mute This Topic: https://groups.io/mt/64339734/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.