[edk2-devel] [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors

Kubacki, Michael A posted 2 patches 1 week ago
Failed in applying to current master (apply log)
MdeModulePkg/Core/Pei/PeiMain.inf             | 10 +--
MdeModulePkg/Core/Pei/FwVol/FwVol.h           | 23 +++----
MdeModulePkg/Core/Pei/PeiMain.h               | 49 +++++++--------
MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++--
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++--------
MdeModulePkg/Core/Pei/FwVol/FwVol.c           | 64 ++++++++++----------
MdeModulePkg/Core/Pei/Hob/Hob.c               |  4 +-
MdeModulePkg/Core/Pei/Image/Image.c           | 10 +--
MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++---
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c       |  2 +-
MdeModulePkg/Core/Pei/Ppi/Ppi.c               |  4 +-
MdeModulePkg/Core/Pei/Security/Security.c     | 12 ++--
12 files changed, 132 insertions(+), 128 deletions(-)

[edk2-devel] [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors

Posted by Kubacki, Michael A 1 week ago
V2 Changes:
 * "The index of the FV to search." to "Index of the FV to search"
   in the "Instance" parameter of ProcessFvFile ()
 * Removed "in this FV format" in the function description of
   AddUnknownFormatFvInfo ()
 * Explicitly stated the implied subject noun in the commit message
   of patch 2/2

This patch series fixes grammatical errors in the PeiCore module.

Originally, this was sent as a single patch which received two
Reviewed-by responses:
https://edk2.groups.io/g/devel/message/50841

However, a suggestion was made to split the patch into syntactical
and semantical changes. That suggestion is implemented in this
series.

The Reviewed-by responses were not carried forward so the maintainers
can evaluate this series as a whole. The previous patch has been
dropped.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>

Michael Kubacki (2):
  MdeModulePkg PeiCore: Fix typos
  MdeModulePkg PeiCore: Improve comment semantics

 MdeModulePkg/Core/Pei/PeiMain.inf             | 10 +--
 MdeModulePkg/Core/Pei/FwVol/FwVol.h           | 23 +++----
 MdeModulePkg/Core/Pei/PeiMain.h               | 49 +++++++--------
 MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++--
 MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++--------
 MdeModulePkg/Core/Pei/FwVol/FwVol.c           | 64 ++++++++++----------
 MdeModulePkg/Core/Pei/Hob/Hob.c               |  4 +-
 MdeModulePkg/Core/Pei/Image/Image.c           | 10 +--
 MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++---
 MdeModulePkg/Core/Pei/PeiMain/PeiMain.c       |  2 +-
 MdeModulePkg/Core/Pei/Ppi/Ppi.c               |  4 +-
 MdeModulePkg/Core/Pei/Security/Security.c     | 12 ++--
 12 files changed, 132 insertions(+), 128 deletions(-)

-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51373): https://edk2.groups.io/g/devel/message/51373
Mute This Topic: https://groups.io/mt/62875486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors

Posted by Wang, Jian J 1 week ago
For this patch series,

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Thursday, November 28, 2019 3:58 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors
> 
> V2 Changes:
>  * "The index of the FV to search." to "Index of the FV to search"
>    in the "Instance" parameter of ProcessFvFile ()
>  * Removed "in this FV format" in the function description of
>    AddUnknownFormatFvInfo ()
>  * Explicitly stated the implied subject noun in the commit message
>    of patch 2/2
> 
> This patch series fixes grammatical errors in the PeiCore module.
> 
> Originally, this was sent as a single patch which received two
> Reviewed-by responses:
> https://edk2.groups.io/g/devel/message/50841
> 
> However, a suggestion was made to split the patch into syntactical
> and semantical changes. That suggestion is implemented in this
> series.
> 
> The Reviewed-by responses were not carried forward so the maintainers
> can evaluate this series as a whole. The previous patch has been
> dropped.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> 
> Michael Kubacki (2):
>   MdeModulePkg PeiCore: Fix typos
>   MdeModulePkg PeiCore: Improve comment semantics
> 
>  MdeModulePkg/Core/Pei/PeiMain.inf             | 10 +--
>  MdeModulePkg/Core/Pei/FwVol/FwVol.h           | 23 +++----
>  MdeModulePkg/Core/Pei/PeiMain.h               | 49 +++++++--------
>  MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++--
>  MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++--------
>  MdeModulePkg/Core/Pei/FwVol/FwVol.c           | 64 ++++++++++----------
>  MdeModulePkg/Core/Pei/Hob/Hob.c               |  4 +-
>  MdeModulePkg/Core/Pei/Image/Image.c           | 10 +--
>  MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++---
>  MdeModulePkg/Core/Pei/PeiMain/PeiMain.c       |  2 +-
>  MdeModulePkg/Core/Pei/Ppi/Ppi.c               |  4 +-
>  MdeModulePkg/Core/Pei/Security/Security.c     | 12 ++--
>  12 files changed, 132 insertions(+), 128 deletions(-)
> 
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51444): https://edk2.groups.io/g/devel/message/51444
Mute This Topic: https://groups.io/mt/62875486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-