ShellPkg/edit: typo "%d Lines Wrote"

[edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"

Posted by Heinrich Schuchardt 4 years, 4 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2379

When a file is saved in the edit command a status message L"%d Lines Wrote"
is displayed. The hexedit command suffers from the same typo.

Change the message to L"%d Lines Written".

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c   | 2 +-
 ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
index 12235e4e4b..71036a7487 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
@@ -1608,7 +1608,7 @@ FileBufferSave (
   //
   // set status string
   //
-  Str = CatSPrint (NULL, L"%d Lines Wrote", NumLines);
+  Str = CatSPrint (NULL, L"%d Lines Written", NumLines);
   if (Str == NULL) {
     return EFI_OUT_OF_RESOURCES;
   }
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
index b393f2a423..bb324ceafc 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
@@ -368,7 +368,7 @@ HFileImageSave (
   //
   // set status string
   //
-  Str = CatSPrint(NULL, L"%d Lines Wrote", NumLines);
+  Str = CatSPrint(NULL, L"%d Lines Written", NumLines);
   StatusBarSetStatusString (Str);
   FreePool (Str);
 
-- 
2.24.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51206): https://edk2.groups.io/g/devel/message/51206
Mute This Topic: https://groups.io/mt/61873155/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"

Posted by Gao, Zhichao 4 years, 4 months ago

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Heinrich Schuchardt
> Sent: Sunday, November 24, 2019 6:33 PM
> To: EDK II Development <devel@edk2.groups.io>; Gao, Liming
> <liming.gao@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Heinrich Schuchardt
> <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2379
> 
> When a file is saved in the edit command a status message L"%d Lines Wrote"
> is displayed. The hexedit command suffers from the same typo.
> 
> Change the message to L"%d Lines Written".
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c   | 2 +-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> index 12235e4e4b..71036a7487 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> @@ -1608,7 +1608,7 @@ FileBufferSave (
>    //   // set status string   //-  Str = CatSPrint (NULL, L"%d Lines Wrote",
> NumLines);+  Str = CatSPrint (NULL, L"%d Lines Written", NumLines);   if (Str ==
> NULL) {     return EFI_OUT_OF_RESOURCES;   }diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> index b393f2a423..bb324ceafc 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> @@ -368,7 +368,7 @@ HFileImageSave (
>    //   // set status string   //-  Str = CatSPrint(NULL, L"%d Lines Wrote",
> NumLines);+  Str = CatSPrint(NULL, L"%d Lines Written", NumLines);
> StatusBarSetStatusString (Str);   FreePool (Str); --
> 2.24.0
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#51206): https://edk2.groups.io/g/devel/message/51206
> Mute This Topic: https://groups.io/mt/61873155/1768756
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [zhichao.gao@intel.com] -
> =-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51568): https://edk2.groups.io/g/devel/message/51568
Mute This Topic: https://groups.io/mt/61873155/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

On 11/24/19 11:33 AM, Heinrich Schuchardt via Groups.Io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2379
> 
> When a file is saved in the edit command a status message L"%d Lines Wrote"
> is displayed. The hexedit command suffers from the same typo.
> 
> Change the message to L"%d Lines Written".
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Note to the maintainer taking this patch, please take care the 
GIT_AUTHOR_NAME / GIT_AUTHOR_EMAIL are correct (not the one rewritten by 
groups.io email policy).

> ---
>   ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c   | 2 +-
>   ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> index 12235e4e4b..71036a7487 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> @@ -1608,7 +1608,7 @@ FileBufferSave (
>     //
>     // set status string
>     //
> -  Str = CatSPrint (NULL, L"%d Lines Wrote", NumLines);
> +  Str = CatSPrint (NULL, L"%d Lines Written", NumLines);
>     if (Str == NULL) {
>       return EFI_OUT_OF_RESOURCES;
>     }
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> index b393f2a423..bb324ceafc 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> @@ -368,7 +368,7 @@ HFileImageSave (
>     //
>     // set status string
>     //
> -  Str = CatSPrint(NULL, L"%d Lines Wrote", NumLines);
> +  Str = CatSPrint(NULL, L"%d Lines Written", NumLines);
>     StatusBarSetStatusString (Str);
>     FreePool (Str);
>   
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51218): https://edk2.groups.io/g/devel/message/51218
Mute This Topic: https://groups.io/mt/61873155/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-