local header listing fixes for INF files, for edk2-stable201911

[edk2-devel] [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911

Posted by Laszlo Ersek 4 years, 5 months ago

Repo:              https://github.com/lersek/edk2.git
Branch:            local_hdrs
Personal CI build: https://github.com/tianocore/edk2/pull/188

I'm proposing this small set of fixes for edk2-stable201911.

If the consensus is that they should be delayed until after
edk2-stable201911, I'm OK with that too.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Shenglei Zhang <shenglei.zhang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>

Thanks
Laszlo

Laszlo Ersek (3):
  MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
  CryptoPkg/OpensslLib: improve INF file consistency
  CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h"

 CryptoPkg/Library/OpensslLib/OpensslLib.inf                          | 6 +++---
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51027): https://edk2.groups.io/g/devel/message/51027
Mute This Topic: https://groups.io/mt/61075472/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911

Posted by Leif Lindholm 4 years, 5 months ago

On Thu, Nov 21, 2019 at 10:38:30AM +0100, Laszlo Ersek wrote:
> Repo:              https://github.com/lersek/edk2.git
> Branch:            local_hdrs
> Personal CI build: https://github.com/tianocore/edk2/pull/188
> 
> I'm proposing this small set of fixes for edk2-stable201911.
> 
> If the consensus is that they should be delayed until after
> edk2-stable201911, I'm OK with that too.

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

But unless this addresses an actual build failure in some setup (and I
don't see how it could), please defer until after stable tag.

Best Regards,

Leif

> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Shenglei Zhang <shenglei.zhang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
>   CryptoPkg/OpensslLib: improve INF file consistency
>   CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h"
> 
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf                          | 6 +++---
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> -- 
> 2.19.1.3.g30247aa5d201
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51032): https://edk2.groups.io/g/devel/message/51032
Mute This Topic: https://groups.io/mt/61075472/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911

Posted by Laszlo Ersek 4 years, 5 months ago

On 11/21/19 11:00, Leif Lindholm wrote:
> On Thu, Nov 21, 2019 at 10:38:30AM +0100, Laszlo Ersek wrote:
>> Repo:              https://github.com/lersek/edk2.git
>> Branch:            local_hdrs
>> Personal CI build: https://github.com/tianocore/edk2/pull/188
>>
>> I'm proposing this small set of fixes for edk2-stable201911.
>>
>> If the consensus is that they should be delayed until after
>> edk2-stable201911, I'm OK with that too.
> 
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Thanks!

> 
> But unless this addresses an actual build failure in some setup (and I
> don't see how it could), please defer until after stable tag.

Right, this only triggers warnings from "build", which are meant to be
informative. No build is actually broken, to my knowledge. So I'll
postpone pushing the series. (I still need pkg maintainer feedback anyway.)

Thanks!
Laszlo

> 
> Best Regards,
> 
> Leif
> 
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
>> Cc: Shenglei Zhang <shenglei.zhang@intel.com>
>> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
>>   CryptoPkg/OpensslLib: improve INF file consistency
>>   CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h"
>>
>>  CryptoPkg/Library/OpensslLib/OpensslLib.inf                          | 6 +++---
>>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.19.1.3.g30247aa5d201
>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51091): https://edk2.groups.io/g/devel/message/51091
Mute This Topic: https://groups.io/mt/61075472/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911

Posted by Laszlo Ersek 4 years, 5 months ago

On 11/21/19 10:38, Laszlo Ersek via Groups.Io wrote:
> Repo:              https://github.com/lersek/edk2.git
> Branch:            local_hdrs
> Personal CI build: https://github.com/tianocore/edk2/pull/188
> 
> I'm proposing this small set of fixes for edk2-stable201911.
> 
> If the consensus is that they should be delayed until after
> edk2-stable201911, I'm OK with that too.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Shenglei Zhang <shenglei.zhang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
>   CryptoPkg/OpensslLib: improve INF file consistency
>   CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h"
> 
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf                          | 6 +++---
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 

Pushed as commit range bd85bf54c268..4d613feee57e via
<https://github.com/tianocore/edk2/pull/200>.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51561): https://edk2.groups.io/g/devel/message/51561
Mute This Topic: https://groups.io/mt/61075472/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-