[edk2-devel] [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup

Nate DeSimone posted 14 patches 6 years, 2 months ago
Only 13 patches received!
[edk2-devel] [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup
Posted by Nate DeSimone 6 years, 2 months ago
Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE
definitions from TcoWdtHob.h

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Include/Guid/TcoWdtHob.h                  | 23 ++-----------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
index 5bf2527963..9e83ed49c1 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
@@ -7,35 +7,16 @@
 #ifndef __TCO_WDT_HOB_H__
 #define __TCO_WDT_HOB_H__
 
+#include <PiPei.h>
+
 #define TCO_WDT_HOB_GUID \
   { \
     0x3e405418, 0xd8c, 0x4f1a, { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \
   }
 
-#ifndef _PEI_HOB_H_
-#ifndef __HOB__H__
-#ifndef __PI_HOB_H__
-typedef struct _EFI_HOB_GENERIC_HEADER {
-  UINT16  HobType;
-  UINT16  HobLength;
-  UINT32  Reserved;
-} EFI_HOB_GENERIC_HEADER;
-
-typedef struct _EFI_HOB_GUID_TYPE {
-  EFI_HOB_GENERIC_HEADER  Header;
-  EFI_GUID                Name;
-  //
-  // Guid specific data goes here
-  //
-} EFI_HOB_GUID_TYPE;
-#endif
-#endif
-#endif
-
 typedef struct {
   EFI_HOB_GUID_TYPE Header;
   UINT8             TcoRebootHappened;
 } TCO_WDT_HOB;
 
 #endif
-
-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51012): https://edk2.groups.io/g/devel/message/51012
Mute This Topic: https://groups.io/mt/61073529/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup
Posted by Chiu, Chasel 6 years, 2 months ago
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, November 21, 2019 4:59 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg:
> TcoWdtHob.h Cleanup
> 
> Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE
> definitions from TcoWdtHob.h
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Include/Guid/TcoWdtHob.h                  | 23 ++-----------------
>  1 file changed, 2 insertions(+), 21 deletions(-)
> 
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> index 5bf2527963..9e83ed49c1 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> @@ -7,35 +7,16 @@
>  #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include
> <PiPei.h>+ #define TCO_WDT_HOB_GUID \   { \     0x3e405418, 0xd8c,
> 0x4f1a, { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \   } -#ifndef
> _PEI_HOB_H_-#ifndef __HOB__H__-#ifndef __PI_HOB_H__-typedef struct
> _EFI_HOB_GENERIC_HEADER {-  UINT16  HobType;-  UINT16
> HobLength;-  UINT32  Reserved;-} EFI_HOB_GENERIC_HEADER;--typedef
> struct _EFI_HOB_GUID_TYPE {-  EFI_HOB_GENERIC_HEADER  Header;-
> EFI_GUID                Name;-  //-  // Guid specific data goes here-
> //-} EFI_HOB_GUID_TYPE;-#endif-#endif-#endif- typedef struct
> {   EFI_HOB_GUID_TYPE Header;   UINT8
> TcoRebootHappened; } TCO_WDT_HOB;  #endif---
> 2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51135): https://edk2.groups.io/g/devel/message/51135
Mute This Topic: https://groups.io/mt/61073529/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup
Posted by Kubacki, Michael A 6 years, 2 months ago
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg:
> TcoWdtHob.h Cleanup
> 
> Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE
> definitions from TcoWdtHob.h
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Include/Guid/TcoWdtHob.h                  | 23 ++-----------------
>  1 file changed, 2 insertions(+), 21 deletions(-)
> 
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> index 5bf2527963..9e83ed49c1 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> @@ -7,35 +7,16 @@
>  #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include
> <PiPei.h>+ #define TCO_WDT_HOB_GUID \   { \     0x3e405418, 0xd8c, 0x4f1a,
> { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \   } -#ifndef _PEI_HOB_H_-
> #ifndef __HOB__H__-#ifndef __PI_HOB_H__-typedef struct
> _EFI_HOB_GENERIC_HEADER {-  UINT16  HobType;-  UINT16  HobLength;-
> UINT32  Reserved;-} EFI_HOB_GENERIC_HEADER;--typedef struct
> _EFI_HOB_GUID_TYPE {-  EFI_HOB_GENERIC_HEADER  Header;-  EFI_GUID
> Name;-  //-  // Guid specific data goes here-  //-} EFI_HOB_GUID_TYPE;-
> #endif-#endif-#endif- typedef struct {   EFI_HOB_GUID_TYPE Header;
> UINT8             TcoRebootHappened; } TCO_WDT_HOB;  #endif---
> 2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51149): https://edk2.groups.io/g/devel/message/51149
Mute This Topic: https://groups.io/mt/61073529/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup
Posted by Chaganty, Rangasai V 6 years, 2 months ago
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L 
Sent: Thursday, November 21, 2019 12:59 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup

Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE definitions from TcoWdtHob.h

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Include/Guid/TcoWdtHob.h                  | 23 ++-----------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
index 5bf2527963..9e83ed49c1 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
@@ -7,35 +7,16 @@
 #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include <PiPei.h>+ #define TCO_WDT_HOB_GUID \   { \     0x3e405418, 0xd8c, 0x4f1a, { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \   } -#ifndef _PEI_HOB_H_-#ifndef __HOB__H__-#ifndef __PI_HOB_H__-typedef struct _EFI_HOB_GENERIC_HEADER {-  UINT16  HobType;-  UINT16  HobLength;-  UINT32  Reserved;-} EFI_HOB_GENERIC_HEADER;--typedef struct _EFI_HOB_GUID_TYPE {-  EFI_HOB_GENERIC_HEADER  Header;-  EFI_GUID                Name;-  //-  // Guid specific data goes here-  //-} EFI_HOB_GUID_TYPE;-#endif-#endif-#endif- typedef struct {   EFI_HOB_GUID_TYPE Header;   UINT8             TcoRebootHappened; } TCO_WDT_HOB;  #endif--- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51163): https://edk2.groups.io/g/devel/message/51163
Mute This Topic: https://groups.io/mt/61073529/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-