1. Patchew
  2. EDK2
  3. [edk2-devel] [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib Cleanup
  4. View patch

[edk2-devel] [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments

Nate DeSimone posted 14 patches 6 years, 2 months ago
Only 13 patches received!
[edk2-devel] [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments
Posted by Nate DeSimone 6 years, 2 months ago 
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Library/PeiSiliconInitLib/SiliconInit.c                   | 3 +++
 .../Library/PeiSiliconInitLib/SiliconInitPreMem.c             | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
index d09bec0489..2057973d4b 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
@@ -199,6 +199,9 @@ ClearIchSmiAndWake (
   return EFI_SUCCESS;
 }
 
+/**
+  Late Silicon Initialization
+**/
 VOID
 LateSiliconInit (
   VOID
diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
index 65a67a6795..6af9e0fcfc 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
@@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/PeiServicesTablePointerLib.h>
 #include <Library/PchSerialIoLib.h>
 
-//@todo it should be moved to Si Pkg.
 /**
-  Early Platform PCH initialization
+  Early Silicon initialization
 **/
 VOID
 EarlySiliconInit (
@@ -233,4 +232,3 @@ SiliconInit (
   }
 
 }
-
-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51015): https://edk2.groups.io/g/devel/message/51015
Mute This Topic: https://groups.io/mt/61073532/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments
Posted by Chiu, Chasel 6 years, 2 months ago 
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, November 21, 2019 4:59 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old
> comments
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Library/PeiSiliconInitLib/SiliconInit.c                   | 3 +++
>  .../Library/PeiSiliconInitLib/SiliconInitPreMem.c             | 4 +---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> index d09bec0489..2057973d4b 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
> +++ Init.c
> @@ -199,6 +199,9 @@ ClearIchSmiAndWake (
>    return EFI_SUCCESS; } +/**+  Late Silicon Initialization+**/ VOID
> LateSiliconInit (   VOIDdiff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> index 65a67a6795..6af9e0fcfc 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
> +++ InitPreMem.c
> @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include
> <Library/PeiServicesTablePointerLib.h> #include <Library/PchSerialIoLib.h>
> -//@todo it should be moved to Si Pkg. /**-  Early Platform PCH
> initialization+  Early Silicon initialization **/ VOID EarlySiliconInit (@@
> -233,4 +232,3 @@ SiliconInit (
>    }  }---
> 2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51133): https://edk2.groups.io/g/devel/message/51133
Mute This Topic: https://groups.io/mt/61073532/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments
Posted by Kubacki, Michael A 6 years, 2 months ago 
The copyright year should be updated in SiliconInit.c

With that change:
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old
> comments
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Library/PeiSiliconInitLib/SiliconInit.c                   | 3 +++
>  .../Library/PeiSiliconInitLib/SiliconInitPreMem.c             | 4 +---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> index d09bec0489..2057973d4b 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
> +++ Init.c
> @@ -199,6 +199,9 @@ ClearIchSmiAndWake (
>    return EFI_SUCCESS; } +/**+  Late Silicon Initialization+**/ VOID
> LateSiliconInit (   VOIDdiff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> index 65a67a6795..6af9e0fcfc 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMe
> m.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
> +++ InitPreMem.c
> @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include
> <Library/PeiServicesTablePointerLib.h> #include <Library/PchSerialIoLib.h> -
> //@todo it should be moved to Si Pkg. /**-  Early Platform PCH initialization+
> Early Silicon initialization **/ VOID EarlySiliconInit (@@ -233,4 +232,3 @@
> SiliconInit (
>    }  }---
> 2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51147): https://edk2.groups.io/g/devel/message/51147
Mute This Topic: https://groups.io/mt/61073532/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments
Posted by Chaganty, Rangasai V 6 years, 2 months ago 
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L 
Sent: Thursday, November 21, 2019 12:59 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Library/PeiSiliconInitLib/SiliconInit.c                   | 3 +++
 .../Library/PeiSiliconInitLib/SiliconInitPreMem.c             | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
index d09bec0489..2057973d4b 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
+++ Init.c
@@ -199,6 +199,9 @@ ClearIchSmiAndWake (
   return EFI_SUCCESS; } +/**+  Late Silicon Initialization+**/ VOID LateSiliconInit (   VOIDdiff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
index 65a67a6795..6af9e0fcfc 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon
+++ InitPreMem.c
@@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include <Library/PeiServicesTablePointerLib.h> #include <Library/PchSerialIoLib.h> -//@todo it should be moved to Si Pkg. /**-  Early Platform PCH initialization+  Early Silicon initialization **/ VOID EarlySiliconInit (@@ -233,4 +232,3 @@ SiliconInit (
   }  }---
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51161): https://edk2.groups.io/g/devel/message/51161
Mute This Topic: https://groups.io/mt/61073532/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.