1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles

Zhang, Shenglei posted 1 patch 4 years, 5 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
[edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles
Posted by Zhang, Shenglei 4 years, 5 months ago 
From: Shenglei Zhang <shenglei.zhang@intel.com>

In MpLib.c, remove the white space on a new line.
In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index 49be5d5385d9..d32adf0780b7 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -475,7 +475,7 @@ CollectProcessorCount (
     CpuPause ();
   }
 
-  
+
   //
   // Enable x2APIC mode if
   //  1. Number of CPU is greater than 255; or
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
index f891a811126f..2483f2ea849d 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
@@ -342,7 +342,7 @@ RestoreCr2 (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
index e5c4788c13d7..810985df20ae 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
@@ -1275,7 +1275,7 @@ RestoreCr2 (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
index daf977f654b4..7e7c73f27f76 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
@@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50661): https://edk2.groups.io/g/devel/message/50661
Mute This Topic: https://groups.io/mt/57476145/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles
Posted by Dong, Eric 4 years, 4 months ago 
Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH] UefiCpuPkg: Update the coding styles
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> In MpLib.c, remove the white space on a new line.
> In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 49be5d5385d9..d32adf0780b7 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -475,7 +475,7 @@ CollectProcessorCount (
>      CpuPause ();
>    }
> 
> -
> +
>    //
>    // Enable x2APIC mode if
>    //  1. Number of CPU is greater than 255; or diff --git
> a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> index f891a811126f..2483f2ea849d 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> @@ -342,7 +342,7 @@ RestoreCr2 (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index e5c4788c13d7..810985df20ae 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1275,7 +1275,7 @@ RestoreCr2 (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7e7c73f27f76 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50865): https://edk2.groups.io/g/devel/message/50865
Mute This Topic: https://groups.io/mt/57476145/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles
Posted by Laszlo Ersek 4 years, 4 months ago 
On 11/14/19 12:46, Zhang, Shenglei wrote:
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> In MpLib.c, remove the white space on a new line.
> In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 49be5d5385d9..d32adf0780b7 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -475,7 +475,7 @@ CollectProcessorCount (
>      CpuPause ();
>    }
>  
> -  
> +
>    //
>    // Enable x2APIC mode if
>    //  1. Number of CPU is greater than 255; or
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> index f891a811126f..2483f2ea849d 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> @@ -342,7 +342,7 @@ RestoreCr2 (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index e5c4788c13d7..810985df20ae 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1275,7 +1275,7 @@ RestoreCr2 (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7e7c73f27f76 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50912): https://edk2.groups.io/g/devel/message/50912
Mute This Topic: https://groups.io/mt/57476145/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.