[edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported

Zhang, Shenglei posted 1 patch 4 years, 5 months ago
Failed in applying to current master (apply log)
MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
2 files changed, 19 insertions(+), 18 deletions(-)
[edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported
Posted by Zhang, Shenglei 4 years, 5 months ago
From: Shenglei Zhang <shenglei.zhang@intel.com>

Keep the comment style of IsLanguageSupported align with
other functions.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
 MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
index cc03be84c2d8..07c45d1e91ff 100644
--- a/MdePkg/Library/UefiLib/UefiLib.c
+++ b/MdePkg/Library/UefiLib/UefiLib.c
@@ -641,15 +641,15 @@ EfiTestChildHandle (
 }
 
 /**
- * This function checks the supported languages list for a target language,
- * This only supports RFC 4646 Languages.
- *
- * @param      SupportedLanguages  The supported languages
- * @param      TargetLanguage      The target language
- *
- * @return     Returns EFI_SUCCESS if the language is supported,
- *             EFI_UNSUPPORTED otherwise
- */
+  This function checks the supported languages list for a target language,
+  This only supports RFC 4646 Languages.
+
+  @param  SupportedLanguages  The supported languages
+  @param  TargetLanguage      The target language
+
+  @retval Returns EFI_SUCCESS if the language is supported,
+          EFI_UNSUPPORTED otherwise
+**/
 EFI_STATUS
 EFIAPI
 IsLanguageSupported (
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
index 67c6f96747ca..0abb40d6ecbd 100644
--- a/MdePkg/Include/Library/UefiLib.h
+++ b/MdePkg/Include/Library/UefiLib.h
@@ -462,15 +462,16 @@ EfiTestChildHandle (
   );
 
 /**
- * This function checks the supported languages list for a target language,
- * This only supports RFC 4646 Languages.
- *
- * @param      SupportedLanguages  The supported languages
- * @param      TargetLanguage      The target language
- *
- * @return     Returns EFI_SUCCESS if the language is supported,
- *             EFI_UNSUPPORTED otherwise
- */
+  This function checks the supported languages list for a target language,
+  This only supports RFC 4646 Languages.
+
+  @param  SupportedLanguages  The supported languages
+  @param  TargetLanguage      The target language
+
+  @retval Returns EFI_SUCCESS if the language is supported,
+          EFI_UNSUPPORTED otherwise
+
+**/
 EFI_STATUS
 EFIAPI
 IsLanguageSupported (
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50662): https://edk2.groups.io/g/devel/message/50662
Mute This Topic: https://groups.io/mt/57476152/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported
Posted by Liming Gao 4 years, 5 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg: Update the comments of IsLanguageSupported
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Keep the comment style of IsLanguageSupported align with
> other functions.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
>  MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
>  2 files changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index cc03be84c2d8..07c45d1e91ff 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -641,15 +641,15 @@ EfiTestChildHandle (
>  }
> 
>  /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param      SupportedLanguages  The supported languages
> - * @param      TargetLanguage      The target language
> - *
> - * @return     Returns EFI_SUCCESS if the language is supported,
> - *             EFI_UNSUPPORTED otherwise
> - */
> +  This function checks the supported languages list for a target language,
> +  This only supports RFC 4646 Languages.
> +
> +  @param  SupportedLanguages  The supported languages
> +  @param  TargetLanguage      The target language
> +
> +  @retval Returns EFI_SUCCESS if the language is supported,
> +          EFI_UNSUPPORTED otherwise
> +**/
>  EFI_STATUS
>  EFIAPI
>  IsLanguageSupported (
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 67c6f96747ca..0abb40d6ecbd 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -462,15 +462,16 @@ EfiTestChildHandle (
>    );
> 
>  /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param      SupportedLanguages  The supported languages
> - * @param      TargetLanguage      The target language
> - *
> - * @return     Returns EFI_SUCCESS if the language is supported,
> - *             EFI_UNSUPPORTED otherwise
> - */
> +  This function checks the supported languages list for a target language,
> +  This only supports RFC 4646 Languages.
> +
> +  @param  SupportedLanguages  The supported languages
> +  @param  TargetLanguage      The target language
> +
> +  @retval Returns EFI_SUCCESS if the language is supported,
> +          EFI_UNSUPPORTED otherwise
> +
> +**/
>  EFI_STATUS
>  EFIAPI
>  IsLanguageSupported (
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50688): https://edk2.groups.io/g/devel/message/50688
Mute This Topic: https://groups.io/mt/57476152/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-