[edk2-devel] [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable

Agyeman, Prince posted 1 patch 1 week ago
Failed in applying to current master (apply log)
.../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c    | 2 --
1 file changed, 2 deletions(-)

[edk2-devel] [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable

Posted by Agyeman, Prince 1 week ago
Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c
to avoid gcc 5 build error unused-but-set-variable.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 .../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
index 3a885e0d71..eff10bddb4 100644
--- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
@@ -47,13 +47,11 @@ DetectPs2Keyboard (
   )
 {
   UINT32                TimeOut;
-  UINT32                RegEmptied;
   UINT8                 Data;
   UINT32                SumTimeOut;
   BOOLEAN               FoundPs2Kbc;
 
   TimeOut     = 0;
-  RegEmptied  = 0;
   FoundPs2Kbc       = FALSE;
 
   //
-- 
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50173): https://edk2.groups.io/g/devel/message/50173
Mute This Topic: https://groups.io/mt/45359163/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable

Posted by Kubacki, Michael A 6 days ago
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, November 6, 2019 10:49 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms] [PATCH] BoardModulePkg: Remove unused
> variable
> 
> Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c to avoid gcc 5 build
> error unused-but-set-variable.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c    | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> index 3a885e0d71..eff10bddb4 100644
> --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> +++
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> @@ -47,13 +47,11 @@ DetectPs2Keyboard (
>    )
>  {
>    UINT32                TimeOut;
> -  UINT32                RegEmptied;
>    UINT8                 Data;
>    UINT32                SumTimeOut;
>    BOOLEAN               FoundPs2Kbc;
> 
>    TimeOut     = 0;
> -  RegEmptied  = 0;
>    FoundPs2Kbc       = FALSE;
> 
>    //
> --
> 2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50378): https://edk2.groups.io/g/devel/message/50378
Mute This Topic: https://groups.io/mt/45359163/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-