[v3] Enable Phase 1 of EDK II CI

[edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode

Posted by Michael D Kinney 6 years, 3 months ago

From: Sean Brogan <sean.brogan@microsoft.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=2315

Update .gitignore to ignore .pyc files and __pycache__
directories.  Python based plugins can be added to any
package or platform, so these files and directories may
be present outside of BaseTools.

Ignore _extdep directories that are generated by the
pytool external dependency feature.

Ignore .vscode directories generated by the VS Code
editor.

Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Kinney <michael.d.kinney@intel.com>
---
 .gitignore | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/.gitignore b/.gitignore
index 97f22c348c..71679478ac 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,8 @@
 Build/
 tags/
 .DS_Store
+*.pyc
+__pycache__/
+*_extdep/
+
+.vscode/
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49586): https://edk2.groups.io/g/devel/message/49586
Mute This Topic: https://groups.io/mt/39614156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode

Posted by Leif Lindholm 6 years, 3 months ago

On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D Kinney wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
> 
> Update .gitignore to ignore .pyc files and __pycache__
> directories.  Python based plugins can be added to any
> package or platform, so these files and directories may
> be present outside of BaseTools.
> 
> Ignore _extdep directories that are generated by the
> pytool external dependency feature.
> 
> Ignore .vscode directories generated by the VS Code
> editor.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Kinney <michael.d.kinney@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

(This one could be merged independently of rest of set, it's useful on
its own.)

> ---
>  .gitignore | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 97f22c348c..71679478ac 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,8 @@
>  Build/
>  tags/
>  .DS_Store
> +*.pyc
> +__pycache__/
> +*_extdep/
> +
> +.vscode/
> -- 
> 2.21.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49615): https://edk2.groups.io/g/devel/message/49615
Mute This Topic: https://groups.io/mt/39614156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode

Posted by Michael D Kinney 6 years, 3 months ago

Leif,

Thanks.  I agree.  I will split it out.

Mike

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Tuesday, October 29, 2019 7:30 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io; Sean Brogan
> <sean.brogan@microsoft.com>; Andrew Fish
> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python
> compiled files, extdeps, and vscode
> 
> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D
> Kinney wrote:
> > From: Sean Brogan <sean.brogan@microsoft.com>
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2315
> >
> > Update .gitignore to ignore .pyc files and __pycache__
> directories.
> > Python based plugins can be added to any package or
> platform, so these
> > files and directories may be present outside of
> BaseTools.
> >
> > Ignore _extdep directories that are generated by the
> pytool external
> > dependency feature.
> >
> > Ignore .vscode directories generated by the VS Code
> editor.
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Kinney <michael.d.kinney@intel.com>
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> (This one could be merged independently of rest of set,
> it's useful on its own.)
> 
> > ---
> >  .gitignore | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 97f22c348c..71679478ac 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,3 +1,8 @@
> >  Build/
> >  tags/
> >  .DS_Store
> > +*.pyc
> > +__pycache__/
> > +*_extdep/
> > +
> > +.vscode/
> > --
> > 2.21.0.windows.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49712): https://edk2.groups.io/g/devel/message/49712
Mute This Topic: https://groups.io/mt/39614156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode

Posted by Laszlo Ersek 6 years, 3 months ago

On 10/31/19 05:43, Kinney, Michael D wrote:
> Leif,
> 
> Thanks.  I agree.  I will split it out.

I would further suggest alphabetical sorting for the .gitignore lines.

Thanks!
Laszlo

> 
> Mike
> 
>> -----Original Message-----
>> From: Leif Lindholm <leif.lindholm@linaro.org>
>> Sent: Tuesday, October 29, 2019 7:30 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: devel@edk2.groups.io; Sean Brogan
>> <sean.brogan@microsoft.com>; Andrew Fish
>> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
>> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python
>> compiled files, extdeps, and vscode
>>
>> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D
>> Kinney wrote:
>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>>
>>> Update .gitignore to ignore .pyc files and __pycache__
>> directories.
>>> Python based plugins can be added to any package or
>> platform, so these
>>> files and directories may be present outside of
>> BaseTools.
>>>
>>> Ignore _extdep directories that are generated by the
>> pytool external
>>> dependency feature.
>>>
>>> Ignore .vscode directories generated by the VS Code
>> editor.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Signed-off-by: Kinney <michael.d.kinney@intel.com>
>>
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> (This one could be merged independently of rest of set,
>> it's useful on its own.)
>>
>>> ---
>>>  .gitignore | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/.gitignore b/.gitignore
>>> index 97f22c348c..71679478ac 100644
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -1,3 +1,8 @@
>>>  Build/
>>>  tags/
>>>  .DS_Store
>>> +*.pyc
>>> +__pycache__/
>>> +*_extdep/
>>> +
>>> +.vscode/
>>> --
>>> 2.21.0.windows.1
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49739): https://edk2.groups.io/g/devel/message/49739
Mute This Topic: https://groups.io/mt/39614156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

On 10/31/19 10:02 AM, Laszlo Ersek wrote:
> On 10/31/19 05:43, Kinney, Michael D wrote:
>> Leif,
>>
>> Thanks.  I agree.  I will split it out.
> 
> I would further suggest alphabetical sorting for the .gitignore lines.

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>>> -----Original Message-----
>>> From: Leif Lindholm <leif.lindholm@linaro.org>
>>> Sent: Tuesday, October 29, 2019 7:30 PM
>>> To: Kinney, Michael D <michael.d.kinney@intel.com>
>>> Cc: devel@edk2.groups.io; Sean Brogan
>>> <sean.brogan@microsoft.com>; Andrew Fish
>>> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
>>> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python
>>> compiled files, extdeps, and vscode
>>>
>>> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D
>>> Kinney wrote:
>>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>>
>>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>>>
>>>> Update .gitignore to ignore .pyc files and __pycache__
>>> directories.
>>>> Python based plugins can be added to any package or
>>> platform, so these
>>>> files and directories may be present outside of
>>> BaseTools.
>>>>
>>>> Ignore _extdep directories that are generated by the
>>> pytool external
>>>> dependency feature.
>>>>
>>>> Ignore .vscode directories generated by the VS Code
>>> editor.
>>>>
>>>> Cc: Andrew Fish <afish@apple.com>
>>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>>> Signed-off-by: Kinney <michael.d.kinney@intel.com>
>>>
>>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>>
>>> (This one could be merged independently of rest of set,
>>> it's useful on its own.)
>>>
>>>> ---
>>>>   .gitignore | 5 +++++
>>>>   1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/.gitignore b/.gitignore
>>>> index 97f22c348c..71679478ac 100644
>>>> --- a/.gitignore
>>>> +++ b/.gitignore
>>>> @@ -1,3 +1,8 @@
>>>>   Build/
>>>>   tags/
>>>>   .DS_Store
>>>> +*.pyc
>>>> +__pycache__/
>>>> +*_extdep/
>>>> +
>>>> +.vscode/
>>>> --
>>>> 2.21.0.windows.1
>>>>
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49930): https://edk2.groups.io/g/devel/message/49930
Mute This Topic: https://groups.io/mt/39614156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-