1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc

Michael D Kinney posted 1 patch 4 years, 6 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
[edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Michael D Kinney 4 years, 6 months ago 
From: Sean Brogan <sean.brogan@microsoft.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=2255

Update UefiCpuPkg.dsc to guarantee all libraries and
modules are always built.  Add the following components.

* UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
* UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf

ResetVector.inf is a binary INF, so no source builds are
triggered from adding this line.  However, a build with
this component does verify the contents of the INF file.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
index e7dfe30eda..d28cb5cccb 100644
--- a/UefiCpuPkg/UefiCpuPkg.dsc
+++ b/UefiCpuPkg/UefiCpuPkg.dsc
@@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
   UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
   UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
   UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
+  UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
@@ -146,6 +147,7 @@ [Components.IA32, Components.X64]
       SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf
   }
   UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
+  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49361): https://edk2.groups.io/g/devel/message/49361
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Laszlo Ersek 4 years, 6 months ago 
On 10/22/19 21:06, Michael D Kinney wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> 
> Update UefiCpuPkg.dsc to guarantee all libraries and
> modules are always built.  Add the following components.
> 
> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> * UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
> 
> ResetVector.inf is a binary INF, so no source builds are
> triggered from adding this line.  However, a build with
> this component does verify the contents of the INF file.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
> index e7dfe30eda..d28cb5cccb 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> @@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
>    UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
>    UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
> +  UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
>    UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf
>    UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
>    UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
> @@ -146,6 +147,7 @@ [Components.IA32, Components.X64]
>        SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf
>    }
>    UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>  
>  [BuildOptions]
>    *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

Can we retire

  UefiCpuPkg/ResetVector/Vtf0/Bin/

instead (in a separate patch)?

Because, according to

  git log --stat master -- UefiCpuPkg/ResetVector/Vtf0/Bin/

the most recent commit in which we updated the *.raw files has been
f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding SEC image of
type TE.", 2011-09-28).

I doubt anyone consumes this (binary) module, since Jordan's commits
- 5a1f324d946c ("UefiCpuPkg: Support building VTF0 ResetVector during
the EDK II build", 2014-08-18)
- eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables in NASM code",
2014-08-18).

We've by now dropped all top-level *BinPkg package directories too.

If we remove the Bin subdir, then we should probably remove:
- Build.py
- Tools/
too.

For the other addition (CpuCommonFeaturesLib): if that gets its own
patch (after the removal of UefiCpuPkg/ResetVector/Vtf0/Bin/), then
please add

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

to it.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49369): https://edk2.groups.io/g/devel/message/49369
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Michael D Kinney 4 years, 6 months ago 
Laszlo,

I see 2 usages of this module in edk2-platforms:

edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13):  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf

edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fdf(16):INF  RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf

Mike

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, October 22, 2019 3:57 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [Patch] UefiCpuPkg: Add missing components
> to UefiCpuPkg.dsc
> 
> On 10/22/19 21:06, Michael D Kinney wrote:
> > From: Sean Brogan <sean.brogan@microsoft.com>
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> >
> > Update UefiCpuPkg.dsc to guarantee all libraries and
> modules are
> > always built.  Add the following components.
> >
> > * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > *
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> sLib.inf
> >
> > ResetVector.inf is a binary INF, so no source builds
> are triggered
> > from adding this line.  However, a build with this
> component does
> > verify the contents of the INF file.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> > ---
> >  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> b/UefiCpuPkg/UefiCpuPkg.dsc
> > index e7dfe30eda..d28cb5cccb 100644
> > --- a/UefiCpuPkg/UefiCpuPkg.dsc
> > +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> > @@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
> >
> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> >    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> >
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> .inf
> > +
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> sLib.inf
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> nHandlerLib.inf
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> tionHandlerLib.inf
> >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> nHandlerLib.in
> > f @@ -146,6 +147,7 @@ [Components.IA32,
> Components.X64]
> >
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> mmCpuFeaturesLibStm.inf
> >    }
> >
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> > +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >
> >  [BuildOptions]
> >    *_*_*_CC_FLAGS = -D
> DISABLE_NEW_DEPRECATED_INTERFACES
> >
> 
> Can we retire
> 
>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> 
> instead (in a separate patch)?
> 
> Because, according to
> 
>   git log --stat master --
> UefiCpuPkg/ResetVector/Vtf0/Bin/
> 
> the most recent commit in which we updated the *.raw
> files has been
> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding
> SEC image of type TE.", 2011-09-28).
> 
> I doubt anyone consumes this (binary) module, since
> Jordan's commits
> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
> ResetVector during the EDK II build", 2014-08-18)
> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables
> in NASM code", 2014-08-18).
> 
> We've by now dropped all top-level *BinPkg package
> directories too.
> 
> If we remove the Bin subdir, then we should probably
> remove:
> - Build.py
> - Tools/
> too.
> 
> For the other addition (CpuCommonFeaturesLib): if that
> gets its own patch (after the removal of
> UefiCpuPkg/ResetVector/Vtf0/Bin/), then please add
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> to it.
> 
> Thanks
> Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49370): https://edk2.groups.io/g/devel/message/49370
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Laszlo Ersek 4 years, 6 months ago 
(+David, +Prince)

On 10/23/19 01:13, Kinney, Michael D wrote:
> Laszlo,
> 
> I see 2 usages of this module in edk2-platforms:
> 
> edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13):  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> 
> edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fdf(16):INF  RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf

Can we update those platforms to build the reset vector from source?

Embedding a binary blob seems wrong in its own right...

Anyway, if Ray and/or Eric are OK with the present patch, I won't try to
block it.

Thanks,
Laszlo

>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Tuesday, October 22, 2019 3:57 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>> devel@edk2.groups.io
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
>> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
>> Subject: Re: [Patch] UefiCpuPkg: Add missing components
>> to UefiCpuPkg.dsc
>>
>> On 10/22/19 21:06, Michael D Kinney wrote:
>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
>>>
>>> Update UefiCpuPkg.dsc to guarantee all libraries and
>> modules are
>>> always built.  Add the following components.
>>>
>>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>> *
>> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
>> sLib.inf
>>>
>>> ResetVector.inf is a binary INF, so no source builds
>> are triggered
>>> from adding this line.  However, a build with this
>> component does
>>> verify the contents of the INF file.
>>>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Signed-off-by: Michael D Kinney
>> <michael.d.kinney@intel.com>
>>> ---
>>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
>> b/UefiCpuPkg/UefiCpuPkg.dsc
>>> index e7dfe30eda..d28cb5cccb 100644
>>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
>>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
>>> @@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
>>>
>> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>>>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
>>>
>> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
>> .inf
>>> +
>> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
>> sLib.inf
>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
>> nHandlerLib.inf
>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
>> tionHandlerLib.inf
>>>
>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
>> nHandlerLib.in
>>> f @@ -146,6 +147,7 @@ [Components.IA32,
>> Components.X64]
>>>
>> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
>> mmCpuFeaturesLibStm.inf
>>>    }
>>>
>> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
>>> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>>
>>>  [BuildOptions]
>>>    *_*_*_CC_FLAGS = -D
>> DISABLE_NEW_DEPRECATED_INTERFACES
>>>
>>
>> Can we retire
>>
>>   UefiCpuPkg/ResetVector/Vtf0/Bin/
>>
>> instead (in a separate patch)?
>>
>> Because, according to
>>
>>   git log --stat master --
>> UefiCpuPkg/ResetVector/Vtf0/Bin/
>>
>> the most recent commit in which we updated the *.raw
>> files has been
>> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding
>> SEC image of type TE.", 2011-09-28).
>>
>> I doubt anyone consumes this (binary) module, since
>> Jordan's commits
>> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
>> ResetVector during the EDK II build", 2014-08-18)
>> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables
>> in NASM code", 2014-08-18).
>>
>> We've by now dropped all top-level *BinPkg package
>> directories too.
>>
>> If we remove the Bin subdir, then we should probably
>> remove:
>> - Build.py
>> - Tools/
>> too.
>>
>> For the other addition (CpuCommonFeaturesLib): if that
>> gets its own patch (after the removal of
>> UefiCpuPkg/ResetVector/Vtf0/Bin/), then please add
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> to it.
>>
>> Thanks
>> Laszlo
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49372): https://edk2.groups.io/g/devel/message/49372
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Michael D Kinney 4 years, 6 months ago 
Laszlo,

Can we move forward with this patch and enter a new
BZ to remove the binary module?

Mike

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, October 22, 2019 4:27 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Wei,
> David Y <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: Re: [Patch] UefiCpuPkg: Add missing components
> to UefiCpuPkg.dsc
> 
> (+David, +Prince)
> 
> On 10/23/19 01:13, Kinney, Michael D wrote:
> > Laszlo,
> >
> > I see 2 usages of this module in edk2-platforms:
> >
> > edk2-
> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
> ):
> > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >
> > edk2-
> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
> f(16):INF
> > RuleOverride=RESET_VECTOR USE = IA32
> > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> 
> Can we update those platforms to build the reset vector
> from source?
> 
> Embedding a binary blob seems wrong in its own right...
> 
> Anyway, if Ray and/or Eric are OK with the present
> patch, I won't try to block it.
> 
> Thanks,
> Laszlo
> 
> >> -----Original Message-----
> >> From: Laszlo Ersek <lersek@redhat.com>
> >> Sent: Tuesday, October 22, 2019 3:57 PM
> >> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> >> devel@edk2.groups.io
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> Eric
> >> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> >> Subject: Re: [Patch] UefiCpuPkg: Add missing
> components to
> >> UefiCpuPkg.dsc
> >>
> >> On 10/22/19 21:06, Michael D Kinney wrote:
> >>> From: Sean Brogan <sean.brogan@microsoft.com>
> >>>
> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> >>>
> >>> Update UefiCpuPkg.dsc to guarantee all libraries and
> >> modules are
> >>> always built.  Add the following components.
> >>>
> >>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >>> *
> >>
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> >> sLib.inf
> >>>
> >>> ResetVector.inf is a binary INF, so no source builds
> >> are triggered
> >>> from adding this line.  However, a build with this
> >> component does
> >>> verify the contents of the INF file.
> >>>
> >>> Cc: Eric Dong <eric.dong@intel.com>
> >>> Cc: Ray Ni <ray.ni@intel.com>
> >>> Cc: Laszlo Ersek <lersek@redhat.com>
> >>> Signed-off-by: Michael D Kinney
> >> <michael.d.kinney@intel.com>
> >>> ---
> >>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> >> b/UefiCpuPkg/UefiCpuPkg.dsc
> >>> index e7dfe30eda..d28cb5cccb 100644
> >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> >>> @@ -121,6 +121,7 @@ [Components.IA32,
> Components.X64]
> >>>
> >> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> >>>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> >>>
> >>
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> >> .inf
> >>> +
> >>
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> >> sLib.inf
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> >> nHandlerLib.inf
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> >> tionHandlerLib.inf
> >>>
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> >> nHandlerLib.in
> >>> f @@ -146,6 +147,7 @@ [Components.IA32,
> >> Components.X64]
> >>>
> >>
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> >> mmCpuFeaturesLibStm.inf
> >>>    }
> >>>
> >>
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> >>> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >>>
> >>>  [BuildOptions]
> >>>    *_*_*_CC_FLAGS = -D
> >> DISABLE_NEW_DEPRECATED_INTERFACES
> >>>
> >>
> >> Can we retire
> >>
> >>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> >>
> >> instead (in a separate patch)?
> >>
> >> Because, according to
> >>
> >>   git log --stat master --
> >> UefiCpuPkg/ResetVector/Vtf0/Bin/
> >>
> >> the most recent commit in which we updated the *.raw
> files has been
> >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
> finding SEC image of
> >> type TE.", 2011-09-28).
> >>
> >> I doubt anyone consumes this (binary) module, since
> Jordan's commits
> >> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
> ResetVector during
> >> the EDK II build", 2014-08-18)
> >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
> tables in NASM
> >> code", 2014-08-18).
> >>
> >> We've by now dropped all top-level *BinPkg package
> directories too.
> >>
> >> If we remove the Bin subdir, then we should probably
> >> remove:
> >> - Build.py
> >> - Tools/
> >> too.
> >>
> >> For the other addition (CpuCommonFeaturesLib): if
> that gets its own
> >> patch (after the removal of
> UefiCpuPkg/ResetVector/Vtf0/Bin/), then
> >> please add
> >>
> >> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >>
> >> to it.
> >>
> >> Thanks
> >> Laszlo
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49373): https://edk2.groups.io/g/devel/message/49373
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Dong, Eric 4 years, 6 months ago 
Hi Mike and Laszlo,

I agree with Mike's proposal. We can submit new bugz to remove the binary.

Thanks,
Eric

-----Original Message-----
From: Kinney, Michael D 
Sent: Wednesday, October 23, 2019 7:39 AM
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Wei, David Y <david.y.wei@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: RE: [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc

Laszlo,

Can we move forward with this patch and enter a new BZ to remove the binary module?

Mike

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, October 22, 2019 4:27 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric 
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Wei, David Y 
> <david.y.wei@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>
> Subject: Re: [Patch] UefiCpuPkg: Add missing components to 
> UefiCpuPkg.dsc
> 
> (+David, +Prince)
> 
> On 10/23/19 01:13, Kinney, Michael D wrote:
> > Laszlo,
> >
> > I see 2 usages of this module in edk2-platforms:
> >
> > edk2-
> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
> ):
> > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >
> > edk2-
> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
> f(16):INF
> > RuleOverride=RESET_VECTOR USE = IA32 
> > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> 
> Can we update those platforms to build the reset vector from source?
> 
> Embedding a binary blob seems wrong in its own right...
> 
> Anyway, if Ray and/or Eric are OK with the present patch, I won't try 
> to block it.
> 
> Thanks,
> Laszlo
> 
> >> -----Original Message-----
> >> From: Laszlo Ersek <lersek@redhat.com>
> >> Sent: Tuesday, October 22, 2019 3:57 PM
> >> To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> >> devel@edk2.groups.io
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> Eric
> >> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> >> Subject: Re: [Patch] UefiCpuPkg: Add missing
> components to
> >> UefiCpuPkg.dsc
> >>
> >> On 10/22/19 21:06, Michael D Kinney wrote:
> >>> From: Sean Brogan <sean.brogan@microsoft.com>
> >>>
> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> >>>
> >>> Update UefiCpuPkg.dsc to guarantee all libraries and
> >> modules are
> >>> always built.  Add the following components.
> >>>
> >>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >>> *
> >>
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> >> sLib.inf
> >>>
> >>> ResetVector.inf is a binary INF, so no source builds
> >> are triggered
> >>> from adding this line.  However, a build with this
> >> component does
> >>> verify the contents of the INF file.
> >>>
> >>> Cc: Eric Dong <eric.dong@intel.com>
> >>> Cc: Ray Ni <ray.ni@intel.com>
> >>> Cc: Laszlo Ersek <lersek@redhat.com>
> >>> Signed-off-by: Michael D Kinney
> >> <michael.d.kinney@intel.com>
> >>> ---
> >>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> >> b/UefiCpuPkg/UefiCpuPkg.dsc
> >>> index e7dfe30eda..d28cb5cccb 100644
> >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> >>> @@ -121,6 +121,7 @@ [Components.IA32,
> Components.X64]
> >>>
> >> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> >>>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> >>>
> >>
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> >> .inf
> >>> +
> >>
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> >> sLib.inf
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> >> nHandlerLib.inf
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> >> tionHandlerLib.inf
> >>>
> >>>
> >>
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> >> nHandlerLib.in
> >>> f @@ -146,6 +147,7 @@ [Components.IA32,
> >> Components.X64]
> >>>
> >>
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> >> mmCpuFeaturesLibStm.inf
> >>>    }
> >>>
> >>
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> >>> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >>>
> >>>  [BuildOptions]
> >>>    *_*_*_CC_FLAGS = -D
> >> DISABLE_NEW_DEPRECATED_INTERFACES
> >>>
> >>
> >> Can we retire
> >>
> >>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> >>
> >> instead (in a separate patch)?
> >>
> >> Because, according to
> >>
> >>   git log --stat master --
> >> UefiCpuPkg/ResetVector/Vtf0/Bin/
> >>
> >> the most recent commit in which we updated the *.raw
> files has been
> >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
> finding SEC image of
> >> type TE.", 2011-09-28).
> >>
> >> I doubt anyone consumes this (binary) module, since
> Jordan's commits
> >> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
> ResetVector during
> >> the EDK II build", 2014-08-18)
> >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
> tables in NASM
> >> code", 2014-08-18).
> >>
> >> We've by now dropped all top-level *BinPkg package
> directories too.
> >>
> >> If we remove the Bin subdir, then we should probably
> >> remove:
> >> - Build.py
> >> - Tools/
> >> too.
> >>
> >> For the other addition (CpuCommonFeaturesLib): if
> that gets its own
> >> patch (after the removal of
> UefiCpuPkg/ResetVector/Vtf0/Bin/), then
> >> please add
> >>
> >> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >>
> >> to it.
> >>
> >> Thanks
> >> Laszlo
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49379): https://edk2.groups.io/g/devel/message/49379
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Michael D Kinney 4 years, 6 months ago 
Hi Eric,

I will enter a new BZ to remove binary.

Can you please review the current patch?

Thanks,

Mike

> -----Original Message-----
> From: Dong, Eric <eric.dong@intel.com>
> Sent: Tuesday, October 22, 2019 6:29 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray
> <ray.ni@intel.com>; Wei, David Y
> <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: RE: [Patch] UefiCpuPkg: Add missing components
> to UefiCpuPkg.dsc
> 
> Hi Mike and Laszlo,
> 
> I agree with Mike's proposal. We can submit new bugz to
> remove the binary.
> 
> Thanks,
> Eric
> 
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, October 23, 2019 7:39 AM
> To: Laszlo Ersek <lersek@redhat.com>;
> devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Wei,
> David Y <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: RE: [Patch] UefiCpuPkg: Add missing components
> to UefiCpuPkg.dsc
> 
> Laszlo,
> 
> Can we move forward with this patch and enter a new BZ
> to remove the binary module?
> 
> Mike
> 
> > -----Original Message-----
> > From: Laszlo Ersek <lersek@redhat.com>
> > Sent: Tuesday, October 22, 2019 4:27 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> Eric
> > <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Wei, David Y
> > <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> > Subject: Re: [Patch] UefiCpuPkg: Add missing
> components to
> > UefiCpuPkg.dsc
> >
> > (+David, +Prince)
> >
> > On 10/23/19 01:13, Kinney, Michael D wrote:
> > > Laszlo,
> > >
> > > I see 2 usages of this module in edk2-platforms:
> > >
> > > edk2-
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
> > ):
> > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > >
> > > edk2-
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
> > f(16):INF
> > > RuleOverride=RESET_VECTOR USE = IA32
> > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> >
> > Can we update those platforms to build the reset
> vector from source?
> >
> > Embedding a binary blob seems wrong in its own
> right...
> >
> > Anyway, if Ray and/or Eric are OK with the present
> patch, I won't try
> > to block it.
> >
> > Thanks,
> > Laszlo
> >
> > >> -----Original Message-----
> > >> From: Laszlo Ersek <lersek@redhat.com>
> > >> Sent: Tuesday, October 22, 2019 3:57 PM
> > >> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > >> devel@edk2.groups.io
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> > Eric
> > >> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> > >> Subject: Re: [Patch] UefiCpuPkg: Add missing
> > components to
> > >> UefiCpuPkg.dsc
> > >>
> > >> On 10/22/19 21:06, Michael D Kinney wrote:
> > >>> From: Sean Brogan <sean.brogan@microsoft.com>
> > >>>
> > >>>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> > >>>
> > >>> Update UefiCpuPkg.dsc to guarantee all libraries
> and
> > >> modules are
> > >>> always built.  Add the following components.
> > >>>
> > >>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > >>> *
> > >>
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > >> sLib.inf
> > >>>
> > >>> ResetVector.inf is a binary INF, so no source
> builds
> > >> are triggered
> > >>> from adding this line.  However, a build with this
> > >> component does
> > >>> verify the contents of the INF file.
> > >>>
> > >>> Cc: Eric Dong <eric.dong@intel.com>
> > >>> Cc: Ray Ni <ray.ni@intel.com>
> > >>> Cc: Laszlo Ersek <lersek@redhat.com>
> > >>> Signed-off-by: Michael D Kinney
> > >> <michael.d.kinney@intel.com>
> > >>> ---
> > >>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> > >>>  1 file changed, 2 insertions(+)
> > >>>
> > >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> > >> b/UefiCpuPkg/UefiCpuPkg.dsc
> > >>> index e7dfe30eda..d28cb5cccb 100644
> > >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> > >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> > >>> @@ -121,6 +121,7 @@ [Components.IA32,
> > Components.X64]
> > >>>
> > >>
> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> > >>>
> UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> > >>>
> > >>
> >
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> > >> .inf
> > >>> +
> > >>
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > >> sLib.inf
> > >>>
> > >>
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> > >> nHandlerLib.inf
> > >>>
> > >>
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> > >> tionHandlerLib.inf
> > >>>
> > >>>
> > >>
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> > >> nHandlerLib.in
> > >>> f @@ -146,6 +147,7 @@ [Components.IA32,
> > >> Components.X64]
> > >>>
> > >>
> >
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> > >> mmCpuFeaturesLibStm.inf
> > >>>    }
> > >>>
> > >>
> >
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> > >>> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > >>>
> > >>>  [BuildOptions]
> > >>>    *_*_*_CC_FLAGS = -D
> > >> DISABLE_NEW_DEPRECATED_INTERFACES
> > >>>
> > >>
> > >> Can we retire
> > >>
> > >>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> > >>
> > >> instead (in a separate patch)?
> > >>
> > >> Because, according to
> > >>
> > >>   git log --stat master --
> > >> UefiCpuPkg/ResetVector/Vtf0/Bin/
> > >>
> > >> the most recent commit in which we updated the
> *.raw
> > files has been
> > >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
> > finding SEC image of
> > >> type TE.", 2011-09-28).
> > >>
> > >> I doubt anyone consumes this (binary) module, since
> > Jordan's commits
> > >> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
> > ResetVector during
> > >> the EDK II build", 2014-08-18)
> > >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
> > tables in NASM
> > >> code", 2014-08-18).
> > >>
> > >> We've by now dropped all top-level *BinPkg package
> > directories too.
> > >>
> > >> If we remove the Bin subdir, then we should
> probably
> > >> remove:
> > >> - Build.py
> > >> - Tools/
> > >> too.
> > >>
> > >> For the other addition (CpuCommonFeaturesLib): if
> > that gets its own
> > >> patch (after the removal of
> > UefiCpuPkg/ResetVector/Vtf0/Bin/), then
> > >> please add
> > >>
> > >> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > >>
> > >> to it.
> > >>
> > >> Thanks
> > >> Laszlo
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49397): https://edk2.groups.io/g/devel/message/49397
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Michael D Kinney 4 years, 6 months ago 
I have enter 2 bugs.  One for SimicsX58SktPkg and one for UefiCpuPkg.

https://bugzilla.tianocore.org/show_bug.cgi?id=2307

https://bugzilla.tianocore.org/show_bug.cgi?id=2306


Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, October 23, 2019 8:15 AM
> To: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; devel@edk2.groups.io; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray
> <ray.ni@intel.com>; Wei, David Y
> <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: RE: [Patch] UefiCpuPkg: Add missing components
> to UefiCpuPkg.dsc
> 
> Hi Eric,
> 
> I will enter a new BZ to remove binary.
> 
> Can you please review the current patch?
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Dong, Eric <eric.dong@intel.com>
> > Sent: Tuesday, October 22, 2019 6:29 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> Laszlo Ersek
> > <lersek@redhat.com>; devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray
> > <ray.ni@intel.com>; Wei, David Y
> <david.y.wei@intel.com>; Agyeman,
> > Prince <prince.agyeman@intel.com>
> > Subject: RE: [Patch] UefiCpuPkg: Add missing
> components to
> > UefiCpuPkg.dsc
> >
> > Hi Mike and Laszlo,
> >
> > I agree with Mike's proposal. We can submit new bugz
> to remove the
> > binary.
> >
> > Thanks,
> > Eric
> >
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, October 23, 2019 7:39 AM
> > To: Laszlo Ersek <lersek@redhat.com>;
> > devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> Eric
> > <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Wei, David Y
> > <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> > Subject: RE: [Patch] UefiCpuPkg: Add missing
> components to
> > UefiCpuPkg.dsc
> >
> > Laszlo,
> >
> > Can we move forward with this patch and enter a new BZ
> to remove the
> > binary module?
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Laszlo Ersek <lersek@redhat.com>
> > > Sent: Tuesday, October 22, 2019 4:27 PM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> > Eric
> > > <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Wei, David Y
> > > <david.y.wei@intel.com>; Agyeman, Prince
> > <prince.agyeman@intel.com>
> > > Subject: Re: [Patch] UefiCpuPkg: Add missing
> > components to
> > > UefiCpuPkg.dsc
> > >
> > > (+David, +Prince)
> > >
> > > On 10/23/19 01:13, Kinney, Michael D wrote:
> > > > Laszlo,
> > > >
> > > > I see 2 usages of this module in edk2-platforms:
> > > >
> > > > edk2-
> > >
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
> > > ):
> > > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >
> > > > edk2-
> > >
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
> > > f(16):INF
> > > > RuleOverride=RESET_VECTOR USE = IA32
> > > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > >
> > > Can we update those platforms to build the reset
> > vector from source?
> > >
> > > Embedding a binary blob seems wrong in its own
> > right...
> > >
> > > Anyway, if Ray and/or Eric are OK with the present
> > patch, I won't try
> > > to block it.
> > >
> > > Thanks,
> > > Laszlo
> > >
> > > >> -----Original Message-----
> > > >> From: Laszlo Ersek <lersek@redhat.com>
> > > >> Sent: Tuesday, October 22, 2019 3:57 PM
> > > >> To: Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > > >> devel@edk2.groups.io
> > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>;
> Dong,
> > > Eric
> > > >> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > >> Subject: Re: [Patch] UefiCpuPkg: Add missing
> > > components to
> > > >> UefiCpuPkg.dsc
> > > >>
> > > >> On 10/22/19 21:06, Michael D Kinney wrote:
> > > >>> From: Sean Brogan <sean.brogan@microsoft.com>
> > > >>>
> > > >>>
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> > > >>>
> > > >>> Update UefiCpuPkg.dsc to guarantee all libraries
> > and
> > > >> modules are
> > > >>> always built.  Add the following components.
> > > >>>
> > > >>> *
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >>> *
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > > >> sLib.inf
> > > >>>
> > > >>> ResetVector.inf is a binary INF, so no source
> > builds
> > > >> are triggered
> > > >>> from adding this line.  However, a build with
> this
> > > >> component does
> > > >>> verify the contents of the INF file.
> > > >>>
> > > >>> Cc: Eric Dong <eric.dong@intel.com>
> > > >>> Cc: Ray Ni <ray.ni@intel.com>
> > > >>> Cc: Laszlo Ersek <lersek@redhat.com>
> > > >>> Signed-off-by: Michael D Kinney
> > > >> <michael.d.kinney@intel.com>
> > > >>> ---
> > > >>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> > > >>>  1 file changed, 2 insertions(+)
> > > >>>
> > > >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> > > >> b/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> index e7dfe30eda..d28cb5cccb 100644
> > > >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> @@ -121,6 +121,7 @@ [Components.IA32,
> > > Components.X64]
> > > >>>
> > > >>
> > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> > > >>>
> > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> > > >> .inf
> > > >>> +
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > > >> sLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> > > >> nHandlerLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> > > >> tionHandlerLib.inf
> > > >>>
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> > > >> nHandlerLib.in
> > > >>> f @@ -146,6 +147,7 @@ [Components.IA32,
> > > >> Components.X64]
> > > >>>
> > > >>
> > >
> >
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> > > >> mmCpuFeaturesLibStm.inf
> > > >>>    }
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> > > >>> +
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >>>
> > > >>>  [BuildOptions]
> > > >>>    *_*_*_CC_FLAGS = -D
> > > >> DISABLE_NEW_DEPRECATED_INTERFACES
> > > >>>
> > > >>
> > > >> Can we retire
> > > >>
> > > >>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> > > >>
> > > >> instead (in a separate patch)?
> > > >>
> > > >> Because, according to
> > > >>
> > > >>   git log --stat master --
> > > >> UefiCpuPkg/ResetVector/Vtf0/Bin/
> > > >>
> > > >> the most recent commit in which we updated the
> > *.raw
> > > files has been
> > > >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
> > > finding SEC image of
> > > >> type TE.", 2011-09-28).
> > > >>
> > > >> I doubt anyone consumes this (binary) module,
> since
> > > Jordan's commits
> > > >> - 5a1f324d946c ("UefiCpuPkg: Support building
> VTF0
> > > ResetVector during
> > > >> the EDK II build", 2014-08-18)
> > > >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
> > > tables in NASM
> > > >> code", 2014-08-18).
> > > >>
> > > >> We've by now dropped all top-level *BinPkg
> package
> > > directories too.
> > > >>
> > > >> If we remove the Bin subdir, then we should
> > probably
> > > >> remove:
> > > >> - Build.py
> > > >> - Tools/
> > > >> too.
> > > >>
> > > >> For the other addition (CpuCommonFeaturesLib): if
> > > that gets its own
> > > >> patch (after the removal of
> > > UefiCpuPkg/ResetVector/Vtf0/Bin/), then
> > > >> please add
> > > >>
> > > >> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > > >>
> > > >> to it.
> > > >>
> > > >> Thanks
> > > >> Laszlo
> > > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49400): https://edk2.groups.io/g/devel/message/49400
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Agyeman, Prince 4 years, 6 months ago 
Thanks Mike !

Prince

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Wednesday, October 23, 2019 9:07 AM
To: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray <ray.ni@intel.com>; Wei, David Y <david.y.wei@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: RE: [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc

I have enter 2 bugs.  One for SimicsX58SktPkg and one for UefiCpuPkg.

https://bugzilla.tianocore.org/show_bug.cgi?id=2307

https://bugzilla.tianocore.org/show_bug.cgi?id=2306


Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, October 23, 2019 8:15 AM
> To: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek 
> <lersek@redhat.com>; devel@edk2.groups.io; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray 
> <ray.ni@intel.com>; Wei, David Y <david.y.wei@intel.com>; Agyeman, 
> Prince <prince.agyeman@intel.com>
> Subject: RE: [Patch] UefiCpuPkg: Add missing components to 
> UefiCpuPkg.dsc
> 
> Hi Eric,
> 
> I will enter a new BZ to remove binary.
> 
> Can you please review the current patch?
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Dong, Eric <eric.dong@intel.com>
> > Sent: Tuesday, October 22, 2019 6:29 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> Laszlo Ersek
> > <lersek@redhat.com>; devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray 
> > <ray.ni@intel.com>; Wei, David Y
> <david.y.wei@intel.com>; Agyeman,
> > Prince <prince.agyeman@intel.com>
> > Subject: RE: [Patch] UefiCpuPkg: Add missing
> components to
> > UefiCpuPkg.dsc
> >
> > Hi Mike and Laszlo,
> >
> > I agree with Mike's proposal. We can submit new bugz
> to remove the
> > binary.
> >
> > Thanks,
> > Eric
> >
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, October 23, 2019 7:39 AM
> > To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Kinney, 
> > Michael D
> <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> Eric
> > <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Wei, David Y
> > <david.y.wei@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> > Subject: RE: [Patch] UefiCpuPkg: Add missing
> components to
> > UefiCpuPkg.dsc
> >
> > Laszlo,
> >
> > Can we move forward with this patch and enter a new BZ
> to remove the
> > binary module?
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Laszlo Ersek <lersek@redhat.com>
> > > Sent: Tuesday, October 22, 2019 4:27 PM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> > > devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
> > Eric
> > > <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Wei, David Y
> > > <david.y.wei@intel.com>; Agyeman, Prince
> > <prince.agyeman@intel.com>
> > > Subject: Re: [Patch] UefiCpuPkg: Add missing
> > components to
> > > UefiCpuPkg.dsc
> > >
> > > (+David, +Prince)
> > >
> > > On 10/23/19 01:13, Kinney, Michael D wrote:
> > > > Laszlo,
> > > >
> > > > I see 2 usages of this module in edk2-platforms:
> > > >
> > > > edk2-
> > >
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
> > > ):
> > > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >
> > > > edk2-
> > >
> >
> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
> > > f(16):INF
> > > > RuleOverride=RESET_VECTOR USE = IA32 
> > > > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > >
> > > Can we update those platforms to build the reset
> > vector from source?
> > >
> > > Embedding a binary blob seems wrong in its own
> > right...
> > >
> > > Anyway, if Ray and/or Eric are OK with the present
> > patch, I won't try
> > > to block it.
> > >
> > > Thanks,
> > > Laszlo
> > >
> > > >> -----Original Message-----
> > > >> From: Laszlo Ersek <lersek@redhat.com>
> > > >> Sent: Tuesday, October 22, 2019 3:57 PM
> > > >> To: Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > > >> devel@edk2.groups.io
> > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>;
> Dong,
> > > Eric
> > > >> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > >> Subject: Re: [Patch] UefiCpuPkg: Add missing
> > > components to
> > > >> UefiCpuPkg.dsc
> > > >>
> > > >> On 10/22/19 21:06, Michael D Kinney wrote:
> > > >>> From: Sean Brogan <sean.brogan@microsoft.com>
> > > >>>
> > > >>>
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> > > >>>
> > > >>> Update UefiCpuPkg.dsc to guarantee all libraries
> > and
> > > >> modules are
> > > >>> always built.  Add the following components.
> > > >>>
> > > >>> *
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >>> *
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > > >> sLib.inf
> > > >>>
> > > >>> ResetVector.inf is a binary INF, so no source
> > builds
> > > >> are triggered
> > > >>> from adding this line.  However, a build with
> this
> > > >> component does
> > > >>> verify the contents of the INF file.
> > > >>>
> > > >>> Cc: Eric Dong <eric.dong@intel.com>
> > > >>> Cc: Ray Ni <ray.ni@intel.com>
> > > >>> Cc: Laszlo Ersek <lersek@redhat.com>
> > > >>> Signed-off-by: Michael D Kinney
> > > >> <michael.d.kinney@intel.com>
> > > >>> ---
> > > >>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
> > > >>>  1 file changed, 2 insertions(+)
> > > >>>
> > > >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
> > > >> b/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> index e7dfe30eda..d28cb5cccb 100644
> > > >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> > > >>> @@ -121,6 +121,7 @@ [Components.IA32,
> > > Components.X64]
> > > >>>
> > > >>
> > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> > > >>>
> > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
> > > >> .inf
> > > >>> +
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
> > > >> sLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
> > > >> nHandlerLib.inf
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
> > > >> tionHandlerLib.inf
> > > >>>
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
> > > >> nHandlerLib.in
> > > >>> f @@ -146,6 +147,7 @@ [Components.IA32,
> > > >> Components.X64]
> > > >>>
> > > >>
> > >
> >
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
> > > >> mmCpuFeaturesLibStm.inf
> > > >>>    }
> > > >>>
> > > >>
> > >
> >
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> > > >>> +
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> > > >>>
> > > >>>  [BuildOptions]
> > > >>>    *_*_*_CC_FLAGS = -D
> > > >> DISABLE_NEW_DEPRECATED_INTERFACES
> > > >>>
> > > >>
> > > >> Can we retire
> > > >>
> > > >>   UefiCpuPkg/ResetVector/Vtf0/Bin/
> > > >>
> > > >> instead (in a separate patch)?
> > > >>
> > > >> Because, according to
> > > >>
> > > >>   git log --stat master --
> > > >> UefiCpuPkg/ResetVector/Vtf0/Bin/
> > > >>
> > > >> the most recent commit in which we updated the
> > *.raw
> > > files has been
> > > >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
> > > finding SEC image of
> > > >> type TE.", 2011-09-28).
> > > >>
> > > >> I doubt anyone consumes this (binary) module,
> since
> > > Jordan's commits
> > > >> - 5a1f324d946c ("UefiCpuPkg: Support building
> VTF0
> > > ResetVector during
> > > >> the EDK II build", 2014-08-18)
> > > >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
> > > tables in NASM
> > > >> code", 2014-08-18).
> > > >>
> > > >> We've by now dropped all top-level *BinPkg
> package
> > > directories too.
> > > >>
> > > >> If we remove the Bin subdir, then we should
> > probably
> > > >> remove:
> > > >> - Build.py
> > > >> - Tools/
> > > >> too.
> > > >>
> > > >> For the other addition (CpuCommonFeaturesLib): if
> > > that gets its own
> > > >> patch (after the removal of
> > > UefiCpuPkg/ResetVector/Vtf0/Bin/), then
> > > >> please add
> > > >>
> > > >> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > > >>
> > > >> to it.
> > > >>
> > > >> Thanks
> > > >> Laszlo
> > > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49401): https://edk2.groups.io/g/devel/message/49401
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Laszlo Ersek 4 years, 6 months ago 
On 10/23/19 01:38, Kinney, Michael D wrote:
> Laszlo,
> 
> Can we move forward with this patch and enter a new
> BZ to remove the binary module?

Sure, thank you!
Laszlo

>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Tuesday, October 22, 2019 4:27 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>> devel@edk2.groups.io
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
>> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Wei,
>> David Y <david.y.wei@intel.com>; Agyeman, Prince
>> <prince.agyeman@intel.com>
>> Subject: Re: [Patch] UefiCpuPkg: Add missing components
>> to UefiCpuPkg.dsc
>>
>> (+David, +Prince)
>>
>> On 10/23/19 01:13, Kinney, Michael D wrote:
>>> Laszlo,
>>>
>>> I see 2 usages of this module in edk2-platforms:
>>>
>>> edk2-
>> platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13
>> ):
>>> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>>
>>> edk2-
>> platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fd
>> f(16):INF
>>> RuleOverride=RESET_VECTOR USE = IA32
>>> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>
>> Can we update those platforms to build the reset vector
>> from source?
>>
>> Embedding a binary blob seems wrong in its own right...
>>
>> Anyway, if Ray and/or Eric are OK with the present
>> patch, I won't try to block it.
>>
>> Thanks,
>> Laszlo
>>
>>>> -----Original Message-----
>>>> From: Laszlo Ersek <lersek@redhat.com>
>>>> Sent: Tuesday, October 22, 2019 3:57 PM
>>>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>>>> devel@edk2.groups.io
>>>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong,
>> Eric
>>>> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
>>>> Subject: Re: [Patch] UefiCpuPkg: Add missing
>> components to
>>>> UefiCpuPkg.dsc
>>>>
>>>> On 10/22/19 21:06, Michael D Kinney wrote:
>>>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>>>
>>>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
>>>>>
>>>>> Update UefiCpuPkg.dsc to guarantee all libraries and
>>>> modules are
>>>>> always built.  Add the following components.
>>>>>
>>>>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>>>> *
>>>>
>> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
>>>> sLib.inf
>>>>>
>>>>> ResetVector.inf is a binary INF, so no source builds
>>>> are triggered
>>>>> from adding this line.  However, a build with this
>>>> component does
>>>>> verify the contents of the INF file.
>>>>>
>>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>>> Cc: Ray Ni <ray.ni@intel.com>
>>>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>>>> Signed-off-by: Michael D Kinney
>>>> <michael.d.kinney@intel.com>
>>>>> ---
>>>>>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc
>>>> b/UefiCpuPkg/UefiCpuPkg.dsc
>>>>> index e7dfe30eda..d28cb5cccb 100644
>>>>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
>>>>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
>>>>> @@ -121,6 +121,7 @@ [Components.IA32,
>> Components.X64]
>>>>>
>>>> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>>>>>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
>>>>>
>>>>
>> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib
>>>> .inf
>>>>> +
>>>>
>> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature
>>>> sLib.inf
>>>>>
>>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio
>>>> nHandlerLib.inf
>>>>>
>>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep
>>>> tionHandlerLib.inf
>>>>>
>>>>>
>>>>
>> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio
>>>> nHandlerLib.in
>>>>> f @@ -146,6 +147,7 @@ [Components.IA32,
>>>> Components.X64]
>>>>>
>>>>
>> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S
>>>> mmCpuFeaturesLibStm.inf
>>>>>    }
>>>>>
>>>>
>> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
>>>>> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
>>>>>
>>>>>  [BuildOptions]
>>>>>    *_*_*_CC_FLAGS = -D
>>>> DISABLE_NEW_DEPRECATED_INTERFACES
>>>>>
>>>>
>>>> Can we retire
>>>>
>>>>   UefiCpuPkg/ResetVector/Vtf0/Bin/
>>>>
>>>> instead (in a separate patch)?
>>>>
>>>> Because, according to
>>>>
>>>>   git log --stat master --
>>>> UefiCpuPkg/ResetVector/Vtf0/Bin/
>>>>
>>>> the most recent commit in which we updated the *.raw
>> files has been
>>>> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for
>> finding SEC image of
>>>> type TE.", 2011-09-28).
>>>>
>>>> I doubt anyone consumes this (binary) module, since
>> Jordan's commits
>>>> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0
>> ResetVector during
>>>> the EDK II build", 2014-08-18)
>>>> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page
>> tables in NASM
>>>> code", 2014-08-18).
>>>>
>>>> We've by now dropped all top-level *BinPkg package
>> directories too.
>>>>
>>>> If we remove the Bin subdir, then we should probably
>>>> remove:
>>>> - Build.py
>>>> - Tools/
>>>> too.
>>>>
>>>> For the other addition (CpuCommonFeaturesLib): if
>> that gets its own
>>>> patch (after the removal of
>> UefiCpuPkg/ResetVector/Vtf0/Bin/), then
>>>> please add
>>>>
>>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>>
>>>> to it.
>>>>
>>>> Thanks
>>>> Laszlo
>>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49423): https://edk2.groups.io/g/devel/message/49423
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Dong, Eric 4 years, 6 months ago 
Reviewed-by: Eric Dong <eric.dong@intel.com>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney
Sent: Wednesday, October 23, 2019 3:07 AM
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc

From: Sean Brogan <sean.brogan@microsoft.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=2255

Update UefiCpuPkg.dsc to guarantee all libraries and modules are always built.  Add the following components.

* UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
* UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf

ResetVector.inf is a binary INF, so no source builds are triggered from adding this line.  However, a build with this component does verify the contents of the INF file.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index e7dfe30eda..d28cb5cccb 100644
--- a/UefiCpuPkg/UefiCpuPkg.dsc
+++ b/UefiCpuPkg/UefiCpuPkg.dsc
@@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
   UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
   UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
   UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
+  UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
   UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
@@ -146,6 +147,7 @@ [Components.IA32, Components.X64]
       SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf
   }
   UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
+  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
--
2.21.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49406): https://edk2.groups.io/g/devel/message/49406
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc
Posted by Ni, Ray 4 years, 6 months ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Dong, Eric <eric.dong@intel.com>
> Sent: Thursday, October 24, 2019 8:07 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray <ray.ni@intel.com>;
> Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to
> UefiCpuPkg.dsc
> 
> Reviewed-by: Eric Dong <eric.dong@intel.com>
> 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Wednesday, October 23, 2019 3:07 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to
> UefiCpuPkg.dsc
> 
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2255
> 
> Update UefiCpuPkg.dsc to guarantee all libraries and modules are always built.
> Add the following components.
> 
> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> * UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
> 
> ResetVector.inf is a binary INF, so no source builds are triggered from adding
> this line.  However, a build with this component does verify the contents of the
> INF file.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index
> e7dfe30eda..d28cb5cccb 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> @@ -121,6 +121,7 @@ [Components.IA32, Components.X64]
>    UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>    UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
>    UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf
> +  UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
>    UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf
> 
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
>    UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
> @@ -146,6 +147,7 @@ [Components.IA32, Components.X64]
> 
> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatures
> LibStm.inf
>    }
>    UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
> +  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> 
>  [BuildOptions]
>    *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49407): https://edk2.groups.io/g/devel/message/49407
Mute This Topic: https://groups.io/mt/36448030/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.