1. Patchew
  2. EDK2
  3. [edk2-devel] [edk2-platforms][PATCH V1 00/17] Intel Board Package Cleanup
  4. View patch

[edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags

Kubacki, Michael A posted 17 patches 6 years, 4 months ago
[edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags
Posted by Kubacki, Michael A 6 years, 4 months ago 
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2246

The DSC LibraryClass files in CoffeelakeSiliconPkg that are intended
to be included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc,
and SiPkgCommonLib.dsc should have section tags so that they are
not dependent on the top-level DSC file to place the include file
in the correct location in the DSC file and better define the
applicability of their library content.

This change adds section tags for the library class related files.
The component files may be built differently in the consuming package
depending on their architecture requirements so those are not
modified.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc | 1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc    | 1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
index 2df08c6d01..7a9911e825 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
@@ -13,6 +13,7 @@
 #
 DEFINE  PCH = Cnl
 
+[LibraryClasses.common]
 #
 # Cpu
 #
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
index 214de06d58..e21004c993 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
@@ -7,6 +7,7 @@
 #
 ##
 
+[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIVER,LibraryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER]
 #
 # Silicon Init Dxe Library
 #
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
index 6e244a6ded..bc3fcabd4d 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
@@ -7,6 +7,7 @@
 #
 ##
 
+[LibraryClasses]
 #
 # Silicon Init Pei Library
 #
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48538): https://edk2.groups.io/g/devel/message/48538
Mute This Topic: https://groups.io/mt/34439446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags
Posted by Chiu, Chasel 6 years, 4 months ago 
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>
> Subject: [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC
> include file section tags
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2246
> 
> The DSC LibraryClass files in CoffeelakeSiliconPkg that are intended to be
> included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and
> SiPkgCommonLib.dsc should have section tags so that they are not
> dependent on the top-level DSC file to place the include file in the correct
> location in the DSC file and better define the applicability of their library
> content.
> 
> This change adds section tags for the library class related files.
> The component files may be built differently in the consuming package
> depending on their architecture requirements so those are not modified.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc | 1 +
>  Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc    | 1 +
>  Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc    | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
> b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
> index 2df08c6d01..7a9911e825 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
> @@ -13,6 +13,7 @@
>  #
>  DEFINE  PCH = Cnl
> 
> +[LibraryClasses.common]
>  #
>  # Cpu
>  #
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
> b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
> index 214de06d58..e21004c993 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
> @@ -7,6 +7,7 @@
>  #
>  ##
> 
> +[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIV
> ER,Li
> +braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,Libr
> aryCl
> +asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER
> ]
>  #
>  # Silicon Init Dxe Library
>  #
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
> b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
> index 6e244a6ded..bc3fcabd4d 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
> @@ -7,6 +7,7 @@
>  #
>  ##
> 
> +[LibraryClasses]
>  #
>  # Silicon Init Pei Library
>  #
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48598): https://edk2.groups.io/g/devel/message/48598
Mute This Topic: https://groups.io/mt/34439446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags
Posted by Nate DeSimone 6 years, 4 months ago 
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2246

The DSC LibraryClass files in CoffeelakeSiliconPkg that are intended to be included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and SiPkgCommonLib.dsc should have section tags so that they are not dependent on the top-level DSC file to place the include file in the correct location in the DSC file and better define the applicability of their library content.

This change adds section tags for the library class related files.
The component files may be built differently in the consuming package depending on their architecture requirements so those are not modified.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc | 1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc    | 1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
index 2df08c6d01..7a9911e825 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc
@@ -13,6 +13,7 @@
 #
 DEFINE  PCH = Cnl
 
+[LibraryClasses.common]
 #
 # Cpu
 #
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
index 214de06d58..e21004c993 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc
@@ -7,6 +7,7 @@
 #
 ##
 
+[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIVER,Li
+braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,LibraryCl
+asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER]
 #
 # Silicon Init Dxe Library
 #
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
index 6e244a6ded..bc3fcabd4d 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc
@@ -7,6 +7,7 @@
 #
 ##
 
+[LibraryClasses]
 #
 # Silicon Init Pei Library
 #
--
2.16.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48790): https://edk2.groups.io/g/devel/message/48790
Mute This Topic: https://groups.io/mt/34439446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.