Add Laml/Lasa to TPM2 acpi table

[edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table

Posted by Yao, Jiewen 4 years, 6 months ago

Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=978

This patch series adds Laml/Lasa to TPM2 ACPI table.

This is defined by TPM2 ACPI table Version 1.2, Revision 8.
It only impacts the TPM2 ACPI table version 4 or above.
The default TPM2 ACPI table version is still 3 to keep maximum compatibility.

The new fields are only for TCG2 log format, but not TCG1.2 log format.

This new fields are optional and won't be consumed by OS/Loader, because
the OS/loader still uses TCG2_PROTOCOL to get the event log.

These fields are important for OS utility, because the OS utility can
not use TCG2_PROTOCOL.

Test:
Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table.
Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM driver
installs ALMA/ALSA in TPM2 table.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>

Jiewen Yao (3):
  MdePkg/Include: correct Lasa in Tpm2Acpi.
  SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2.
  SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI.

 MdePkg/Include/IndustryStandard/Tpm2Acpi.h |  2 +-
 SecurityPkg/SecurityPkg.dec                |  8 ++++++
 SecurityPkg/SecurityPkg.uni                |  9 ++++++
 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c          | 32 ++++++++++++++++++----
 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf        |  3 ++
 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c          | 32 ++++++++++++++++++++--
 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf        |  2 ++
 7 files changed, 78 insertions(+), 10 deletions(-)

-- 
2.19.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48259): https://edk2.groups.io/g/devel/message/48259
Mute This Topic: https://groups.io/mt/34330938/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table

Posted by Wang, Jian J 4 years, 6 months ago

Thanks for implementing this feature. Just one minor comment. The BZ link should also
be mentioned in patch1-3, not just cover letter. With this addressed, for the whole series,

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Sunday, September 29, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table
> 
> Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=978
> 
> This patch series adds Laml/Lasa to TPM2 ACPI table.
> 
> This is defined by TPM2 ACPI table Version 1.2, Revision 8.
> It only impacts the TPM2 ACPI table version 4 or above.
> The default TPM2 ACPI table version is still 3 to keep maximum compatibility.
> 
> The new fields are only for TCG2 log format, but not TCG1.2 log format.
> 
> This new fields are optional and won't be consumed by OS/Loader, because
> the OS/loader still uses TCG2_PROTOCOL to get the event log.
> 
> These fields are important for OS utility, because the OS utility can
> not use TCG2_PROTOCOL.
> 
> Test:
> Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table.
> Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM driver
> installs ALMA/ALSA in TPM2 table.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> 
> Jiewen Yao (3):
>   MdePkg/Include: correct Lasa in Tpm2Acpi.
>   SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2.
>   SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI.
> 
>  MdePkg/Include/IndustryStandard/Tpm2Acpi.h |  2 +-
>  SecurityPkg/SecurityPkg.dec                |  8 ++++++
>  SecurityPkg/SecurityPkg.uni                |  9 ++++++
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c          | 32 ++++++++++++++++++----
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf        |  3 ++
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c          | 32 ++++++++++++++++++++--
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf        |  2 ++
>  7 files changed, 78 insertions(+), 10 deletions(-)
> 
> --
> 2.19.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48277): https://edk2.groups.io/g/devel/message/48277
Mute This Topic: https://groups.io/mt/34330938/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table

Posted by Yao, Jiewen 4 years, 6 months ago

Got it. Thanks for the reminder. I will follow.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Wang, Jian J <jian.j.wang@intel.com>
> Sent: Monday, September 30, 2019 1:23 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
> Cc: Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: RE: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table
> 
> Thanks for implementing this feature. Just one minor comment. The BZ link
> should also
> be mentioned in patch1-3, not just cover letter. With this addressed, for the
> whole series,
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> > Sent: Sunday, September 29, 2019 2:16 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>
> > Subject: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table
> >
> > Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=978
> >
> > This patch series adds Laml/Lasa to TPM2 ACPI table.
> >
> > This is defined by TPM2 ACPI table Version 1.2, Revision 8.
> > It only impacts the TPM2 ACPI table version 4 or above.
> > The default TPM2 ACPI table version is still 3 to keep maximum compatibility.
> >
> > The new fields are only for TCG2 log format, but not TCG1.2 log format.
> >
> > This new fields are optional and won't be consumed by OS/Loader, because
> > the OS/loader still uses TCG2_PROTOCOL to get the event log.
> >
> > These fields are important for OS utility, because the OS utility can
> > not use TCG2_PROTOCOL.
> >
> > Test:
> > Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table.
> > Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM
> driver
> > installs ALMA/ALSA in TPM2 table.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Jiewen Yao (3):
> >   MdePkg/Include: correct Lasa in Tpm2Acpi.
> >   SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2.
> >   SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI.
> >
> >  MdePkg/Include/IndustryStandard/Tpm2Acpi.h |  2 +-
> >  SecurityPkg/SecurityPkg.dec                |  8 ++++++
> >  SecurityPkg/SecurityPkg.uni                |  9 ++++++
> >  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c          | 32 ++++++++++++++++++----
> >  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf        |  3 ++
> >  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c          | 32 ++++++++++++++++++++--
> >  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf        |  2 ++
> >  7 files changed, 78 insertions(+), 10 deletions(-)
> >
> > --
> > 2.19.2.windows.1
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48278): https://edk2.groups.io/g/devel/message/48278
Mute This Topic: https://groups.io/mt/34330938/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-