[v3] *** Add VS2019 Support ***

[edk2-devel] [PATCH v3 0/2] * Add VS2019 Support *

Cheng, Ching JenX posted 2 patches 4 years, 7 months ago

Diff against v1 v2
Download series mbox

Failed in applying to current master (apply log)

BaseTools/Conf/tools_def.template | 220 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++-------
BaseTools/set_vsprefix_envs.bat   |  86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
BaseTools/toolsetup.bat           |  16 +++++++++++++---
edksetup.bat                      |   6 ++++--
5 files changed, 321 insertions(+), 44 deletions(-)

Expand all Fold all

[edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***

Posted by Cheng, Ching JenX 4 years, 7 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182

In order to support VS2019 on EDK2, the following patches was modified def and batch files
1. Add VS2019 x86/64 definitions on tools_def.template
2. Add VS2019 support on toolsetup batches, and add version check with command vswhere
     Because VS2019 and VS2017 using the same vswhere to get the InstallationPath

v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST
v3: In 02/02, In BaseTools\set_vsprefix_envs.bat,
    move WINSDK10_PREFIX setting into VCToolsInstallDir check condition.

Ching JenX Cheng (2):
  Add VS2019 Toolchain def
  Add VS2019 Support on ToolSetup Batches

 BaseTools/Conf/tools_def.template | 220 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++-------
 BaseTools/set_vsprefix_envs.bat   |  86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
 BaseTools/toolsetup.bat           |  16 +++++++++++++---
 edksetup.bat                      |   6 ++++--
 5 files changed, 321 insertions(+), 44 deletions(-)

--
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47570): https://edk2.groups.io/g/devel/message/47570
Mute This Topic: https://groups.io/mt/34197616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***

Posted by Liming Gao 4 years, 7 months ago

Push 6b80310f34199d1f62e45e40fa902734735091fa..670c903a68f214463f12c0c9619c162a0f342518

You can update BZ 2182 and close it. 

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Cheng, Ching JenX
>Sent: Thursday, September 19, 2019 4:52 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
>
>In order to support VS2019 on EDK2, the following patches was modified def
>and batch files
>1. Add VS2019 x86/64 definitions on tools_def.template
>2. Add VS2019 support on toolsetup batches, and add version check with
>command vswhere
>     Because VS2019 and VS2017 using the same vswhere to get the
>InstallationPath
>
>v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and
>VS2019_HOST to VS_HOST
>v3: In 02/02, In BaseTools\set_vsprefix_envs.bat,
>    move WINSDK10_PREFIX setting into VCToolsInstallDir check condition.
>
>Ching JenX Cheng (2):
>  Add VS2019 Toolchain def
>  Add VS2019 Support on ToolSetup Batches
>
> BaseTools/Conf/tools_def.template | 220
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>++++++++++++++++++++++++-------------------
> BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++---
>----
> BaseTools/set_vsprefix_envs.bat   |  86
>+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>++++++++++++++-------------
> BaseTools/toolsetup.bat           |  16 +++++++++++++---
> edksetup.bat                      |   6 ++++--
> 5 files changed, 321 insertions(+), 44 deletions(-)
>
>--
>2.21.0.windows.1
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47882): https://edk2.groups.io/g/devel/message/47882
Mute This Topic: https://groups.io/mt/34197616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-